Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31692461
In src/main/org/apache/tools/ant/types/ModuleVersion.java:
In src/main/org/apache/tools/ant/types/ModuleVersion.java on line 51:
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31692386
fixed with 876376a8d - many thanks for catching this @twogee
---
-
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31692367
Thanks, perhaps it's time for [multi-release
jars](https://maven.apache.org/plugins/maven-compiler-plugin/multirelease.html)?
---
-
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31692317
I'll take care of it.
---
-
To unsubscribe, e-mail: dev-unsubsc
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31691241
Yes, that's the idea.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user craigpell commented on the pull request:
https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31691208
It appears I can just add
`org/apache/tools/ant/taskdefs/modules/` to the excludes and
testExcludes elements to do that, correct?
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31691133
`src/etc/poms/ant/pom.xml` should exclude the new tasks from compilation;
Maven builds are Java 8 only.
---
---
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/80
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/80#discussion_r241292280
--- Diff: src/main/org/apache/tools/ant/taskdefs/modules/Jmod.java ---
@@ -0,0 +1,1282 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user craigpell commented on a diff in the pull request:
https://github.com/apache/ant/pull/80#discussion_r241010770
--- Diff: src/main/org/apache/tools/ant/taskdefs/modules/Jmod.java ---
@@ -0,0 +1,1282 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/81
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/80#discussion_r240889855
--- Diff: src/main/org/apache/tools/ant/taskdefs/modules/Jmod.java ---
@@ -0,0 +1,1282 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
GitHub user mharmer opened a pull request:
https://github.com/apache/ant/pull/81
Fix rare ConcurrentModificationException when running with Parallel-Ant
executor.
This resolves a rare race condition when running with the
[Parallel-Ant](https://github.com/codeaholics/parallel-ant) e
GitHub user craigpell opened a pull request:
https://github.com/apache/ant/pull/80
Added tasks for JDK's jmod and jlink tools.
Support for the jmod and jlink tools present in the JDK since Java 9. Now
that Java 11 has no standalone JRE, officially, these tools are the only way to
Github user twogee closed the pull request at:
https://github.com/apache/ant/pull/79
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user twogee closed the pull request at:
https://github.com/apache/ant/pull/78
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/77
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user twogee commented on a diff in the pull request:
https://github.com/apache/ant/pull/78#discussion_r232795363
--- Diff: src/tests/junit/org/apache/tools/ant/types/CharSetTest.java ---
@@ -0,0 +1,20 @@
+package org.apache.tools.ant.types;
+
+import org.apache.to
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/78#discussion_r232673446
--- Diff: src/tests/junit/org/apache/tools/ant/types/CharSetTest.java ---
@@ -0,0 +1,20 @@
+package org.apache.tools.ant.types;
+
+import org.apache.t
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232669831
--- Diff: src/main/org/apache/tools/ant/types/TarFileSet.java ---
@@ -263,9 +273,7 @@ public Object clone() {
private void checkTarFileSetAttributesAllow
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232669396
--- Diff: src/main/org/apache/tools/ant/types/PropertySet.java ---
@@ -424,8 +424,8 @@ private void addPropertyNames(Set names,
Map props) {
* referenc
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232669259
--- Diff: src/main/org/apache/tools/ant/types/Path.java ---
@@ -721,7 +721,7 @@ public synchronized boolean isFilesystemOnly() {
* @return the passed in
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232669102
--- Diff: src/main/org/apache/tools/ant/types/FilterSet.java ---
@@ -235,8 +235,8 @@ protected FilterSet(FilterSet filterset) {
*
* @return th
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232668570
--- Diff: src/main/org/apache/tools/ant/types/FileList.java ---
@@ -137,13 +144,10 @@ public void setFiles(String filenames) {
}
/**
-
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232668389
--- Diff: src/main/org/apache/tools/ant/types/FileList.java ---
@@ -98,6 +98,13 @@ public File getDir(Project p) {
return dir;
}
+
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232667496
--- Diff: src/main/org/apache/tools/ant/types/ArchiveFileSet.java ---
@@ -574,11 +570,8 @@ public int getDirMode() {
* fileset if the project has been s
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232667773
--- Diff: src/main/org/apache/tools/ant/types/DataType.java ---
@@ -196,24 +196,44 @@ public static void
pushAndInvokeCircularReferenceCheck(DataType dt,
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232666118
--- Diff: src/main/org/apache/tools/ant/types/AbstractFileSet.java ---
@@ -915,7 +920,7 @@ public String toString() {
@Override
public synchroni
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/79#discussion_r232665835
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/extension/ExtensionSet.java ---
@@ -34,8 +34,7 @@
*
* @ant.datatype name="extension-set"
GitHub user twogee opened a pull request:
https://github.com/apache/ant/pull/79
Make DataType and Reference generic
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twogee/ant checked-reference
Alternatively you can review and ap
GitHub user twogee opened a pull request:
https://github.com/apache/ant/pull/78
A new CharSet type to hold available Charset names
I believe that might be useful when validating "encoding" (or "charset")
attributes
You can merge this pull request into a Git repository by running:
GitHub user reudismam opened a pull request:
https://github.com/apache/ant/pull/77
Avoid FileInputStream and FileOutputStream.
Avoid FileInputStream and FileOutputStream. These classes override the
finalize method. As a result, their objects are only cleaned when the garbage
collec
Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/76
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user jaikiran commented on the pull request:
https://github.com/apache/ant/commit/0cb9d22b77dda1dcabba91d4c2a1616d0042d16c#commitcomment-31143975
In
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/StandaloneLauncher.java:
In
src/main/org/apache/tools/ant/task
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/0cb9d22b77dda1dcabba91d4c2a1616d0042d16c#commitcomment-31140697
In
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/StandaloneLauncher.java:
In
src/main/org/apache/tools/ant/taskde
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/76
bz-43144 - Improve the performance of the tar task when it uses a zipfileset
https://bz.apache.org/bugzilla/show_bug.cgi?id=43144 is an issue where
users have reported that the tar task is extremely sl
Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/69
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/d100b900324ad91f3de6e8c323720e1676bbb28d#commitcomment-30938289
In src/main/org/apache/tools/ant/taskdefs/AbstractJarSignerTask.java:
In src/main/org/apache/tools/ant/taskdefs/AbstractJarSignerT
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/d100b900324ad91f3de6e8c323720e1676bbb28d#commitcomment-30927697
In src/main/org/apache/tools/ant/taskdefs/AbstractJarSignerTask.java:
In src/main/org/apache/tools/ant/taskdefs/AbstractJarSignerTa
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/69
Allow more control over JUnit libraries and Ant runtime libraries for users
of junitlauncher
I've been sitting on these changes for a while now trying to complete this
work and then get some inputs. B
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/048015b7d891edd74c8d458aa582a504511872c6#commitcomment-30701261
In src/main/org/apache/tools/ant/taskdefs/Javadoc.java:
In src/main/org/apache/tools/ant/taskdefs/Javadoc.java on line 572:
St
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/048015b7d891edd74c8d458aa582a504511872c6#commitcomment-30695466
In src/main/org/apache/tools/ant/taskdefs/Javadoc.java:
In src/main/org/apache/tools/ant/taskdefs/Javadoc.java on line 572:
Iro
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/68
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/68
bz-62655 throw a BuildException from augment task
Reference https://bz.apache.org/bugzilla/show_bug.cgi?id=62655
The manual of the augment task[1] states that it's supposed to throw a
`BuildE
Github user twogee closed the pull request at:
https://github.com/apache/ant/pull/63
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/67
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/67
Support for fork mode in junitlauncher
The commit here introduces support for launching the JUnit tests, through
`junitlauncher` task, in forked mode.
I decided to keep the fork aspects as a
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/66
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
GitHub user jimmycasey opened a pull request:
https://github.com/apache/ant/pull/66
Fixed Spelling.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jimmycasey/ant master
Alternatively you can review and apply these changes as th
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/65
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
GitHub user jnsnkrllive opened a pull request:
https://github.com/apache/ant/pull/65
Update manual for subject alternative name attribute of genkey task
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jnsnkrllive/ant 1.9.x
Alter
On Sun, 7/15/18, asfgit wrote:
Subject: [GitHub] ant pull request #64: Add support for SAN extension in
GenerateKey task
To: dev@ant.apache.org
Date: Sunday, July 15, 2018, 10:24 PM
Github user asfgit closed the pull request
at:
https://github.com/apache/ant/pull/64
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/64
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user jnsnkrllive commented on a diff in the pull request:
https://github.com/apache/ant/pull/64#discussion_r202364682
--- Diff: src/main/org/apache/tools/ant/taskdefs/GenerateKey.java ---
@@ -413,6 +429,16 @@ public void execute() throws BuildException {
sb.a
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/64#discussion_r202287386
--- Diff: src/main/org/apache/tools/ant/taskdefs/GenerateKey.java ---
@@ -413,6 +429,16 @@ public void execute() throws BuildException {
sb.appe
Github user jnsnkrllive commented on a diff in the pull request:
https://github.com/apache/ant/pull/64#discussion_r202096699
--- Diff: src/main/org/apache/tools/ant/taskdefs/GenerateKey.java ---
@@ -413,6 +429,16 @@ public void execute() throws BuildException {
sb.a
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/64#discussion_r202054728
--- Diff: src/main/org/apache/tools/ant/taskdefs/GenerateKey.java ---
@@ -413,6 +429,16 @@ public void execute() throws BuildException {
sb.appe
GitHub user jnsnkrllive opened a pull request:
https://github.com/apache/ant/pull/64
Add support for SAN extension in GenerateKey task
Beginning with Java 7, keytool supports the SubjectAlternativeName
extension on X.509 certificates.
[Java 7 Keytool
Documentation](https://docs
Github user twogee commented on a diff in the pull request:
https://github.com/apache/ant/pull/63#discussion_r201826479
--- Diff: build.xml ---
@@ -277,13 +277,20 @@
+
+
+
+
+
+
+
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/63#discussion_r201577768
--- Diff: build.xml ---
@@ -277,13 +277,20 @@
+
+
+
+
+
+
+
GitHub user twogee opened a pull request:
https://github.com/apache/ant/pull/63
Replace JAI with ImageIO
Undeprecate Image task in Java 9+. No documentation yet; only the code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twoge
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/b7461ce2e43bda44a1ba5355f78288c85da773bc#commitcomment-29586480
In manual/install.html:
In manual/install.html on line 931:
I'll change it tomorrow.
---
--
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/b7461ce2e43bda44a1ba5355f78288c85da773bc#commitcomment-29585155
In manual/install.html:
In manual/install.html on line 931:
Sorry about nitpicking: I would prefer a space between Java and the
Github user janmaterne commented on the pull request:
https://github.com/apache/ant/commit/ca98cc50364f694e1642f84a0c43d0134098ed30#commitcomment-29497107
In manual/credits.html:
In manual/credits.html on line 49:
acute for Antoine and grave for me. ;)
Never learnd french n
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/ca98cc50364f694e1642f84a0c43d0134098ed30#commitcomment-29484893
In manual/credits.html:
In manual/credits.html on line 49:
I never learned french, no idea. I just copied the lines from the 1
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/ca98cc50364f694e1642f84a0c43d0134098ed30#commitcomment-29484065
In manual/credits.html:
In manual/credits.html on line 49:
Shouldn't that be grave?
---
No problem. That change to WHATSNEW is fine, I don't mind.
-Jaikiran
On 13/05/18 1:03 PM, Gintautas Grigelionis wrote:
Thanks, great work! I hope you don't mind me taking the liberty to adjust
WHATSNEW.
Gintas
2018-05-13 6:01 GMT+02:00 Jaikiran Pai :
I did plan to addit yesterday, but my l
Thanks, great work! I hope you don't mind me taking the liberty to adjust
WHATSNEW.
Gintas
2018-05-13 6:01 GMT+02:00 Jaikiran Pai :
> I did plan to addit yesterday, but my local tests did not trigger the
> package-info constant pool entry for some reason. So I decided to not rush
> it in and spe
I did plan to addit yesterday, but my local tests did not trigger the
package-info constant pool entry for some reason. So I decided to not
rush it in and spend some time to get the test right, to make sure it
works fine. I'll add it in either tonight or tomorrow once I get to see
what's going
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb#commitcomment-28953469
In
src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java:
In
src/main/org/apache/tools/ant/t
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28765601
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java:
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java o
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28765518
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java:
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java on
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28691928
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java:
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java o
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28691921
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java:
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java o
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28691811
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java:
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java on
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28688854
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java:
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java o
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28688738
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java:
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java on
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28688418
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java:
In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java o
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/81c3e6e3ddf5b1ef4e66018f1047e1b2ae8b3173#commitcomment-28590841
In
src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java:
In
src/tests/junit/org/apache/tools/ant/taskdefs/
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/81c3e6e3ddf5b1ef4e66018f1047e1b2ae8b3173#commitcomment-28590563
In
src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java:
In
src/tests/junit/org/apache/tools/ant/taskdefs
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/81c3e6e3ddf5b1ef4e66018f1047e1b2ae8b3173#commitcomment-28589786
In
src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java:
In
src/tests/junit/org/apache/tools/ant/taskdefs/
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/81c3e6e3ddf5b1ef4e66018f1047e1b2ae8b3173#commitcomment-28586872
In
src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java:
In
src/tests/junit/org/apache/tools/ant/taskdefs
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/cc41d3c1611c3a091e489fc026b33afd02f7eaed#commitcomment-28526626
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java:
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java o
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/cc41d3c1611c3a091e489fc026b33afd02f7eaed#commitcomment-28525323
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java:
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java on
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/cc41d3c1611c3a091e489fc026b33afd02f7eaed#commitcomment-28525288
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java:
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java on
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/cc41d3c1611c3a091e489fc026b33afd02f7eaed#commitcomment-28522026
In
src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java:
In
src/main/org/apache/tools/ant/taskdefs/optiona
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/cc41d3c1611c3a091e489fc026b33afd02f7eaed#commitcomment-28521960
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java:
In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java o
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28515176
In src/main/org/apache/tools/ant/util/LazyHashtable.java:
In src/main/org/apache/tools/ant/util/LazyHashtable.java on line 32:
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/4b14d85f11b9a7728dcd2d9420551fd28bf8f45e#commitcomment-28515126
In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java:
In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java on line 9
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28509355
In src/main/org/apache/tools/ant/util/LazyHashtable.java:
In src/main/org/apache/tools/ant/util/LazyHashtable.java on line 32:
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/4b14d85f11b9a7728dcd2d9420551fd28bf8f45e#commitcomment-28507789
In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java:
In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java on line 99
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/4b14d85f11b9a7728dcd2d9420551fd28bf8f45e#commitcomment-28500962
In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java:
In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java on line 9
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487664
In src/main/org/apache/tools/ant/util/LazyHashtable.java:
In src/main/org/apache/tools/ant/util/LazyHashtable.java on line 32:
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487485
In
src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java:
In
src/main/org/apache/tools/ant/taskdefs/compi
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487413
In src/main/org/apache/tools/ant/taskdefs/Concat.java:
In src/main/org/apache/tools/ant/taskdefs/Concat.java on line 597:
Even
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487270
In src/main/org/apache/tools/ant/XmlLogger.java:
In src/main/org/apache/tools/ant/XmlLogger.java on line 210:
the debugging co
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28487214
In src/main/org/apache/tools/ant/Project.java:
In src/main/org/apache/tools/ant/Project.java on line 1831:
this changes the ou
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/1c80d507f496dde98869890e671edf635bef8dec#commitcomment-28428982
:+1:
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/26c8789a5067809255040d3338235b5ae25a3898#commitcomment-28428974
don't worry. I'm happy Jenkins caught it.
---
-
To unsubscribe,
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/1c80d507f496dde98869890e671edf635bef8dec#commitcomment-28428804
You're right, there is no concise way to do backwards foreach loops in
Java. I will revert them later today.
---
--
1 - 100 of 354 matches
Mail list logo