Re: ant-ivy git commit: Update the release notes

2018-09-10 Thread Jaikiran Pai
Hi Maarten, Agreed - the change(s) should be done taking into account any existing caches (from previous version of Ivy). As of now, I have reverted my changes which had introduced the test failures. To fix properly, it will require a couple of hours of dedicated work to make sure all cases are co

Re: ant-ivy git commit: Update the release notes

2018-08-29 Thread Maarten Coene
Without knowing the details of the change, one thing we should take care about is that older Ivy versions should still be able to read that property properly. Maarten Op woensdag 29 augustus 2018 16:48:01 CEST schreef Gintautas Grigelionis : I like the idea, though. One thing that should

Re: ant-ivy git commit: Update the release notes

2018-08-29 Thread Gintautas Grigelionis
I like the idea, though. One thing that should be investigated further is places where location is obtained by getResource().getName() AFAICS that happens in CacheResolver (deprecated), BasicResolver (where also a Resource is constructed from location), and DefaultRepositoryCacheManager. There's no

Re: ant-ivy git commit: Update the release notes

2018-08-28 Thread Jaikiran Pai
More of a FYI - I'm still not convinced that my fix for this handles all the necessary cases (looks like the ArtifactOrigin#location gets used in various different ways), so I may either revert back my changes or decide to change it in a different way. So right now, in its current form, my changes