[GitHub] [ant] jaikiran commented on pull request #175: junitlauncher - Fix an issue in LegacyXmlResultFormatter with ]]> in stacktraces
jaikiran commented on pull request #175: URL: https://github.com/apache/ant/pull/175#issuecomment-1034445095 Hello Taylor, I just merged the initial commit that is part of this PR. I left out the tests for now since it even had changed some junit versions. I'll look into the testing part separately once I get some free time. As for testing this locally, what Aleksei pointed to should have worked (that's how we test locally), but I haven't been able to look more into your failures. Thank you for the patience on this one. As part of the merge, I've added your name to the list of contributors to this project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #175: junitlauncher - Fix an issue in LegacyXmlResultFormatter with ]]> in stacktraces
jaikiran commented on pull request #175: URL: https://github.com/apache/ant/pull/175#issuecomment-1021851685 This PR looks fine to me. Thank you for fixing this. Given that we have had odd issues in this area with XML content, do you think it's possible to add a test case to reproduce this issue and verify the fix? If so, would you be willing to add one in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
