[GitHub] [ant] janmaterne commented on issue #83: Add HTML validation check
janmaterne commented on issue #83: Add HTML validation check URL: https://github.com/apache/ant/pull/83#issuecomment-471177878 Added the redirection to file and did a few renamings. Merged into master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] janmaterne commented on issue #83: Add HTML validation check
janmaterne commented on issue #83: Add HTML validation check URL: https://github.com/apache/ant/pull/83#issuecomment-470939094 out|err-props could also work. Catch into prop, write prop to file and print. Give it a try. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] janmaterne commented on issue #83: Add HTML validation check
janmaterne commented on issue #83: Add HTML validation check URL: https://github.com/apache/ant/pull/83#issuecomment-470836739 This PR can't be responsible for the failing tests as the sources or test files are not touched. Failing tests are: src.tests.antunit.types.resources.test_xml.testhttpurl2 src.tests.antunit.taskdefs.get-test_xml.testTemporaryRedirect src.tests.antunit.taskdefs.get-test_xml.testNestedResources src.tests.antunit.taskdefs.get-test_xml.testInfiniteRedirect src.tests.antunit.taskdefs.gunzip-test_xml.testWithNonFileResourceToDir src.tests.antunit.taskdefs.gunzip-test_xml.testWithNonFileResourceToFile This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] janmaterne commented on issue #83: Add HTML validation check
janmaterne commented on issue #83: Add HTML validation check URL: https://github.com/apache/ant/pull/83#issuecomment-470832663 Tool "Copyright (c) 2013-2018 Mozilla Foundation" (https://github.com/validator/validator/blob/master/src/nu/validator/client/SimpleCommandLineValidator.java), so license seems to be ok. Runs fine. Errors are printed to the console. It seems that the tool does not support writing a report to file. Could you try to create a report file with Ant ()? So this target would behave like the other report-targets. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] janmaterne commented on issue #83: Add HTML validation check
janmaterne commented on issue #83: Add HTML validation check URL: https://github.com/apache/ant/pull/83#issuecomment-470825471 Just summarize/quote the link contents: - **doctype**: that declaration was used in HTML5 to distinguish between a standards-compliant parsing mode and a so-called quirks parsing mode. - ****: Due to long-standing confusions and inconsistent implementations of this element, the HTML5 specification made this non-conforming in HTML, so you should no longer use it. - ****: tell screenreaders exactly what cells the header is a header for This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] janmaterne commented on issue #83: Add HTML validation check
janmaterne commented on issue #83: Add HTML validation check URL: https://github.com/apache/ant/pull/83#issuecomment-470824474 Thanks for the links, sounds reasonable. Two things I found: 1. maybe you should add a short paragraph in thesection like for the other tools 2. why you named the target "vnu"? Something like "html-check" sounds more descriptive. Compare to "dependency-check" instead of "owasp" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] janmaterne commented on issue #83: Add HTML validation check
janmaterne commented on issue #83: Add HTML validation check URL: https://github.com/apache/ant/pull/83#issuecomment-470423575 I like the idea of checking the html files. But why are these changes required? Only because a tool sais that is not enough for me. Do you have pointers to some specs? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] janmaterne commented on issue #83: Add HTML validation check
janmaterne commented on issue #83: Add HTML validation check URL: https://github.com/apache/ant/pull/83#issuecomment-470422494 Summerize the changes: - Add new tool "Nu HTML Validator" for checking manual and site check.xml: new target 'vnu' - add attribute: --> - remove - manual/tutorial-tasks-filesets-properties.html added >>scope="col"<< to table-header - src/main/org/apache/tools/ant/property/package.html -- added html/head/title -- fixed typo s/ant/Ant/ - src/main/org/apache/tools/ant/taskdefs/optional/sos/package.html -- added title -- added DOCTYPE-html - src/main/org/apache/tools/ant/types/resolver/package.html dito This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
