[GitHub] [ant] tsmock commented on pull request #175: junitlauncher - Fix an issue in LegacyXmlResultFormatter with ]]> in stacktraces
tsmock commented on pull request #175: URL: https://github.com/apache/ant/pull/175#issuecomment-1034936800 I ended up updating the JUnit5 versions to get some of their newer testing methods for testing JUnit extensions. In any case, from what _I_ know, there shouldn't be any effect on `ant` users by increasing the JUnit5 version, as the `junitlauncher` task requires the user to provide `JUnit5` libraries on the path. JUnit4 4.13.1 -> 4.13.2 should have no effect, minus the [bug fixes](https://github.com/junit-team/junit4/blob/HEAD/doc/ReleaseNotes4.13.2.md) JUnit5 5.2.0 -> 5.8.2 is a bit bigger: * Added Java 12, 13, 14, 15, 16, 17, 18 in their JRE enum * `@Suite` support * `EngineTestKit` had some deprecated APIs removed in 5.7.0 (APIs were deprecated in 5.6.0) * Script-based APIs have been deprecated (5.5.0) and removed (5.6.0) * Many, many bug fixes Also, thank you for letting me know that you didn't take everything from the branch -- I usually delete my branches once they get merged, but I won't delete this one for awhile. I will go ahead and rebase onto HEAD though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] tsmock commented on pull request #175: junitlauncher - Fix an issue in LegacyXmlResultFormatter with ]]> in stacktraces
tsmock commented on pull request #175: URL: https://github.com/apache/ant/pull/175#issuecomment-1033872016 Do I need to do anything else for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] tsmock commented on pull request #175: junitlauncher - Fix an issue in LegacyXmlResultFormatter with ]]> in stacktraces
tsmock commented on pull request #175: URL: https://github.com/apache/ant/pull/175#issuecomment-1023232685 > @tsmock I experienced the same problem and @jaikiran suggested to fetch necessary dependencies by running `ant -f fetch.xml -Ddest=optional` [1]. It actually helped me. > > [1] https://lists.apache.org/thread/2v8l95fwh0sgz0vlgqcf1rpd88swf3pv It did not help me. See https://github.com/apache/ant/blob/master/build.xml#L1989 . Specifically, when I commented that line out, the tests failed due to having JUnit 3.8.2 on the class path (see https://github.com/apache/ant/tree/master/lib/optional ). I'm actually surprised that JUnit 3 is still supported in ant -- it looks like the last release for it was in 2006 or 2007. Junit 4.0 was released around that time.) I was, however, able to run the tests with [maven](https://github.com/apache/ant/blob/master/src/etc/poms/ant-junitlauncher/pom.xml) (I checked to make certain that all the tests will fail if the expected output was not there, as I changed a significant part of the logic in the test). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] tsmock commented on pull request #175: junitlauncher - Fix an issue in LegacyXmlResultFormatter with ]]> in stacktraces
tsmock commented on pull request #175: URL: https://github.com/apache/ant/pull/175#issuecomment-106543 > This PR looks fine to me. Thank you for fixing this. Given that we have had odd issues in this area with XML content, do you think it's possible to add a test case to reproduce this issue and verify the fix? If so, would you be willing to add one in this PR? I was looking into this yesterday. I'll say this much, figuring out how the tests were run and verified took me a bit of time, and the output from `./build.sh clean test` does _not_ have any mention of junitlauncher on my system. As in, it appears that those tests do not run with the suggested test command in CONTRIBUTING.md. I don't know if it is just my system or not (Mac OS X 12.1), so I was going to try it on a Raspberry Pi sometime today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
