Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/31
I do ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nlalevee commented on the issue:
https://github.com/apache/ant-ivy/pull/31
@twogee to properly add you to the list of contributors, do you confirm you
are
Gintautas Grigelionis ?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/31
merged, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/31
Nice idea to use the old fail-Message as new method comment to document why
the exception is expected.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/31
I left a few `fail()`s where multiple assertions were made; I guess that
requires a custom @Rule.
Also, in `FileSystemResolverTest`, I moved `finally` blocks to
`tearDown()`. Strangely, that
Github user twogee commented on the issue:
https://github.com/apache/ant-ivy/pull/31
Thanks for a nice summary and pointing out a paradigm that I did not
investigate entirely. The essential work also included checking that all
appropriate setUp() and tearDown() were public and/or
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/31
That was a lot of work (or writing/using a transformator ;)
Basically it
- removes the "extends TestCase" and
- uses JUnit annotations
- change string.indexOf()!=-1 to
