[GitHub] ant-ivy issue #52: Generics in core

2017-07-17 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/52 It looks like this PR has been updated with additional unrelated changes. Except for these 2 commits in this PR: https://github.com/apache/ant-ivy/pull/52/commits/52b99a74d5770485d95d087aac8a97f

[GitHub] ant-ivy issue #52: Generics in core

2017-07-14 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/52 I committed proposed changes w/o contains(). Please let me know if should amend. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] ant-ivy issue #52: Generics in core

2017-07-14 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/52 Thanks! I will revert the changes regarding the checked exceptions as suggested in a separate commit. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] ant-ivy issue #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/52 I've reviewed this PR and apart from the review comments noted, the rest of the changes look fine. Please only include any review comments related changes to this PR, from now on. Else it's going to