[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/73 Sorry, my reasoning took the wrong turn, must be the heat 😦Yes, passing qualified attributes to XmlReportWriter is the way to go. I wonder what was the reason for using "extra-" hack? I

[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread aprelev
Github user aprelev commented on the issue: https://github.com/apache/ant-ivy/pull/73 By the way, found [issue IVY-1104](https://issues.apache.org/jira/browse/IVY-1104) in your issue tracker, seems to be the case. ---

[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread aprelev
Github user aprelev commented on the issue: https://github.com/apache/ant-ivy/pull/73 As of now, two sets of dependencies are constructed in a different ways: - *currently resolved dependecies* are produced by Ivy resolve engine, with **both qualified and unqualified

[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/73 Gradle seemed to have [different ideas](https://github.com/gradle/gradle/issues/954) about Ivy XML namespaces (not to be confused with Ivy

[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread aprelev
Github user aprelev commented on the issue: https://github.com/apache/ant-ivy/pull/73 @twogee Can you point me in the right direction regarding namespace URL? And what are your thoughts on including the namespace prefix in the report? ---

[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/73 @aprelev the latter, you can push a new commit. What I meant is that hardcoding "e:" is probably a bad idea, one may choose a different namespace prefix; rather, we should be enforcing use of

[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/73 >> Should I reopen PR? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail:

[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread aprelev
Github user aprelev commented on the issue: https://github.com/apache/ant-ivy/pull/73 Should I reopen PR? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail:

[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/73 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail:

[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread aprelev
Github user aprelev commented on the issue: https://github.com/apache/ant-ivy/pull/73 > Rather than hardcoding prefix, shouldn't we retrieve it by URL "http://ant.apache.org/ivy/extra;? Can you elaborate on prefix retrieving? The **extra-** prefix is [hardcoded

[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread aprelev
Github user aprelev commented on the issue: https://github.com/apache/ant-ivy/pull/73 > Tests have passed https://builds.apache.org/job/Ivy-GithubPR/361/ Not really, my changes were not applied in this build. Test *testDepsWithAttributesChanged* should have run under

[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/73 @aprelev Rather than hardcoding prefix, shouldn't we retrieve it by URL "http://ant.apache.org/ivy/extra;? --- - To unsubscribe,

[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/73 Tests have passed https://builds.apache.org/job/Ivy-GithubPR/361/ --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org

[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/73 >> By the way, latest commits 43ddccb and 5918182 introduced nested "javaversion" element, which breaks Jenkins CI build; I had to remove this for both I just fixed the PR build to use the

[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/73 retest this please --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail:

[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...

2018-08-01 Thread aprelev
Github user aprelev commented on the issue: https://github.com/apache/ant-ivy/pull/73 By the way, latest commits 43ddccb859b94c79350ece7520af4c991c2bb5e6 and 5918182e0d6836d89c42260da9de4428d4cbcec0 introduced [nested "javaversion"