[GitHub] ant-ivy pull request #61: Use japicmp to check binary compatibility
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/61 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #63: IVY-1486 respect exclude regardless of order
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/63 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #74: Fix IVY-982 by removing negated entries from wildc...
Github user aprelev closed the pull request at: https://github.com/apache/ant-ivy/pull/74 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #74: Fix IVY-982 by subtracting negated entries from wi...
GitHub user aprelev opened a pull request: https://github.com/apache/ant-ivy/pull/74 Fix IVY-982 by subtracting negated entries from wildcard bin ### Issue Configurations negation (exclusion) as in `conf="*, !foo->@"` does not work, This issue is reported in [IVY-982](https://issues.apache.org/jira/browse/IVY-982) and [IVY-1547](https://issues.apache.org/jira/browse/IVY-1547). ### Why does it happen? Resolve engine silently disrespects negation on the left part of maps-to operator because the exclusion was not implemented. When parsing dependency, e.g. `conf="*, !foo â bar1; foo â bar2, bar3; % â bar4"`, all dependency configurations are collected into bins (map entries): - *all-wildcard bin* with all configurations required for `*` superset, such as `bar1` in bin `*`; - *others-wildcard bin* with all configurations required for `%` superset, such as `bar4` in bin `%`; - *explicit bins* for all explicit mappings, such as `bar2` and `bar3` in bin `foo`, and `bar1` in bin `!foo`. Resolving list of dependency configurations required for some target configuration `X` is done as follows: 1. All configurations from `X`'s *explicit bin* [are added](https://github.com/apache/ant-ivy/blob/89583444040dc5423bb143435f23ae0814f24542/src/java/org/apache/ivy/core/module/descriptor/DefaultDependencyDescriptor.java#L347). 2. All configurations from *others-wildcard bin* [are added](https://github.com/apache/ant-ivy/blob/89583444040dc5423bb143435f23ae0814f24542/src/java/org/apache/ivy/core/module/descriptor/DefaultDependencyDescriptor.java#L350) in case `X`'s *explicit bin* is empty. 3. All configurations from *all-wildcard bin* [are added](https://github.com/apache/ant-ivy/blob/89583444040dc5423bb143435f23ae0814f24542/src/java/org/apache/ivy/core/module/descriptor/DefaultDependencyDescriptor.java#L358). Note that explicit bins for negated target configurations *are not referenced, and thus silently ignored*. This fix introduces fourth step: 4. All configurations from `!X`'s *explicit bin* are removed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/aprelev/ant-ivy issue-ivy-1547-982 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/74.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #74 commit 0c2c826e4c316fdcf42fd890097edef478b692a3 Author: Aprelev Arseny Date: 2018-08-06T14:21:21Z Fix IVY-982 by subtracting negated entries from wildcard bin --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #73: IVY-1104 Include attributes qualifiers in the XML ...
Github user aprelev closed the pull request at: https://github.com/apache/ant-ivy/pull/73 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #73: IVY-1104 Include attributes qualifiers in the XML ...
Github user aprelev commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/73#discussion_r207675516 --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java --- @@ -193,16 +193,8 @@ public void startElement(String uri, String localName, String qName, String branch = attributes.getValue("branch"); String revision = attributes.getValue("revision"); Map extraAttributes = new HashMap<>(); --- End diff -- It was, until I reused code for attributes extraction from `ExtendableItemHelper`. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #73: IVY-1104 Include attributes qualifiers in the XML ...
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/73#discussion_r207669472 --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java --- @@ -193,16 +193,8 @@ public void startElement(String uri, String localName, String qName, String branch = attributes.getValue("branch"); String revision = attributes.getValue("revision"); Map extraAttributes = new HashMap<>(); --- End diff -- Is this Map used? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #73: Enable XML report parser to produce qualified extr...
GitHub user aprelev opened a pull request: https://github.com/apache/ant-ivy/pull/73 Enable XML report parser to produce qualified extra attributes ### Issue `${ivy.deps.changed}` is always `true` for dependencies with extra attributes. ### Problem `XmlReportParser::startElement()` creates revision IDs [as follows](https://github.com/apache/ant-ivy/blob/5918182e0d6836d89c42260da9de4428d4cbcec0/src/java/org/apache/ivy/plugins/report/XmlReportParser.java#L96): ```Java mrid = ModuleRevisionId.newInstance(organisation, module, branch, revision, ExtendableItemHelper.getExtraAttributes(attributes, "extra-")); ``` Here, `ExtendableItemHelper::getExtraAttributes()` method returns *unqualified* attributes of previously resolved dependencies, which are then compared with *qualified* attributes of currently resolved dependencies in `ConfigurationResolveReport::checkIfChanged()` [as follows](https://github.com/apache/ant-ivy/blob/5918182e0d6836d89c42260da9de4428d4cbcec0/src/java/org/apache/ivy/core/report/ConfigurationResolveReport.java#L101): ```Java Set previousDepSet = new HashSet<>( Arrays.asList(parser.getDependencyRevisionIds())); hasChanged = !previousDepSet.equals(getModuleRevisionIds()); ``` which effectively renders sets of dependecies *unequal*. ### Solutions One solution would be to compare unqualified attributes when [testing revision IDs for equality](https://github.com/apache/ant-ivy/blob/5918182e0d6836d89c42260da9de4428d4cbcec0/src/java/org/apache/ivy/core/module/id/ModuleRevisionId.java#L237); another one would be to [produce qualified attributes](https://github.com/aprelev/ant-ivy/blob/1d508c14bbc68411b9b215f2e4e552fe20d3ae1a/src/java/org/apache/ivy/util/extendable/ExtendableItemHelper.java#L37) when parsing XML report. I've implemented second solution (it seemed cleaner to me), and included unit-test to demonstrate the issue. You can merge this pull request into a Git repository by running: $ git pull https://github.com/aprelev/ant-ivy master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/73.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #73 commit 1d508c14bbc68411b9b215f2e4e552fe20d3ae1a Author: aprelev Date: 2018-07-31T14:15:26Z Enable XML report parser to produce qualified extra attributes --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #72: Test
GitHub user smolamarcin opened a pull request: https://github.com/apache/ant-ivy/pull/72 Test You can merge this pull request into a Git repository by running: $ git pull https://github.com/smolamarcin/ant-ivy test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/72.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #72 commit 568f1c22270e9c7fa735b3f26da8685c5281db77 Author: Marcin SmoÅa Date: 2018-05-30T11:23:27Z Update README.adoc commit 5bbdf79a1cc0e3d19d60ce68a7011afc169f843e Author: Marcin Date: 2018-05-30T11:25:33Z xd commit 8a02cf58d9c64589e9a81c07b753a401dd167598 Author: Marcin Date: 2018-05-30T11:35:54Z xd commit 5e6f9f044b1eca83f45e0addf268d5e7797de130 Author: Marcin Date: 2018-05-30T11:56:05Z xd commit 10fb3f97f3f3c2117c2c52444e85b967e4a2b110 Author: Marcin Date: 2018-05-30T11:57:31Z xd commit cf5596d38462d72c8b34dc03448b68c05e546800 Author: Marcin Date: 2018-05-30T13:25:02Z test --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #71: Ivy main/standalone: Patch to include 'makepom' fu...
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/71#discussion_r177857645 --- Diff: src/java/org/apache/ivy/Main.java --- @@ -199,6 +201,10 @@ static CommandLineParser getParser() { new OptionBuilder("cp").arg("cp") .description("extra classpath to use when launching process").create()) +.addCategory("maven compatibility options") +.addOption(new OptionBuilder("pomfile").arg("pomfile").countArgs(false) +.description("makepom as standalone tasks").create()) --- End diff -- On the second thoughts, why not calling the option `makepom` ð ? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #71: Ivy main/standalone: Patch to include 'makepom' fu...
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/71#discussion_r177696348 --- Diff: src/java/org/apache/ivy/Main.java --- @@ -199,6 +201,10 @@ static CommandLineParser getParser() { new OptionBuilder("cp").arg("cp") .description("extra classpath to use when launching process").create()) +.addCategory("maven compatibility options") +.addOption(new OptionBuilder("pomfile").arg("pomfile").countArgs(false) +.description("makepom as standalone tasks").create()) --- End diff -- IMHO `pomfile` is confusing (cf use of `ivyfile` and `propertiesfile`). I'd suggest `writepom`or something like that. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #71: Ivy main/standalone: Patch to include 'makepom' fu...
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/71#discussion_r177694759 --- Diff: src/java/org/apache/ivy/Main.java --- @@ -199,6 +201,10 @@ static CommandLineParser getParser() { new OptionBuilder("cp").arg("cp") .description("extra classpath to use when launching process").create()) +.addCategory("maven compatibility options") +.addOption(new OptionBuilder("pomfile").arg("pomfile").countArgs(false) --- End diff -- A small suggestion - can you change this to something like: ``` new OptionBuilder("makepom").arg("pomfile") ``` --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #71: Ivy main/standalone: Patch to include 'makepom' fu...
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/71#discussion_r177694862 --- Diff: src/java/org/apache/ivy/Main.java --- @@ -199,6 +201,10 @@ static CommandLineParser getParser() { new OptionBuilder("cp").arg("cp") .description("extra classpath to use when launching process").create()) +.addCategory("maven compatibility options") +.addOption(new OptionBuilder("pomfile").arg("pomfile").countArgs(false) +.description("makepom as standalone tasks").create()) --- End diff -- I think the description should be a bit more clear and state that this generates a pom file for the resolved module. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #71: Ivy main/standalone: Patch to include 'makepom' fu...
GitHub user aanno opened a pull request: https://github.com/apache/ant-ivy/pull/71 Ivy main/standalone: Patch to include 'makepom' function Hello, I added the pomfile option to main/standalone. This allows creating an (maven) pom file from outside an ant task. Example of use: ```sh $ pwd ~/.ivy2/cache/org.typelevel/cats-core_2.11 $ java -jar ~/scm/github/ant-ivy/build/artifact/org.apache.ivy_2.5.0.alpha_20180327212209.jar -ivy ivy-1.0.1.xml -pomfile cats-core.xml $ ls cats-core-2.11.xml ivy-1.0.1.xml ivy-1.0.1.xml.original ivydata-1.0.1.properties jars srcs ``` Feedback is welcome. What should I do to get this patch into mainline? Kind regards, aanno You can merge this pull request into a Git repository by running: $ git pull https://github.com/aanno/ant-ivy feature/aanno-main-pomfile Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/71.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #71 commit 5e814ad7a84ffb2a9d4df72fc801e9b8d6aa2f64 Author: Thomas PaschDate: 2018-03-27T19:17:01Z Added pomfile option to main/standalone --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #70: IVY-1321 Make Main.run() public
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/70 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #70: Make Main.run() usable programmatically
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/70 Make Main.run() usable programmatically Inspired by #69 You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy ivy-1321 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/70.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #70 commit ab638a8f5bb74d83299d006fcc0f041c21338610 Author: twogeeDate: 2018-03-20T00:00:13Z Make Main.run() usable programmatically --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #69: 2.4.x
GitHub user supertick opened a pull request: https://github.com/apache/ant-ivy/pull/69 2.4.x You can merge this pull request into a Git repository by running: $ git pull https://github.com/supertick/ant-ivy 2.4.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/69.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #69 commit f9e51f56a5d4115d00af10bc1404217805f89455 Author: grperryDate: 2018-03-18T22:07:09Z re-use standalone ivy interface for programmatic one commit 8f473734f05eb99568db4c5675f7b892337852b0 Author: grperry Date: 2018-03-18T22:26:50Z backed out windows crlf --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/67 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
AW: [GitHub] ant-ivy pull request #:
If the /doc directory is not maintained any more and all sources are now in /asciidoc, it should be deleted. If the /asciidoc/dev/makerelease.adoc is uptodate, feel free to change the /ReleaseInstrutions to point there. Jan > -Ursprüngliche Nachricht- > Von: twogee [mailto:g...@git.apache.org] > Gesendet: Dienstag, 6. März 2018 18:24 > An: dev@ant.apache.org > Betreff: [GitHub] ant-ivy pull request #: > > Github user twogee commented on the pull request: > > https://github.com/apache/ant- > ivy/commit/8ed4a9bea706320d97ce2fd3e6545d7ebdf8a49b#commitcomment- > 27956300 > > I believe we're using asciidoc now? > > > --- > > - > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional > commands, e-mail: dev-h...@ant.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/8ed4a9bea706320d97ce2fd3e6545d7ebdf8a49b#commitcomment-27956300 I believe we're using asciidoc now? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r171054211 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- Ah, I get it... the way things work, ant-junit4 must declare a dependency on ant-junit --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r171053071 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- Good catch, thanks. BTW, run this way Ant core seems unable to simply find org.apache.tools.ant.taskdefs.optional.junit.JUnitTask on a classpath; why is that? does it need some hint from the launcher? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/1a19f2f836cd33a25d458ed8ba9bbb3c7ce4ff96#commitcomment-27816643 Could we do release and sign in one go by adding distributions to ivy.xml and using a separate filesystem resolver to copy and sign the distributions? Not to mention that there will be one less dependency (drop Commons OpenPGP)? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r168989393 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- strange, thanks. As Ivy uses junit4 you will also need ant-junit4 in this case. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r168964592 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- Yes. Invocation of Ant runs Ivy's build.xml; it's a fancy way of bootstrapping an Ivy build, by the looks of it. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r168964407 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- to run which unit tests? Ivy's? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r168963965 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- If Ant (launcher and core) is fetched as a dependency, then ant-junit must be retrieved as a dependency, too, in order to run unit tests. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;
Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r168961676 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- why has this dependency been added? I don't see it used. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #62: IVY-1572 - Check for Thread interruption while res...
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/62#discussion_r167136873 --- Diff: src/java/org/apache/ivy/plugins/resolver/AbstractPatternsBasedResolver.java --- @@ -91,6 +91,9 @@ protected ResolvedResource findResourceUsingPatterns(ModuleRevisionId moduleRevi Set foundRevisions = new HashSet<>(); boolean dynamic = getSettings().getVersionMatcher().isDynamic(moduleRevision); for (String pattern : patternList) { +if (Thread.currentThread().isInterrupted()) { +return null; --- End diff -- @apupier I originally intended it to be `InterruptedException` but given that it's a checked exception you would end up changing the method signature of this method which then causes issues with callers of this API. Hence I suggested a runtime exception. Returning null could have other (side) effects than what you intend here - i.e. to abort the execution, so throwing the exception would be the right thing. I might have some time tonight, I'll see if this check can be moved to a better location or handle in a better way. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #68: Why no new Ivy version yet?
GitHub user chinhodado opened a pull request: https://github.com/apache/ant-ivy/pull/68 Why no new Ivy version yet? I'm just making this PR because the mailing list is a pain to use and there's no issue tracker here on GitHub for the project...but why isn't there a new release for Ivy yet, given the project has resumed development for so long now? You can merge this pull request into a Git repository by running: $ git pull https://github.com/chinhodado/ant-ivy patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/68.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #68 commit ea69b704b77d0321cfc19f85bab3c9627040b9f3 Author: Trung DoDate: 2018-02-09T04:02:16Z Why no new version yet --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #66: IVY-1545 Detect circular dependencies in POMs
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/66 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #62: IVY-1572 - Check for Thread interruption while res...
Github user apupier commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/62#discussion_r166349423 --- Diff: src/java/org/apache/ivy/plugins/resolver/AbstractPatternsBasedResolver.java --- @@ -91,6 +91,9 @@ protected ResolvedResource findResourceUsingPatterns(ModuleRevisionId moduleRevi Set foundRevisions = new HashSet<>(); boolean dynamic = getSettings().getVersionMatcher().isDynamic(moduleRevision); for (String pattern : patternList) { +if (Thread.currentThread().isInterrupted()) { +return null; --- End diff -- the specific exception in this case is in theory https://docs.oracle.com/javase/7/docs/api/java/lang/InterruptedException.html which is a checked Exception. Do you have another runtime exception in mind? Or you want to create a specific Runtime Exception? I'm wondering what would be the effect in this case to Thread in which it has been launched. Will it finished also? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #62: IVY-1572 - Check for Thread interruption while res...
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/62#discussion_r166282397 --- Diff: src/java/org/apache/ivy/plugins/resolver/AbstractPatternsBasedResolver.java --- @@ -91,6 +91,9 @@ protected ResolvedResource findResourceUsingPatterns(ModuleRevisionId moduleRevi Set foundRevisions = new HashSet<>(); boolean dynamic = getSettings().getVersionMatcher().isDynamic(moduleRevision); for (String pattern : patternList) { +if (Thread.currentThread().isInterrupted()) { +return null; --- End diff -- @apupier , I don't think this is the best place to check the thread interruption, but I don't have a better suggestion right now, so unless someone objects, this change is probably fine. However, instead of returning null, can you please throw a (runtime) exception instead. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #65: IVY-1485 Ensure dependency is applicable to all co...
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/65 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/67 IVY-1483 Invoke Ant through Ivy; like this: `java -jar ivy.jar -properties version.properties -main org.apache.tools.ant.Main` You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy ivy-1483 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/67.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #67 commit 46ee20b19721362a4b1b43f413d1d6d1967df5a4 Author: twogeeDate: 2018-02-02T22:37:11Z IVY-1483 Invoke Ant through Ivy; like this: java -jar ivy.jar -properties version.properties -main org.apache.tools.ant.Main --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/7ebc8107a22038c06c0b0ff095f9f73d854e1422#commitcomment-27303399 And then there's `TestHelper.getCurrentAuthenticator()`... --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #66: IVY-1545 Detect circular dependencies in POMs
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/66 IVY-1545 Detect circular dependencies in POMs You can merge this pull request into a Git repository by running: $ git pull https://github.com/javabrett/ant-ivy IVY-1545 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/66.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #66 commit dee9aa6d043d184a521f6ed970b71cbb3cab0b02 Author: Brett RandallDate: 2016-03-25T09:55:15Z Added logging to help diagnose a recursion StackOverflowError condition. commit 335be3eb2c9d2b10786dff790fb78206d1e31523 Author: Brett Randall Date: 2016-03-26T08:15:25Z Fixed two minor comment typos. commit 65b9650cbc7a4b8b9faa560a50eafa826fcd6fae Author: Brett Randall Date: 2016-03-26T02:12:20Z IVY-1545: Added tracking for a cycle in parent-POM ancestry, throw a CircularDependencyException if found. Added tests for cycles in parent ancestry and references-self as parent. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #65: IVY-1485 Ensure dependency is applicable to all co...
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/65 IVY-1485 Ensure dependency is applicable to all configurations I adopted a patch by @tbingaman You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy ivy-1485 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/65.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #65 commit fbac59fbbd6f7c7fa8aa99597f8804211d05bd26 Author: twogeeDate: 2018-02-01T13:54:30Z IVY-1485 Ensure dependency is applicable to all configurations --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #64: IVY-1280 Support preemptive authentication
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/64 IVY-1280 Support preemptive authentication I adopted a patch by @AurelienLourot You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy ivy-1280 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/64.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #64 commit 2422f51ffad184465a5a9bacdc92e44f7f4a756a Author: twogeeDate: 2018-02-01T10:40:10Z IVY-1280 Support preemptive authentication --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #63: IVY-1486 respect exclude regardless of order
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/63 IVY-1486 respect exclude regardless of order You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy ivy-1486 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/63.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #63 commit c2601118d9a41aac00a0c0eb89279095d9a83712 Author: twogeeDate: 2018-01-09T07:04:42Z IVY-1486 respect exclude regardless of order --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #62: IVY-1572 - Check for Thread interruption while res...
GitHub user apupier opened a pull request: https://github.com/apache/ant-ivy/pull/62 IVY-1572 - Check for Thread interruption while resolving resources Signed-off-by: Aurélien PupierYou can merge this pull request into a Git repository by running: $ git pull https://github.com/apupier/ant-ivy IVY-1572-CheckForInterruptionDuringLongRunningOperations Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit ed2666f48b7783d95b75f59314baf08994fb0948 Author: Aurélien Pupier Date: 2018-01-05T08:22:15Z IVY-1572 - Check for Thread interruption while resolving resources Signed-off-by: Aurélien Pupier --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #61: Use japicmp to check binary compatibility
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/61 Use japicmp to check binary compatibility japicmp 0.11 has got an Ant task. It can as well be used for documenting the public API. Grouped related targets, too (moved `sources` closer to `publish-local`). You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy japicmp Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/61.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #61 commit 046edd01568fc477dbc2c7ee28e2ee74debe0e00 Author: twogeeDate: 2017-06-29T08:40:16Z Use japicmp to check binary compatibility --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/ab8b608744500c6af9933df5977a2aa054ac3c04#commitcomment-24318098 Is this Maven 2 or [Maven 3/Aether](http://maven.apache.org/aether.html)? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #60: use Unicode glyphs or SVG data URLs instead of bit...
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/60#discussion_r136417644 --- Diff: build-release.xml --- @@ -179,11 +180,11 @@ - + --- End diff -- Very well, here's the output from 1.5.4: ``` .../ant-ivy/build-release.xml:202: org.jruby.exceptions.RaiseException: (LoadError) no such file to load -- asciidoctor at org.jruby.RubyKernel.require(org/jruby/RubyKernel.java:1040) at RUBY.require(/Users/gintas/.ivy2/cache/org.asciidoctor/asciidoctor-ant/jars/asciidoctor-ant-1.5.4.jar!/META-INF/jruby.home/lib/ruby/shared/rubygems/core_ext/kernel_require.rb:54) at
[GitHub] ant-ivy pull request #60: use Unicode glyphs or SVG data URLs instead of bit...
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/60#discussion_r136327295 --- Diff: build-release.xml --- @@ -179,11 +180,11 @@ - + --- End diff -- Instead of downgrading the version, I think we should try and figure out whatever the issue is with 1.5.4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #53: suppressed warnings
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #60: use Unicode glyphs or SVG data URLs instead of bit...
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/60 use Unicode glyphs or SVG data URLs instead of bitmaps I put this up for review in case I missed some page that used the removed icons. You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/60.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #60 commit 49e89fb3f5249e8dd45581a5b14a2ebd7f9ea2b8 Author: twogeeDate: 2017-08-30T18:20:16Z use Unicode glyphs or SVG data URLs instead of bitmaps --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #59: IVY-1566 - Store External form of URL in cached fi...
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/59 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #59: IVY-1566 - Store External form of URL in cached fi...
GitHub user apupier opened a pull request: https://github.com/apache/ant-ivy/pull/59 IVY-1566 - Store External form of URL in cached files So hard to configure the project in my IvyIDE, cannot launch test individually so I abandoned the to search how to write a test. I tested manually in my use case and I don't have anymore MalformedURlException the ivydata*.properties now contaisn always "file:" ``` artifact\:ivy\#ivy\#xml\#-455539479.location=file\:C\:/Users/Aurelien Pupier/.m2/repository/org/apache/camel/camel/2.17.2/camel-2.17.2.pom resolver=localm2 artifact\:ivy\#ivy\#xml\#-455539479.is-local=true artifact\:ivy\#ivy\#xml\#-455539479.original=artifact\:camel\#pom.original\#pom\#1474703200 artifact\:camel\#pom.original\#pom\#1474703200.exists=true artifact\:ivy\#ivy\#xml\#-455539479.exists=true artifact.resolver=localm2 artifact\:camel\#pom.original\#pom\#1474703200.is-local=true artifact\:camel\#pom.original\#pom\#1474703200.location=file\:C\:/Users/Aurelien Pupier/.m2/repository/org/apache/camel/camel/2.17.2/camel-2.17.2.pom artifact\:camel\#pom.original\#pom\#1474703200.original=artifact\:camel\#pom.original\#pom\#1474703200 ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/apupier/ant-ivy IVY-1566-AvoidStoringPathWhichAreNotUrl Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/59.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #59 commit b9211c8c3666f2df6bb8a1d54cb8dd03081397a2 Author: Aurélien PupierDate: 2017-08-10T13:57:42Z IVY-1566 - Store External form of URL in cached files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #58: IVY-1566 - Store External form of URL in cached fi...
Github user apupier closed the pull request at: https://github.com/apache/ant-ivy/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #58: IVY-1566 - Store External form of URL in cached fi...
GitHub user apupier opened a pull request: https://github.com/apache/ant-ivy/pull/58 IVY-1566 - Store External form of URL in cached files So hard to configure the project in my IvyIDE, cannot launch test individually so I abandoned the to search how to write a test. I tested manually in my use case and I don't have anymore MalformedURlException the ivydata*.properties now contaisn always "file:" ``` artifact\:ivy\#ivy\#xml\#-455539479.location=file\:C\:/Users/Aurelien Pupier/.m2/repository/org/apache/camel/camel/2.17.2/camel-2.17.2.pom resolver=localm2 artifact\:ivy\#ivy\#xml\#-455539479.is-local=true artifact\:ivy\#ivy\#xml\#-455539479.original=artifact\:camel\#pom.original\#pom\#1474703200 artifact\:camel\#pom.original\#pom\#1474703200.exists=true artifact\:ivy\#ivy\#xml\#-455539479.exists=true artifact.resolver=localm2 artifact\:camel\#pom.original\#pom\#1474703200.is-local=true artifact\:camel\#pom.original\#pom\#1474703200.location=file\:C\:/Users/Aurelien Pupier/.m2/repository/org/apache/camel/camel/2.17.2/camel-2.17.2.pom artifact\:camel\#pom.original\#pom\#1474703200.original=artifact\:camel\#pom.original\#pom\#1474703200 ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/apupier/ant-ivy IVY-1566-AvoidStoringPathWhichAreNotUrl Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/58.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #58 commit 360d085dcbddee597c515243aef77109f2887292 Author: Aurélien PupierDate: 2017-08-10T13:57:42Z IVY-1566 - Store External form of URL in cached files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/a9dd1573eb0edbfa977da90dd3bcb1863451ec2a#commitcomment-23529287 Perhaps [this](https://stackoverflow.com/questions/3587071/disable-intellij-starred-package-imports) could be of use ð And, there's a related setting that was a subject of some discussion, "Insert imports for inner classes". Should we tick it (that would correspond to a prevalent style of coding for Ivy) or leave it as is? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/f4237388ea9b93278db12a43c9db9f18e51b6f7f#commitcomment-23518067 Good catch ð would you mind to have a look at 72b730fc, too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/9b2165894ef23247d658dd37e93161c1a59b1c65#commitcomment-23498086 What else must be done to remove it? Deprecate the class? Here's the [relevant discussion](http://www.mail-archive.com/ivy-user@ant.apache.org/msg00441.html) which refers to a [JIRA issue](https://issues.apache.org/jira/browse/IVY-612) attempting to document it. In particular, Xavier Hanin stated ``` CacheResolver has been introduced quite a long time ago and never documented because it wasn't supposed to be public. I'm still not sure it's a good idea to use it... IMO, Ivy caching mechanism should be strong enough to avoid the requirement for a cache resolver, at least at resolve time. With the addition of dynamic revisions caching in beta 2, now Ivy cache has all information necessary to be able to perform a resolve from the cache, without actually requiring to use the cache resolver. This may require some improvement, like accepting to use dynamic revision resolution cached data even when they have exceeded their TTL. This could be a special resolve mode or refresh mode. With this improvement, the last thing for which the cache resolver would still be useful is publishing. But even in this case, I'd prefer using a local repository with useOrigin="true": the behavior is sligthly different, but I think this should address all the needs covered by cache resolver which only has its root in bad caching support and is a design flaw. ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #56: use “Maven 2” consistently
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/366fb741f0772c8309f9dfe963f6032b091d7b89#commitcomment-23340291 Sorry for a terse suggestion, I meant we could provide more information to the end user about the symlink/symlinkmass now that the former could be made to work on NTFS 3.1; but that's an excess if the focus is on deprecation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #57: fix last inconsistencies in generics
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/57 fix last inconsistencies in generics ... use collections, not arrays You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy consistent-generics Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/57.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #57 commit e849096d3fb0070b0e4d5d387e38a2b7a42ebf8e Author: twogeeDate: 2017-07-27T19:38:15Z fix last inconsistencies in generics (use collections, not arrays) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #56: use “Maven 2” consistently
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/56 use âMaven 2â consistently You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy maven-2-in-asciidoc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/56.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #56 commit 43c4b48d2f0cbac6c0a8fda4b98f599202de9678 Author: twogeeDate: 2017-07-27T19:32:14Z use âMaven 2â consistently --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/6607bdcb3ba69d2ab4f41be6292cc5a6df6365ba#commitcomment-23339716 In URLHandlerDispatcher, ``` @Override public void download(final URL src, final File dest, final CopyProgressListener l) throws IOException { this.download(src, dest, l); } @Override public void upload(final File src, final URL dest, final CopyProgressListener l) throws IOException { this.upload(src, dest, l); } ``` look like recursion? Surely a default timeout constraint is missing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/commit/366fb741f0772c8309f9dfe963f6032b091d7b89#commitcomment-23334838 Do you mean for the `symlinkmass` deprecation? In this release, I just wanted it to be deprecated with a log message showing up so that it doesn't blow up existing builds where user might be using that option. Internally, setting that option to `true` in the upcoming version will be same as setting the `symlink` to `true` and that's intentional to allow backward compatibility for at least one or two releases till users have a chance to remove that option in their builds. A few releases down the line, we will just remove that option and that will result in a relevant exception. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/366fb741f0772c8309f9dfe963f6032b091d7b89#commitcomment-23334637 Perhaps `UnsupportedOperationException` would be a useful heuristic? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #55: use vectorised logo
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/55 use vectorised logo I'd like to remove downloaded.gif, error.gif, evicted.gif and searched.gif as well. Maybe we could vote on colours for downloaded and evicted ð if green is too dark or fuchsia is too garish (I took it because it's one of "safe" colours). You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy svg-logo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/55.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #55 commit 4fc1b04068194894decd755db032a6ed91063b6e Author: twogeeDate: 2017-07-27T13:32:44Z use vectorised logo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #53: Suppressed warnings
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129757849 --- Diff: src/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManager.java --- @@ -85,14 +85,12 @@ public LatestCompatibleConflictManager(String name, LatestStrategy strategy) { if (versionMatcher.isDynamic(mrid)) { while (iter.hasNext()) { IvyNode other = iter.next(); -if (versionMatcher.isDynamic(other.getResolvedId())) { +if (versionMatcher.isDynamic(other.getResolvedId()) +|| !versionMatcher.accept(mrid, other.getResolvedId()) +&& !handleIncompatibleConflict(parent, conflicts, node, other)) { --- End diff -- You are right. Although I was aware of short circuiting, I had a wrong semantic in mind about it. I was under the impression, the short circuiting happens "smartly" depending on what other operators are present in that expression. I read up the JLS (section 15.24)[1] now and as you note, the right side of the `||` will be completely ignored (irrespective of what additional operators exist in that expression) if the left side returns true. So this change of the `if` block is fine. [1] http://docs.oracle.com/javase/specs/jls/se7/html/jls-15.html#jls-15.24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #53: Suppressed warnings
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129668076 --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java --- @@ -71,132 +71,139 @@ --- End diff -- Here's a "diff -wc"-style diff [XmlReporteParser.zip](https://github.com/apache/ant-ivy/files/1177761/XmlReporteParser.zip) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #53: Suppressed warnings
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129587968 --- Diff: src/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManager.java --- @@ -85,14 +85,12 @@ public LatestCompatibleConflictManager(String name, LatestStrategy strategy) { if (versionMatcher.isDynamic(mrid)) { while (iter.hasNext()) { IvyNode other = iter.next(); -if (versionMatcher.isDynamic(other.getResolvedId())) { +if (versionMatcher.isDynamic(other.getResolvedId()) +|| !versionMatcher.accept(mrid, other.getResolvedId()) +&& !handleIncompatibleConflict(parent, conflicts, node, other)) { --- End diff -- This change doesn't look right. The previous logic would have returned `null` if the `versionMatcher.isDynamic` returned true. With this change, it will require an additional `&&` to be satisfied for the `!handlerIncompatibleConflict...` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #53: Suppressed warnings
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129593699 --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java --- @@ -71,132 +71,139 @@ --- End diff -- This file has a large change which appears to be reordering/restructuring the code logic. Given the nature of this diff, it's difficult to review it and see if this change introduces any changes in the logic or introduces any regressions. Plus this class is one of the very core ones. Also, I'm not too sure if the existing test cases cover for this level of change. Given all this, I'm not confident that these changes in this specific class are worth it, at least at the moment. Unless of course, some one else can review this specific class and approve it, would you be willing to undo the changes to this one class in this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/commit/87c4e0656a10f7d9c18a203cf80c01406aeb6820#commitcomment-23286798 Sure, I'll do a find/replace in one of my upcoming doc fixes commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/87c4e0656a10f7d9c18a203cf80c01406aeb6820#commitcomment-23286714 In fact, there's a bunch of places where [Mm]aven2 is used... [asciidoc-maven.zip](https://github.com/apache/ant-ivy/files/1172996/asciidoc-maven.zip) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/87c4e0656a10f7d9c18a203cf80c01406aeb6820#commitcomment-23286444 In asciidoc/tutorial/multiple.adoc, please replace Maven2 with Maven 2 for consistency ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #54: IVY-735 Support timeouts on resolvers
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #54: IVY-735 Support timeouts on resolvers
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/54 IVY-735 Support timeouts on resolvers The commit in this PR adds support for specifying connection and read timeouts for resolvers, so that users have control over how the resolvers behave when it comes to slow/unresponsive repositories. This feature has been requested in https://issues.apache.org/jira/browse/IVY-735 This commit introduces the concept of "timeout-constraints" within a Ivy settings file. There can be any number of named timeout constraints, each with (optional) values for connection and read timeouts. These named timeout constraints can then be referred to by the individual resolvers via the `timeoutConstraint` attribute on them. Standard resolvers all have been updated to support this new attribute. An example usage looks something like this: ``` ``` (explanation of what these settings signify are available in the docs here https://github.com/jaikiran/ant-ivy/commit/c0ffb23ae29197e7f47c140deb991139d0688421#diff-e094f56ed4707eb73f8621abe7bfb4e5R54) The commit also contains updates to documentation to include details of this new feature, plus test cases to verify the basic functionality of this feature on some specific resolvers. I need to check a few standard resolvers (like the ssh based ones) to make sure they honour this new timeout semantics too and include tests (if possible) for them. But at this point, this commit should cover the support and the code flow for most of the relevant resolvers like the `URLResolver`. In fact, one of the tests in this commit, actually simulates a HTTP backed repo being down, in a test case to verify the `URLResolver` honours these timeout constraints. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaikiran/ant-ivy ivy-735 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/54.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #54 commit c0ffb23ae29197e7f47c140deb991139d0688421 Author: Jaikiran PaiDate: 2017-07-10T04:50:38Z IVY-735 Support timeouts on resolvers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #53: Suppressed warnings
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/53 Suppressed warnings As described in previous PR, all compiler warnings are annotated. This PR removes a few of them, along with some refactoring. Changes are grouped in separate commits which are hopefully self-describing. You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy suppressed-warnings Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/53.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #53 commit 3781faf7238a3a9dc185a863f8b0582a7c28d1b4 Author: twogeeDate: 2017-07-18T12:08:13Z cosmetics commit ba221a1b4323aa59137886b48c70d2ba3480325f Author: twogee Date: 2017-07-18T12:09:12Z get rid of suppressed warnings commit bd0f075d2cecf7d6d86c9ce92ed6727438f06f05 Author: twogee Date: 2017-07-18T12:09:52Z refactor commit 2f0cd05b6ab4bb84eff3b21ebbc966de23e740f0 Author: twogee Date: 2017-07-18T12:10:08Z fix exceptions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #52: Generics in core
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #52: Generics in core
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127480601 --- Diff: src/java/org/apache/ivy/osgi/util/VersionRange.java --- @@ -306,7 +306,7 @@ public boolean isClosedRange() { return startVersion.equals(endVersion); } -public boolean contains(String versionStr) throws ParseException { +public boolean contains(String versionStr) { --- End diff -- Not sure about this one, either: it's a consequence of previous changes to Version which no longer throws exceptions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #52: Generics in core
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127475255 --- Diff: src/java/org/apache/ivy/plugins/repository/sftp/SFTPRepository.java --- @@ -148,7 +142,7 @@ public void put(File source, String destination, boolean overwrite) throws IOExc } } -private void mkdirs(String directory, ChannelSftp c) throws IOException, SftpException { +private void mkdirs(String directory, ChannelSftp c) throws SftpException { --- End diff -- Agree. This change can stay. I missed this while reviewing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #52: Generics in core
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127474316 --- Diff: src/java/org/apache/ivy/plugins/repository/sftp/SFTPRepository.java --- @@ -148,7 +142,7 @@ public void put(File source, String destination, boolean overwrite) throws IOExc } } -private void mkdirs(String directory, ChannelSftp c) throws IOException, SftpException { +private void mkdirs(String directory, ChannelSftp c) throws SftpException { --- End diff -- This is a private method... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #52: Generics in core
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127408025 --- Diff: src/java/org/apache/ivy/tools/analyser/JarJarDependencyAnalyser.java --- @@ -39,21 +39,22 @@ public JarJarDependencyAnalyser(File jarjarjarLocation) { } public ModuleDescriptor[] analyze(JarModule[] modules) { - StringBuilder jarjarCmd = new StringBuilder("java -jar \"").append( jarjarjarLocation.getAbsolutePath()).append("\" --find --level=jar "); MapjarModulesMap = new HashMap<>(); Map mds = new HashMap<>(); -for (int i = 0; i < modules.length; i++) { -jarModulesMap.put(modules[i].getJar().getAbsolutePath(), modules[i]); +for (JarModule jarModule : modules) { +jarModulesMap.put(jarModule.getJar().getAbsolutePath(), jarModule); DefaultModuleDescriptor md = DefaultModuleDescriptor.newBasicInstance( -modules[i].getMrid(), new Date(modules[i].getJar().lastModified())); -mds.put(modules[i].getMrid(), md); - jarjarCmd.append("\"").append(modules[i].getJar().getAbsolutePath()).append("\""); -if (i + 1 < modules.length) { -jarjarCmd.append(File.pathSeparator); -} +jarModule.getMrid(), new Date(jarModule.getJar().lastModified())); +mds.put(jarModule.getMrid(), md); + jarjarCmd.append("\"").append(jarModule.getJar().getAbsolutePath()).append("\""); +jarjarCmd.append(File.pathSeparator); +} + +if (modules.length > 0) { +jarjarCmd.setLength(jarjarCmd.length() - 1); --- End diff -- It strips an extra pathSeparator character, but only if modules has any entries. It is an afterthought on my part... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #52: Generics in core
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127398802 --- Diff: src/java/org/apache/ivy/util/url/HttpClientHandler.java --- @@ -177,7 +177,7 @@ public URLInfo getURLInfo(URL url, int timeout) { return UNAVAILABLE; } -private boolean checkStatusCode(URL url, HttpMethodBase method) throws IOException { +private boolean checkStatusCode(URL url, HttpMethodBase method) { --- End diff -- Similar comment as here https://github.com/apache/ant-ivy/pull/52/files#r127395633 applies to this line --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #52: Generics in core
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127398451 --- Diff: src/java/org/apache/ivy/tools/analyser/JarJarDependencyAnalyser.java --- @@ -39,21 +39,22 @@ public JarJarDependencyAnalyser(File jarjarjarLocation) { } public ModuleDescriptor[] analyze(JarModule[] modules) { - StringBuilder jarjarCmd = new StringBuilder("java -jar \"").append( jarjarjarLocation.getAbsolutePath()).append("\" --find --level=jar "); MapjarModulesMap = new HashMap<>(); Map mds = new HashMap<>(); -for (int i = 0; i < modules.length; i++) { -jarModulesMap.put(modules[i].getJar().getAbsolutePath(), modules[i]); +for (JarModule jarModule : modules) { +jarModulesMap.put(jarModule.getJar().getAbsolutePath(), jarModule); DefaultModuleDescriptor md = DefaultModuleDescriptor.newBasicInstance( -modules[i].getMrid(), new Date(modules[i].getJar().lastModified())); -mds.put(modules[i].getMrid(), md); - jarjarCmd.append("\"").append(modules[i].getJar().getAbsolutePath()).append("\""); -if (i + 1 < modules.length) { -jarjarCmd.append(File.pathSeparator); -} +jarModule.getMrid(), new Date(jarModule.getJar().lastModified())); +mds.put(jarModule.getMrid(), md); + jarjarCmd.append("\"").append(jarModule.getJar().getAbsolutePath()).append("\""); +jarjarCmd.append(File.pathSeparator); +} + +if (modules.length > 0) { +jarjarCmd.setLength(jarjarCmd.length() - 1); --- End diff -- I don't fully follow what this is block is meant for. Is it to conditionally include the `File.pathSeparator` character? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #52: Generics in core
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127397658 --- Diff: src/java/org/apache/ivy/plugins/repository/ssh/SshCache.java --- @@ -263,9 +263,8 @@ public void clearSession(Session session) { * @param session *to connect to * @return channelSftp or null if not successful (channel not existent or dead) - * @throws IOException if something goes wrong */ -public ChannelSftp getChannelSftp(Session session) throws IOException { +public ChannelSftp getChannelSftp(Session session) { --- End diff -- Similar comment as here https://github.com/apache/ant-ivy/pull/52/files#r127395633 applies to this line --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #52: Generics in core
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127397389 --- Diff: src/java/org/apache/ivy/plugins/repository/sftp/SFTPRepository.java --- @@ -148,7 +142,7 @@ public void put(File source, String destination, boolean overwrite) throws IOExc } } -private void mkdirs(String directory, ChannelSftp c) throws IOException, SftpException { +private void mkdirs(String directory, ChannelSftp c) throws SftpException { --- End diff -- Similar comment as here https://github.com/apache/ant-ivy/pull/52/files#r127395633 applies to this line --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #52: Generics in core
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127396424 --- Diff: src/java/org/apache/ivy/osgi/util/VersionRange.java --- @@ -306,7 +306,7 @@ public boolean isClosedRange() { return startVersion.equals(endVersion); } -public boolean contains(String versionStr) throws ParseException { +public boolean contains(String versionStr) { --- End diff -- Similar comment as here https://github.com/apache/ant-ivy/pull/52/files#r127395633 applies to this line --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #52: Generics in core
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127396341 --- Diff: src/java/org/apache/ivy/osgi/repo/RepositoryManifestIterable.java --- @@ -59,11 +59,11 @@ protected InputStream getInputStream(String f) throws IOException { return repo.getResource(f).openStream(); } -protected List listBundleFiles(String dir) throws IOException { +protected List listBundleFiles(String dir) { return asList(ResolverHelper.listAll(repo, dir)); } -protected List listDirs(String dir) throws IOException { +protected List listDirs(String dir) { --- End diff -- Similar comment as here https://github.com/apache/ant-ivy/pull/52/files#r127395633 applies to this line --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #52: Generics in core
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127396320 --- Diff: src/java/org/apache/ivy/osgi/repo/RepositoryManifestIterable.java --- @@ -59,11 +59,11 @@ protected InputStream getInputStream(String f) throws IOException { return repo.getResource(f).openStream(); } -protected List listBundleFiles(String dir) throws IOException { +protected List listBundleFiles(String dir) { --- End diff -- Similar comment as here https://github.com/apache/ant-ivy/pull/52/files#r127395633 applies to this line --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #52: Generics in core
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127395825 --- Diff: src/java/org/apache/ivy/osgi/repo/AbstractFSManifestIterable.java --- @@ -44,9 +44,9 @@ public AbstractFSManifestIterable(T root) { return new FSManifestIterator(); } -protected abstract List listBundleFiles(T dir) throws IOException; +protected abstract List listBundleFiles(T dir); -protected abstract List listDirs(T dir) throws IOException; +protected abstract List listDirs(T dir); --- End diff -- Similar comment as here https://github.com/apache/ant-ivy/pull/52/files#r127395633 applies to this line --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #52: Generics in core
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127395788 --- Diff: src/java/org/apache/ivy/osgi/repo/AbstractFSManifestIterable.java --- @@ -44,9 +44,9 @@ public AbstractFSManifestIterable(T root) { return new FSManifestIterator(); } -protected abstract List listBundleFiles(T dir) throws IOException; +protected abstract List listBundleFiles(T dir); --- End diff -- Similar comment as here https://github.com/apache/ant-ivy/pull/52/files#r127395633 applies to this line --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #52: Generics in core
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127395633 --- Diff: src/java/org/apache/ivy/osgi/p2/XMLInputParser.java --- @@ -19,12 +19,11 @@ import java.io.IOException; import java.io.InputStream; -import java.text.ParseException; import org.xml.sax.SAXException; public interface XMLInputParser { -void parse(InputStream in) throws ParseException, IOException, SAXException; +void parse(InputStream in) throws IOException, SAXException; --- End diff -- Given that `ParseException` is a checked exception, removing this from the throws clause can cause existing callers of this method (potentially outside of Ivy) to run into compile issues. Is there some specific reason why this is being removed from the throws clause? If not, can you please undo this change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user nlalevee commented on the pull request: https://github.com/apache/ant-ivy/commit/6f22f4b49c2a3a59840d28e6cbe0c37a56ab1f90#commitcomment-23071422 Probably. And rather than asking for it, it is often better to suggest a patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #:
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/6f22f4b49c2a3a59840d28e6cbe0c37a56ab1f90#commitcomment-23069324 Neat! ð Perhaps it would make sense to ask asciidoctorj team to add support for inlined Ruby and ditto for asciidoctor-ant? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #51: Fix some string comparisons with ==
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #52: Generics in core
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/52 Generics in core This is as far as I can get without significant changes to API. Any remaining points of contention are annotated by `@SuppressWarnings` (and I'm not proud of what `NoFilter` looks like). If you need proof that arrays of generics are broken, just change `List` back to `T[]` in `ModuleRules` and watch the fireworks. You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy generics-in-core Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/52.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #52 commit cce62bb298d2af097a6b595a6f3f058ae6c4d3b7 Author: twogeeDate: 2017-07-06T06:04:24Z Add generics and Java 7 syntax to core commit 91668c1ce81f396558be2e04542a9d95dbaed103 Author: twogee Date: 2017-07-09T10:01:05Z Checkstyle --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #51: Fix some string comparisons with ==
GitHub user chinhodado opened a pull request: https://github.com/apache/ant-ivy/pull/51 Fix some string comparisons with == You can merge this pull request into a Git repository by running: $ git pull https://github.com/chinhodado/ant-ivy master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/51.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #51 commit 6544faf31651216a0a9188a6b3223b2412ecc68d Author: Trung DoDate: 2017-07-06T23:31:36Z Fix some string comparisons with == --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #50: Check spelling, fix whitespace and links
Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/50 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...
I believe stackoverflow has an answer [1] Gintas [1] https://stackoverflow.com/questions/30454635/when-using-for-a-primitive-and-a-boxed-value-is-autoboxing-done-or-is-unbox 2017-07-01 15:56 GMT+02:00 jaikiran: > Github user jaikiran commented on a diff in the pull request: > > https://github.com/apache/ant-ivy/pull/48#discussion_r125161935 > > --- Diff: > src/java/org/apache/ivy/plugins/signer/bouncycastle/OpenPGPSignatureGenerator.java > --- > @@ -161,7 +159,7 @@ private PGPSecretKey readSecretKey(InputStream in) > throws IOException, PGPExcept > key = k; > } > if ((keyId != null) > -&& (Long.valueOf(keyId, 16).longValue() == > (k.getKeyID() & MASK))) { > +&& (Long.valueOf(keyId, 16) == (k.getKeyID() > & MASK))) { > --- End diff -- > > I'm not 100% sure how Java autoboxing/unboxing deals in this case. > Does it autobox the primitive to a wrapper `Long` and do a `==` check or > does it do a unboxing of the `Long` to a primitive and do a `==` check? > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- > > - > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org > For additional commands, e-mail: dev-h...@ant.apache.org > >
[GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/48#discussion_r125161935 --- Diff: src/java/org/apache/ivy/plugins/signer/bouncycastle/OpenPGPSignatureGenerator.java --- @@ -161,7 +159,7 @@ private PGPSecretKey readSecretKey(InputStream in) throws IOException, PGPExcept key = k; } if ((keyId != null) -&& (Long.valueOf(keyId, 16).longValue() == (k.getKeyID() & MASK))) { +&& (Long.valueOf(keyId, 16) == (k.getKeyID() & MASK))) { --- End diff -- I'm not 100% sure how Java autoboxing/unboxing deals in this case. Does it autobox the primitive to a wrapper `Long` and do a `==` check or does it do a unboxing of the `Long` to a primitive and do a `==` check? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/48#discussion_r125162592 --- Diff: src/java/org/apache/ivy/plugins/signer/bouncycastle/OpenPGPSignatureGenerator.java --- @@ -161,7 +159,7 @@ private PGPSecretKey readSecretKey(InputStream in) throws IOException, PGPExcept key = k; } if ((keyId != null) -&& (Long.valueOf(keyId, 16).longValue() == (k.getKeyID() & MASK))) { +&& (Long.valueOf(keyId, 16) == (k.getKeyID() & MASK))) { --- End diff -- I haven't yet found an answer to this in some of the docs I quickly checked. I plan to check the Java specification later tonight. But if you can revert this one line from the rest of the PR, then I will go ahead and merge it since the rest of the PR is fine. I can read up about this a bit more without you having to wait for this PR to be merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #49: Aesthetic changes in .gitignore, build.xml and bui...
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #50: Check spelling, fix whitespace and links
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/50 Check spelling, fix whitespace and links Why can't we drop configuration* in asciidoc? You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy asciidoc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/50.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #50 commit ac2c09bcafa54e9d6ab85b14528161376c998d7f Author: twogeeDate: 2017-06-29T08:46:12Z Uniform indentation commit 2c6089a5c4203ec4decb6450e5a26f6579ba6c08 Author: twogee Date: 2017-06-29T09:40:04Z Sort entries in .gitignore commit 7df6dbb6d4f151acf187a1dcf85a2877205b1fcb Author: twogee Date: 2017-06-30T14:26:10Z More uniform indentation commit cb7135838e90fee1068203a817003b0bdbb1390e Author: twogee Date: 2017-06-29T08:46:12Z Uniform indentation commit 506669a0640f60eff018bfb552984363f5e627ed Author: twogee Date: 2017-06-29T09:40:04Z Sort entries in .gitignore commit af84c83fb6cc2935b3ffe26687cfeb3d2c1e0a1f Author: twogee Date: 2017-06-30T14:26:10Z More uniform indentation commit 9658093ee58c1d4781d2e9deedcb7d8c55fe8e4c Author: twogee Date: 2017-06-30T14:30:50Z Merge branch 'master' of https://github.com/twogee/ant-ivy commit 8757e7356d621e0ce18eae4cbec12bdfc7ef99d1 Author: twogee Date: 2017-06-30T18:27:13Z Check spelling commit 327e38632839f8f9fdae813469fe9b69d41a99d2 Author: twogee Date: 2017-06-30T20:12:15Z Fix whitespace commit 993a542aceb995b82d9ccf6bf9c5f729aeee1076 Author: twogee Date: 2017-06-30T20:23:03Z Fix links --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #49: Aesthetic changes in .gitignore, build.xml and bui...
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/49 Aesthetic changes in .gitignore, build.xml and build-release.xml You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ant-ivy/pull/49.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #49 commit ac2c09bcafa54e9d6ab85b14528161376c998d7f Author: twogeeDate: 2017-06-29T08:46:12Z Uniform indentation commit 2c6089a5c4203ec4decb6450e5a26f6579ba6c08 Author: twogee Date: 2017-06-29T09:40:04Z Sort entries in .gitignore commit 7df6dbb6d4f151acf187a1dcf85a2877205b1fcb Author: twogee Date: 2017-06-30T14:26:10Z More uniform indentation commit cb7135838e90fee1068203a817003b0bdbb1390e Author: twogee Date: 2017-06-29T08:46:12Z Uniform indentation commit 506669a0640f60eff018bfb552984363f5e627ed Author: twogee Date: 2017-06-29T09:40:04Z Sort entries in .gitignore commit af84c83fb6cc2935b3ffe26687cfeb3d2c1e0a1f Author: twogee Date: 2017-06-30T14:26:10Z More uniform indentation commit 9658093ee58c1d4781d2e9deedcb7d8c55fe8e4c Author: twogee Date: 2017-06-30T14:30:50Z Merge branch 'master' of https://github.com/twogee/ant-ivy --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org