[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 I reviewed third party libraries that could be updated; the documentation could be more emphatic about jspc being deprecated. --- -

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 SLF4J was written by the [author of Log4j](https://en.wikipedia.org/wiki/Log4j) who wrote [an article](https://articles.qos.ch/classloader.html) cataloguing the problems with Commons Logging. When

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/50 Actually I do not agree with the slf4j change ;-) What problem are you trying to solve? To me both existing logging backends are legacy and we maintain them for people who want to use them -

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/50 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/11/ ---

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/50 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/5/ ---

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/50 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/10/ ---

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/50 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/4/ ---

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/50 I don't really think you need a PR - I've upgraded BCEL last week and did so directly. Ant tends to use a "commit then review" model where people look at the commits and things get amended later. ---

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 I updated WHATSNEW and added a replacement for all legacy logging frameworks. There are more potential updates: Java Mail API, Rhino, Jasper; perhaps they deserve a separate PR? ---

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/50 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/9/ ---

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/ant/pull/50 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/3/ ---

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-11 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/50 looks good to me - you may want to add a note to WHATSNEW as well --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-11 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/50 I'll have a look later and try not to be a PITA again. WRT antunit. https://github.com/apache/ant-antlibs-antunit and you are a committer ;-) ---

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-10 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 I hope the third time is the charm 😄 A couple of wishes for antunit: it should have ant/ant-launcher as "provided" dependencies and it should have a "tempdir" attribute similar to junit task.

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-10 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/50 :+1: --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-10 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 This is exactly why I was looking into it -- those things tend to deteriorate over time 😄 To sum it up, I'll revert stripping, restore CPL and correct the README (that tests rely on JUnit 3

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-10 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/50 Thank you. The junit 4 situation is a bit weird, even more than I recalled it to be. I didn't remember us stripping classes from the jar and don't think this is true for the 4.11 jar in our

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-09 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 BTW, JUnit license has changed from CPL to EPL. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands,

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-09 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 Sorry about confusion 😊 -- here comes a corrected commit. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-09 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/50 Ant's junit task itself is supposed to work with JUnit 3 not only 4, so it is not superfluous at all IMHO, --- - To unsubscribe,

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-09 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 Sorry about the whitespace -- I can separate all "drive-by" changes into a commit on its own. Could you please elaborate on having both JUnit 3 and 4? JUnit 4 is Java 5 compatible, and most test

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-09 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/ant/pull/50 Thank you @twogee The idea was you can build a minimal set of Ant (without the optional tasks that have external dependencies) and run the tests for this minimal set without downloading