Re: [patch] [bugfix] IntrospectionHelper.java

2003-03-26 Thread Stefan Bodewig 
On Wed, 26 Mar 2003, Neeme Praks [EMAIL PROTECTED] wrote:
 Stefan Bodewig ::
 On Sat, 01 Mar 2003, Neeme Praks [EMAIL PROTECTED] wrote:

storeElement() method silently returns, if the tag does not support
the specified element.

 This is because storeElement can never be called without calling
 createElement before that from within Ant.  It may be different
 from within Jelly, I don't know.
 
 So, could we fix this?

Sure.  You mean you want to fix Jelly? 8-)

If you don't invoke createElement before you call storeElement, you
are probable in trouble anyway.

I'm going to throw in the extra check in CVS HEAD later
today/tomorrow.

Stefan

Re: [patch] [bugfix] IntrospectionHelper.java

2003-03-26 Thread Neeme Praks 
ok, fair enough. I sent a patch to commons-dev with a workaround for 
Jelly anyway... just have to check back now if the patch was actually 
noticed or not ;-)

Stefan Bodewig ::
On 26 Mar 2003, Stefan Bodewig [EMAIL PROTECTED] wrote:

I'm going to throw in the extra check in CVS HEAD later
today/tomorrow.

I spoke too soon.  Given the javadocs:
 * Stores a named nested element using a storage method determined
 * by the initial introspection. If no appropriate storage method
 * is available, this method returns immediately.
it would be a break of backwards compatibility if we started to throw
an exception instead of simply returning, sorry.
Stefan