AW: Ivy - Buildjobs/PreCommit

2017-05-24 Thread jhm
Not sure about this expertise because my sources were old, but I think the 
github-plugin does not support matrix jobs.
https://github.com/KostyaSha/github-integration-plugin/issues/53

Maybe a newer plugin version would do, but I could not see the version stamp.
I'll ask on builds@a.o for help.

For the meanwhile I deactivated the matrix-PR-job and reactivated the 'old' 
plain-PR-job.

If we can't get matrix support we should be to create our own 'matrix' by 
copying that job and sticking to certain configurations.
While a matrix would scale this approach won't. So we should define only 2-4 
most interesting configs like
- Java7@Unix
- Java7@Windows
- Java8@Unix


Jan

> -Ursprüngliche Nachricht-
> Von: J Pai [mailto:jai.forums2...@gmail.com]
> Gesendet: Montag, 22. Mai 2017 14:45
> An: Ant Developers List
> Betreff: Re: Ivy - Buildjobs/PreCommit
> 
> It looks like there might be some issue with the matrix job(s)
> https://builds.apache.org/job/Ivy-GithubPR-Matrix/2/console
> 
> From what I understand of that log, it seems like the parent matrix job
> (the one above) is correctly checking out the commit from the submitted
> PR:
> 
>  > Checking out Revision c1765c71ba4394597409de790bf4529ff97e866e
> (master)  > git config core.sparsecheckout # timeout=10  > git checkout
> -f c1765c71ba4394597409de790bf4529ff97e866e
>  > git rev-parse origin/master^{commit} # timeout=10  > git rev-list
> 239bc0b04a95d6c0f82e59c513de36d68c033c6a # timeout=10
> 
> However, it then hands off the job execution to individual
> Windows/Linux jobs and those jobs https://builds.apache.org/job/Ivy-
> GithubPR-Matrix/jdk=JDK%201.7%20(latest),os=ubuntu/2/console don’t seem
> to be able to checkout the commit(s) from the PR and fail with error
> like:
> 
> > Fetching upstream changes from https://github.com/apache/ant-ivy/
> 
>  > git --version # timeout=10
>  > git fetch --tags --progress
> https://github.com/apache/ant-ivy/
>  +refs/heads/*:refs/remotes/origin/*
> Checking out Revision c1765c71ba4394597409de790bf4529ff97e866e (master)
> > git config core.sparsecheckout # timeout=10  > git checkout -f
> c1765c71ba4394597409de790bf4529ff97e866e
> FATAL: Could not checkout c1765c71ba4394597409de790bf4529ff97e866e
> 
> hudson.plugins.git.GitException
> : Command "git checkout -f c1765c71ba4394597409de790bf4529ff97e866e"
> returned status code 128:
> stdout:
> stderr: fatal: reference is not a tree:
> c1765c71ba4394597409de790bf4529ff97e866e
> 
>   at
> org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPI
> Impl.java:1866)
> 
> 
> -Jaikiran
> 
> On 22-May-2017, at 12:25 PM, Jan Matèrne (jhm) 
> wrote:
> 
> >> On a related note, while we are at this - does Apache infra allow
> the
> > jobs to be run against Windows OS Jenkins agents as well? There are a
> > few issues specifically reported against Windows OS and having the
> job
> > run against linux and Windows OS should give a decent coverage for
> the
> > upstream code.
> >
> > In Jenkins there is the concept of « Matrix » job.
> > Here is the ones for Ant:
> > https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-
> > Windows/  > Matrix-1.9.x-Windows/>
> > https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-
> > Linux/
> >  > 1.9.x-Linux/>
> > AFAIR, it used to be able to do on several different OS. I don’t know
> > why they are split.
> >
> > And I don’t know if it is possible to do it while pulling a PR from
> > github.
> 
> 
> New buildjob "Ivy-GithubPR-Matrix". I deactivated the old (so we could
> easily switch back).
> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR-Matrix/
> Basically a copy of the old job:
> * discard old build jobs (keep 10)
> * git merge support: fail the build if push fails
> * github project: git://github.com/apache/ant-ivy.git
> * git
>  -- repository: git://github.com/apache/ant-ivy.git
>  -- branches: */master (= default)
>  -- clean before checkout
>  -- recursively update submodules
>  -- build commits submitted for validated merge (= PR support)
> * start build: build pull request to the repository (= PR support)
> * configuration matrix
>  -- JDK: JDK 1.7 (latest), JDK 1.8 (latest), JDK 9 b156 with jigsaw
>  -- os: label expression = ["ubuntu", "Windows"]
> * abort the build if it's stuck: absolute 20 minutes
> * Lock: Ant
> * build
>  -- ant(standard): clean coverage-report
> * publish junit: build/test-report/**
> 
> 
> Jan
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> commands, e-mail: dev-h...@ant.apache.org
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> commands, e-mail: dev-h...@ant.apache.org




AW: Ivy - Buildjobs/PreCommit

2017-05-22 Thread jhm
> > On a related note, while we are at this - does Apache infra allow the
> jobs to be run against Windows OS Jenkins agents as well? There are a
> few issues specifically reported against Windows OS and having the job
> run against linux and Windows OS should give a decent coverage for the
> upstream code.
> 
> In Jenkins there is the concept of « Matrix » job.
> Here is the ones for Ant:
> https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-
> Windows/  Matrix-1.9.x-Windows/>
> https://builds.apache.org/view/A/view/Ant/job/Ant-Build-Matrix-1.9.x-
> Linux/  1.9.x-Linux/>
> AFAIR, it used to be able to do on several different OS. I don’t know
> why they are split.
> 
> And I don’t know if it is possible to do it while pulling a PR from
> github.


New buildjob "Ivy-GithubPR-Matrix". I deactivated the old (so we could easily 
switch back).
https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR-Matrix/
Basically a copy of the old job:
* discard old build jobs (keep 10)
* git merge support: fail the build if push fails
* github project: git://github.com/apache/ant-ivy.git
* git
  -- repository: git://github.com/apache/ant-ivy.git
  -- branches: */master (= default)
  -- clean before checkout
  -- recursively update submodules
  -- build commits submitted for validated merge (= PR support)
* start build: build pull request to the repository (= PR support)
* configuration matrix
  -- JDK: JDK 1.7 (latest), JDK 1.8 (latest), JDK 9 b156 with jigsaw
  -- os: label expression = ["ubuntu", "Windows"]
* abort the build if it's stuck: absolute 20 minutes
* Lock: Ant
* build
  -- ant(standard): clean coverage-report
* publish junit: build/test-report/**


Jan


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



AW: Ivy - Buildjobs/PreCommit

2017-05-22 Thread jhm
I'll try setting up the PreCommit-Job as Matrix job with Linux/Window.

Jan



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



AW: Ivy - Buildjobs/PreCommit

2017-05-17 Thread jhm
My last test result:
The Jenkins job could not load Findbugs. So I have deactivated that for the 
moment.

https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/6/console
ant-1.9.9> ant clean jar sources checkstyle-internal coverage-report 
  resolve:
  BUILD FAILED
  /.../build.xml:184: java.lang.ClassCastException: 
org.apache.ivy.core.module.descriptor.DefaultModuleDescriptor cannot be cast to 
org.apache.ivy.core.module.descriptor.ModuleDescriptor
at 
org.apache.ivy.ant.IvyPostResolveTask.getConfsToResolve(IvyPostResolveTask.java:233)
at 
org.apache.ivy.ant.IvyPostResolveTask.ensureResolved(IvyPostResolveTask.java:219)
at 
org.apache.ivy.ant.IvyPostResolveTask.prepareAndCheck(IvyPostResolveTask.java:179)
at org.apache.ivy.ant.IvyRetrieve.doExecute(IvyRetrieve.java:88)
at org.apache.ivy.ant.IvyTask.execute(IvyTask.java:272)

ant-1.9.9> ant -f build-release.xml -Drat.failOnError=false rat
  not run due to prior problems


Some ideas?


Jan


> -Ursprüngliche Nachricht-
> Von: J Pai [mailto:jai.forums2...@gmail.com]
> Gesendet: Mittwoch, 17. Mai 2017 13:18
> An: Ant Developers List
> Betreff: Re: Ivy - Buildjobs/PreCommit
> 
> Updated the same PR and that triggered this job
> https://builds.apache.org/job/Ivy-GithubPR/3/. It failed to build due
> to a host not being resolvable. This job ran on node called H15
> https://builds.apache.org/computer/H15/ whereas the first job which had
> succeeded had run on https://builds.apache.org/computer/qnode3/. Maybe
> all nodes are not equal and perhaps this job needs to be
> assigned/categorized to certain node groups?
> 
> -Jaikiran
> On 17-May-2017, at 4:03 PM, Jan Matèrne (jhm) 
> wrote:
> 
> Thanks, I changed the job to run:
> 
> ant clean jar sources findbugs checkstyle-internal coverage-report ant
> -f build-release.xml -Drat.failOnError=false rat
> 
> Please try again ;)
> 
> 
> Jan
> 
> 
> > -Ursprüngliche Nachricht-
> > Von: J Pai [mailto:jai.forums2...@gmail.com]
> > Gesendet: Mittwoch, 17. Mai 2017 10:53
> > An: Ant Developers List
> > Betreff: Re: Ivy - Buildjobs/PreCommit
> >
> > It turns out the PR you submitted was to your personal repo instead
> of
> > the apache repo. I just submitted a dummy PR to apache repo
> > https://github.com/apache/ant-ivy/pull/13 and that did indeed trigger
> > the Jenkins job https://builds.apache.org/view/A/view/Ant/job/Ivy-
> > GithubPR/1/ automagically :) I’m guessing this job isn’t running any
> > tests right now (given how quickly it finished)?
> >
> > This is good start to getting this working. Thanks for getting this
> > setup :)
> >
> > -Jaikiran
> >
> >
> > On 17-May-2017, at 2:07 PM, J Pai  wrote:
> >
> > Doesn’t look like it got triggered in Jenkins.
> >
> > -Jaikiran
> > On 17-May-2017, at 1:49 PM, Jan Matèrne (jhm) 
> > wrote:
> >
> >> I read the wiki page
> https://wiki.apache.org/general/PreCommitBuilds,
> >> the Kafka issue https://issues.apache.org/jira/browse/KAFKA-1856 and
> >> had a look at some other PreCommit-jobs.
> >> For me this works like that:
> >> 1. The PreCommit-Admin job checks regularly on for new patches in
> > Jira.
> >> 2. It invokes the "PreCommit-{JiraProject}" job mit Jira-ID and
> >> file-ID as argument.
> >> 3. The job does the rest.
> >>
> >> That means the job itself has to apply the patchfile - and of course
> >> run the build.
> >>
> >> On the other hand I found a blog post from infra
> >> https://blogs.apache.org/infra/entry/github_pull_request_builds_now
> >> and set up an according job
> >> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/
> >> This job uses the Github integration by Cloudbees Enterprise plugin.
> >> So next step for test would be a new/updated PR ...
> >
> > I've created a small PR https://github.com/janmaterne/ant-ivy/pull/1.
> > Now ... wait ;)
> >
> > Jan
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> > commands, e-mail: dev-h...@ant.apache.org
> >
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> > commands, e-mail: dev-h...@ant.apache.org
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> commands, e-mail: dev-h...@ant.apache.org
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> commands, e-mail: dev-h...@ant.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



AW: Ivy - Buildjobs/PreCommit

2017-05-17 Thread jhm
Thanks, I changed the job to run:

ant clean jar sources findbugs checkstyle-internal coverage-report
ant -f build-release.xml -Drat.failOnError=false rat

Please try again ;)


Jan


> -Ursprüngliche Nachricht-
> Von: J Pai [mailto:jai.forums2...@gmail.com]
> Gesendet: Mittwoch, 17. Mai 2017 10:53
> An: Ant Developers List
> Betreff: Re: Ivy - Buildjobs/PreCommit
> 
> It turns out the PR you submitted was to your personal repo instead of
> the apache repo. I just submitted a dummy PR to apache repo
> https://github.com/apache/ant-ivy/pull/13 and that did indeed trigger
> the Jenkins job https://builds.apache.org/view/A/view/Ant/job/Ivy-
> GithubPR/1/ automagically :) I’m guessing this job isn’t running any
> tests right now (given how quickly it finished)?
> 
> This is good start to getting this working. Thanks for getting this
> setup :)
> 
> -Jaikiran
> 
> 
> On 17-May-2017, at 2:07 PM, J Pai  wrote:
> 
> Doesn’t look like it got triggered in Jenkins.
> 
> -Jaikiran
> On 17-May-2017, at 1:49 PM, Jan Matèrne (jhm) 
> wrote:
> 
> > I read the wiki page https://wiki.apache.org/general/PreCommitBuilds,
> > the Kafka issue https://issues.apache.org/jira/browse/KAFKA-1856 and
> > had a look at some other PreCommit-jobs.
> > For me this works like that:
> > 1. The PreCommit-Admin job checks regularly on for new patches in
> Jira.
> > 2. It invokes the "PreCommit-{JiraProject}" job mit Jira-ID and
> > file-ID as argument.
> > 3. The job does the rest.
> >
> > That means the job itself has to apply the patchfile - and of course
> > run the build.
> >
> > On the other hand I found a blog post from infra
> > https://blogs.apache.org/infra/entry/github_pull_request_builds_now
> > and set up an according job
> > https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/
> > This job uses the Github integration by Cloudbees Enterprise plugin.
> > So next step for test would be a new/updated PR ...
> 
> I've created a small PR https://github.com/janmaterne/ant-ivy/pull/1.
> Now ... wait ;)
> 
> Jan
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> commands, e-mail: dev-h...@ant.apache.org
> 
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> commands, e-mail: dev-h...@ant.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



AW: Ivy - Buildjobs/PreCommit

2017-05-17 Thread jhm
> I read the wiki page https://wiki.apache.org/general/PreCommitBuilds,
> the Kafka issue https://issues.apache.org/jira/browse/KAFKA-1856 and
> had a look at some other PreCommit-jobs.
> For me this works like that:
> 1. The PreCommit-Admin job checks regularly on for new patches in Jira.
> 2. It invokes the "PreCommit-{JiraProject}" job mit Jira-ID and file-ID
> as argument.
> 3. The job does the rest.
> 
> That means the job itself has to apply the patchfile - and of course
> run the build.
> 
> On the other hand I found a blog post from infra
> https://blogs.apache.org/infra/entry/github_pull_request_builds_now and
> set up an according job
> https://builds.apache.org/view/A/view/Ant/job/Ivy-GithubPR/
> This job uses the Github integration by Cloudbees Enterprise plugin.
> So next step for test would be a new/updated PR ...

I've created a small PR https://github.com/janmaterne/ant-ivy/pull/1.
Now ... wait ;)

Jan


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org