AW: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread jhm
> > In my eyes most of the committers don't like these "code style"
> changes.
> > So please stop these changes and invest your energy more productive.
> >
> > I don't think it would be helpful if another committer starts
> > reverting the changes because of a different preference ...
> 
> 
> With all due respect, please let me know what do you prefer: for
> instance, is test parametrization good, bad or annoying?


For that single point I think parametrization is 'good'.
If I count right, it impacted three test classes.
Why change all the others?

Starting a discussion before such big changes would also be helpful.

Jan





-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



AW: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread jhm
> > Changes like these are random personal preferences.
> 
> Right.
> 
> > The fact that these are being done even after the mail discussions we
> > recently had, indicates that the request to not do such changes have
> > been ignored. This is going down the route of a being some kind of a
> > personal individual hobby project. So I'm just going to stop
> bothering
> > looking into these commits anymore and just stay away from them and
> > stop sending this frustrated and rude sounding mails.
> 
> I must admit I share your frustration and have to thank you for voicing
> it when I didn't dare to do.
> 
> TBH I've given up on giving the changes to tests more that a cursory
> look and hoping "this one is going to be the last one".


In my eyes most of the committers don't like these "code style" changes.
So please stop these changes and invest your energy more productive.

I don't think it would be helpful if another committer starts reverting the
changes because of a different preference ...


Jan




-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org