Re: [Patch] es to be submitted
On Fri, 11 Apr 2003, Antoine Levy-Lambert [EMAIL PROTECTED] wrote: There are several bug reports where I have prepared code, and documentation and testcases , and I would like them to be submitted before the code patches are obsolete : There are certain constants in life, one is there will always be a huge patch backlog in Ant 8-) http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17007 allow to define ZipFileSet(s) outside of Zip task this is an easy one, And at the same time something that I wouldn't want to apply. It interferes with several proposals to introduce some kind of polymorphism in Ant. I'm sure that you are not aware of them, but there've been plans and even complete code for such things. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15434 MimeMailer doesn't work properly with national charset I looked into it, but I'm not really familiar with JavaMail. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18431 new p4labelsync task this one has been requested by one user; and even less with Perforce. When things like this happen, I usually hope that a patch is confirmed (i.e. works for me) by at least one other (Perforce in this case) user. since it is a new task, it should not harm any one. Sorry, this is somewhat short sighted, every new task that no committer can maintain does harm to Ant in some way or the other. Stefan
Re: [Patch] es to be submitted
On Fri, 11 Apr 2003, Jan Materne [EMAIL PROTECTED] wrote: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18849 Adds a new skip attribute to HeadFilter and TailFilter. We (or at least I) have some informal segmentation in Ant's code base. Bruce is the selector guy, Magesh is the filter guy and so on. Unless Magesh finds time for this, I'll assign it to myself sometime later this months. Note that your patch - just like Antoine's - are not really targeting a piece of code that was changing every day, so it is unlikely a patch would go bad within the next weeks. The patch command itself does a reasonably good job to merge things, even if there were changes. Stefan
RE: [Patch] es to be submitted
Actually, that's interesting, and somewhat freaky because last night when I was having trouble falling asleep, I thought some more about my DynamicTag class, and I actually thought of stuff that could solve that particular use case ;-) See DynamicTag implements DynamicConfigurator, and you normal compose a dynatag within your task (both examples I provided), but you can also make your task itself implement DynamicConfigurator, and forward the call to a pre-initializes private dynatag. Provided that the task then forwards the maybeConfigure() call to the private dynatag, it's functionally equivalent, except you can put any element that's the required type (FileSet in this case) directly inside the task, instead of within the nested dynatag instead. The snag if that if you do that, you can have only one such implicit dynatag, parametrized on a single expect type (can take an array of types to satisfy, but applies AND logic on them). But then again you can still using composition if you need to do polymorphism for several 'types' of sub-element. Nodoby looked at DynamicTag, so I guess I'm the only one seeing this ;-) Cheers, --DD -Original Message- From: Stefan Bodewig [mailto:[EMAIL PROTECTED] Sent: Friday, April 11, 2003 9:36 AM To: [EMAIL PROTECTED] Subject: Re: [Patch] es to be submitted On Fri, 11 Apr 2003, Dominique Devienne [EMAIL PROTECTED] wrote: What's going on around the idea of Polymorphism in Ant? (beyond datatype refid=xyz / that is) The idea is to enable copy ... zipfileset src=foo.zip/ /copy or copy ... fileset src=foo.zip ant:type=zipfileset/ /copy or something similar without doing anything in copy to make it aware of ZipFileSet.
Re: [Patch] es to be submitted
I will get to it - please be patient, Jan. - Original Message - From: Stefan Bodewig [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, April 11, 2003 10:22 AM Subject: Re: [Patch] es to be submitted On Fri, 11 Apr 2003, Jan Materne [EMAIL PROTECTED] wrote: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18849 Adds a new skip attribute to HeadFilter and TailFilter. We (or at least I) have some informal segmentation in Ant's code base. Bruce is the selector guy, Magesh is the filter guy and so on. Unless Magesh finds time for this, I'll assign it to myself sometime later this months. Note that your patch - just like Antoine's - are not really targeting a piece of code that was changing every day, so it is unlikely a patch would go bad within the next weeks. The patch command itself does a reasonably good job to merge things, even if there were changes. Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
