Re: ant git commit: Add dependency description

2018-03-24 Thread Jaikiran Pai
JUnit 5 introduces a new set of APIs which separates out the launching aspects and the test identification and execution of those tests. As such, the launcher APIs is what the junitlauncher task uses/requires. Test engines on the other hand are pluggable and aren't necessary for the

Re: ant git commit: Add dependency description

2018-03-19 Thread Gintautas Grigelionis
2018-03-17 16:09 GMT+01:00 Gintautas Grigelionis : > > > I was wondering why junitlauncher task depended on all jars being present > in Ant classpath with no possibility to set a separate classpath for the > task? > ... especially because ant -f fetch.xml seems to fetch

Re: ant git commit: Add dependency description

2018-03-17 Thread Gintautas Grigelionis
Thanks for correcting the omission. But, the task manual page states that junit.jar of JUnit 4 might still be necessary ... For junit-vintage engine: - junit-vintage-engine.jar - junit.jar (JUnit 4.x version) ... so perhaps it's worth a note anyway. I was wondering why junitlauncher

Re: ant git commit: Add dependency description

2018-03-17 Thread Jaikiran Pai
The change noted in this commit isn't actually needed i.e. the junitlauncher task doesn't require the junit.jar to be available as noted in the junitlauncher task's manual. I however forgot to include the JUnit 5 platform API dependencies in this Library Dependencies table, which I'll add