Re: junitlauncher dependency on JUnit4?

2018-03-20 Thread Gintautas Grigelionis
2018-03-20 16:43 GMT+01:00 Stefan Bodewig : > On 2018-03-20, Gintautas Grigelionis wrote: > > > My understanding is that junitlauncher has a dependency on JUnit 4 > through > > vintage engine. I guess pom should provide profiles for engine choice. > See > > my earlier questions re the task classpa

Re: junitlauncher dependency on JUnit4?

2018-03-20 Thread Stefan Bodewig
On 2018-03-20, Jaikiran Pai wrote: > This looks like some odd merge or squashing issue when I pushed that > task changes. I have fixed it. The task itself doesn't need any JUnit > test engine specific dependencies like this one. I just pushed the > commit upstream which should fix this. Looks goo

Re: junitlauncher dependency on JUnit4?

2018-03-20 Thread Jaikiran Pai
Hi Stefan, This looks like some odd merge or squashing issue when I pushed that task changes. I have fixed it. The task itself doesn't need any JUnit test engine specific dependencies like this one. I just pushed the commit upstream which should fix this. P.S: I haven't responded to some oth

Re: junitlauncher dependency on JUnit4?

2018-03-20 Thread Stefan Bodewig
On 2018-03-20, Gintautas Grigelionis wrote: > My understanding is that junitlauncher has a dependency on JUnit 4 through > vintage engine. I guess pom should provide profiles for engine choice. See > my earlier questions re the task classpath. Only when running the tests. The launcher task itself

Re: junitlauncher dependency on JUnit4?

2018-03-20 Thread Gintautas Grigelionis
My understanding is that junitlauncher has a dependency on JUnit 4 through vintage engine. I guess pom should provide profiles for engine choice. See my earlier questions re the task classpath. Gintas Den tis 20 mars 2018 16:28Stefan Bodewig skrev: > Hi > > I've just added a POM for ant-junitla

junitlauncher dependency on JUnit4?

2018-03-20 Thread Stefan Bodewig
Hi I've just added a POM for ant-junitlauncher and it currently fails to build as org.apache.tools.ant.taskdefs.optional.junitlauncher.SingleTestClass has a dependency on org.junit.Test and I haven't declared any dependency on JUnit4 inside the POM (only transitively with scope test). The class h