[GitHub] apex-malhar pull request #597: Apexmalhar 2274.merge pr490

2017-05-03 Thread amberarrow
GitHub user amberarrow reopened a pull request: https://github.com/apache/apex-malhar/pull/597 Apexmalhar 2274.merge pr490 This is just #490 with merge conflicts resolved. It looks good to me, so I'll merge it in a day or two unless I hear any additional requests for change

[GitHub] apex-malhar pull request #597: Apexmalhar 2274.merge pr490

2017-05-03 Thread amberarrow
Github user amberarrow closed the pull request at: https://github.com/apache/apex-malhar/pull/597 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] apex-malhar pull request #593: Apexmalhar 2274.merge matt fixes

2017-03-30 Thread amberarrow
Github user amberarrow closed the pull request at: https://github.com/apache/apex-malhar/pull/593 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] apex-malhar pull request #597: Apexmalhar 2274.merge pr490

2017-03-30 Thread amberarrow
GitHub user amberarrow opened a pull request: https://github.com/apache/apex-malhar/pull/597 Apexmalhar 2274.merge pr490 This is just #490 with merge conflicts resolved. It looks good to me, so I'll merge it in a day or two unless I hear any additional requests for change

[GitHub] apex-malhar pull request #593: Apexmalhar 2274.merge matt fixes

2017-03-28 Thread amberarrow
GitHub user amberarrow opened a pull request: https://github.com/apache/apex-malhar/pull/593 Apexmalhar 2274.merge matt fixes This is just https://github.com/apache/apex-malhar/pull/490 with merge conflicts resolved. It looks good to me, so I'll merge it in a day or two unless

[GitHub] apex-malhar pull request #592: APEXMALHAR-2457 Remove duplicate entries

2017-03-28 Thread amberarrow
GitHub user amberarrow reopened a pull request: https://github.com/apache/apex-malhar/pull/592 APEXMALHAR-2457 Remove duplicate entries Fixed duplicate entries. @tweise please take a look. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] apex-malhar pull request #592: APEXMALHAR-2457 Remove duplicate entries

2017-03-28 Thread amberarrow
Github user amberarrow closed the pull request at: https://github.com/apache/apex-malhar/pull/592 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] apex-malhar pull request #592: APEXMALHAR-2457 Remove duplicate entries

2017-03-28 Thread amberarrow
GitHub user amberarrow opened a pull request: https://github.com/apache/apex-malhar/pull/592 APEXMALHAR-2457 Remove duplicate entries Fixed duplicate entries. @tweise please take a look. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] apex-malhar pull request #494: APEXMALHAR-2338 Remove stray # characters

2016-11-11 Thread amberarrow
GitHub user amberarrow opened a pull request: https://github.com/apache/apex-malhar/pull/494 APEXMALHAR-2338 Remove stray # characters @davidyan74 Please review You can merge this pull request into a Git repository by running: $ git pull https://github.com/amberarrow/incubator

[GitHub] apex-malhar pull request #474: APEXMALHAR-2322 Suppress strict Javadoc check...

2016-11-07 Thread amberarrow
Github user amberarrow closed the pull request at: https://github.com/apache/apex-malhar/pull/474 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] apex-malhar pull request #474: APEXMALHAR-2322 Suppress strict Javadoc check...

2016-10-29 Thread amberarrow
GitHub user amberarrow reopened a pull request: https://github.com/apache/apex-malhar/pull/474 APEXMALHAR-2322 Suppress strict Javadoc checking in Java 8 Running "mvn javadoc:aggregate" with Java 8 produces many errors due to stricter checking; this change restores

[GitHub] apex-malhar pull request #474: APEXMALHAR-2322 Suppress strict Javadoc check...

2016-10-29 Thread amberarrow
Github user amberarrow closed the pull request at: https://github.com/apache/apex-malhar/pull/474 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] apex-malhar pull request #474: APEXMALHAR-2322 Suppress strict Javadoc check...

2016-10-29 Thread amberarrow
GitHub user amberarrow opened a pull request: https://github.com/apache/apex-malhar/pull/474 APEXMALHAR-2322 Suppress strict Javadoc checking in Java 8 Running "mvn javadoc:aggregate" with Java 8 produces many errors due to stricter checking; this change restores the pri

[GitHub] apex-malhar pull request #426: APEXMALHAR-2265 Added entries in mkdocs.yml f...

2016-09-22 Thread amberarrow
GitHub user amberarrow opened a pull request: https://github.com/apache/apex-malhar/pull/426 APEXMALHAR-2265 Added entries in mkdocs.yml for 2 newly added docs @sashadt Please take a look You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] apex-malhar pull request #368: APEXMALHAR-2184: Add documentation for File I...

2016-08-12 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/368#discussion_r74608810 --- Diff: docs/operators/fsInputOperator.md --- @@ -0,0 +1,101 @@ +File Input Operator += + +## Operator Objective

[GitHub] apex-malhar pull request #368: APEXMALHAR-2184: Add documentation for File I...

2016-08-12 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/368#discussion_r74608010 --- Diff: docs/operators/fsInputOperator.md --- @@ -0,0 +1,101 @@ +File Input Operator += + +## Operator Objective

[GitHub] apex-malhar pull request #368: APEXMALHAR-2184: Add documentation for File I...

2016-08-12 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/368#discussion_r74607706 --- Diff: docs/operators/fsInputOperator.md --- @@ -0,0 +1,101 @@ +File Input Operator += + +## Operator Objective

[GitHub] apex-malhar pull request #368: APEXMALHAR-2184: Add documentation for File I...

2016-08-12 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/368#discussion_r74607041 --- Diff: docs/operators/fsInputOperator.md --- @@ -0,0 +1,101 @@ +File Input Operator += + +## Operator Objective

[GitHub] apex-malhar pull request #368: APEXMALHAR-2184: Add documentation for File I...

2016-08-12 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/368#discussion_r74606819 --- Diff: docs/operators/fsInputOperator.md --- @@ -0,0 +1,101 @@ +File Input Operator += + +## Operator Objective

[GitHub] apex-malhar pull request #347: APEXMALHAR-2156 changes

2016-07-24 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/347#discussion_r71992493 --- Diff: library/pom.xml --- @@ -306,12 +306,24 @@ janino 2.7.8 test

[GitHub] apex-malhar pull request #347: APEXMALHAR-2156 changes

2016-07-24 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/347#discussion_r71992468 --- Diff: library/src/main/java/com/datatorrent/lib/io/jms/AbstractJMSInputOperator.java --- @@ -514,6 +514,11 @@ public WindowDataManager

[GitHub] apex-malhar pull request #347: APEXMALHAR-2156 changes

2016-07-24 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/347#discussion_r71992461 --- Diff: library/src/main/java/com/datatorrent/lib/io/jms/AbstractJMSInputOperator.java --- @@ -514,6 +514,11 @@ public WindowDataManager

[GitHub] apex-core issue #359: APEXCORE-494 Fixed the dynamic partition issue in case...

2016-07-22 Thread amberarrow
Github user amberarrow commented on the issue: https://github.com/apache/apex-core/pull/359 @chaithu14 Yes, some or all of the current partitions (possibly augmented by new ones) can be returned by definePartitions(). See https://issues.apache.org/jira/browse/APEXCORE-439

[GitHub] apex-malhar pull request #326: APEXMALHAR-2116 Added FS record reader operat...

2016-07-15 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/326#discussion_r70977817 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/fs/FSRecordReaderModule.java --- @@ -0,0 +1,344 @@ +/** + * Licensed

[GitHub] apex-malhar pull request #326: APEXMALHAR-2116 Added FS record reader operat...

2016-06-29 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/326#discussion_r69042391 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/fs/FSRecordReaderModule.java --- @@ -0,0 +1,332 @@ +/** + * Licensed

[GitHub] apex-malhar pull request #326: APEXMALHAR-2116 Added FS record reader operat...

2016-06-29 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/326#discussion_r69042316 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/fs/FSRecordReaderModule.java --- @@ -0,0 +1,332 @@ +/** + * Licensed

[GitHub] apex-malhar pull request #326: APEXMALHAR-2116 Added FS record reader operat...

2016-06-27 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/326#discussion_r68678627 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/fs/FSRecordReader.java --- @@ -0,0 +1,180 @@ +/** + * Licensed to the Apache

[GitHub] apex-malhar pull request #326: APEXMALHAR-2116 Added FS record reader operat...

2016-06-23 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/326#discussion_r68229511 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/fs/FSRecordReaderModule.java --- @@ -0,0 +1,331 @@ +/** + * Licensed

[GitHub] apex-malhar pull request #326: APEXMALHAR-2116 Added FS record reader operat...

2016-06-23 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/326#discussion_r68229454 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/fs/FSRecordReaderModule.java --- @@ -0,0 +1,331 @@ +/** + * Licensed

[GitHub] apex-malhar pull request #326: APEXMALHAR-2116 Added FS record reader operat...

2016-06-23 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/326#discussion_r68229363 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/fs/FSRecordReaderModule.java --- @@ -0,0 +1,331 @@ +/** + * Licensed

[GitHub] apex-malhar pull request #326: APEXMALHAR-2116 Added FS record reader operat...

2016-06-21 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/326#discussion_r67969125 --- Diff: library/src/main/java/org/apache/apex/malhar/lib/fs/FSRecordReader.java --- @@ -0,0 +1,175 @@ +/** + * Licensed to the Apache

[GitHub] apex-malhar pull request #318: APEXMALHAR-2119 add setters for partition cou...

2016-06-16 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/318#discussion_r67351327 --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/AbstractFileInputOperator.java --- @@ -1110,6 +1116,16 @@ public String toString

[GitHub] apex-malhar pull request #320: APEXMALHAR-2120 #resolve #comment solve probl...

2016-06-15 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/apex-malhar/pull/320#discussion_r67269717 --- Diff: kafka/src/test/java/org/apache/apex/malhar/kafka/KafkaInputOperatorTest.java --- @@ -120,8 +127,14 @@ public KafkaInputOperatorTest(boolean

[GitHub] apex-site issue #36: Adding announcements and meetups to Apex front page

2016-06-06 Thread amberarrow
Github user amberarrow commented on the issue: https://github.com/apache/apex-site/pull/36 Looks good. Ram On Mon, Jun 6, 2016 at 2:58 PM, Sasha <notificati...@github.com> wrote: > I have updated the pull request with suggestions to lim

[GitHub] incubator-apex-core pull request: [APEXCORE-332][WIP] Improve part...

2016-05-26 Thread amberarrow
Github user amberarrow commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/347#discussion_r64847617 --- Diff: .idea/codeStyleSettings.xml --- @@ -104,5 +104,6 @@ + --- End diff