Re: Contribution Process before PR

2017-01-16 Thread Chinmay Kolhatkar
I agree that the discussions are important. There are currently discussions being happening over mailing list but some topics might be get missed and we should improve there. The tasks should be brought to community before the design starts and then mature the design through community discussion. T

Re: Contribution Process before PR

2017-01-16 Thread Bhupesh Chawda
I agree. The discussion on requirements very much helps folks to understand the need for a feature and sometimes much more about related topics. From my own experience, the discussion thread on requirements before the implementation is what helps the design discussions and allows even people not aw

Re: Contribution Process before PR

2017-01-16 Thread Sandesh Hegde
I do see value in having the review PR along with the discussion in the mailing list/jira. It shows the commitment of the Author to the idea and to the project. There is some truth in what Linus Torvalds says https://lkml.org/lkml/2000/8/25/132 Thanks On Mon, Jan 16, 2017 at 8:11 AM Amol Kekre

Re: Contribution Process before PR

2017-01-16 Thread Amol Kekre
I do see folks discussing issues for most part now. For me this does not look like an issue that is hurting Apex community. I do however want to discuss cases where code gets blocked and get spilled into larger context. As a culture and a process, we have a very high overhead that deters contributi

Re: Contribution Process before PR

2017-01-15 Thread Pramod Immaneni
Yes, it will be good to have these points added to the contributor guidelines but I also see for the most part folks do bring up issues for discussion, try to address concerns and come to a consensus and in generally participate in the community. I also think we should have some latitude in the pro

Re: Contribution Process before PR

2017-01-15 Thread Munagala Ramanath
Yes, I think an initial discussion that includes some or all of the following would be invaluable both for feature implementations and for bug fixes: 1. Discussion of current implementation and how/why it fails to meet current need. 2. Possible approaches and tradeoffs (if any) for each. 3. Recomme

Contribution Process before PR

2017-01-15 Thread Thomas Weise
Hi, I want to propose additions to the contributor guidelines that place stronger emphasis on open collaboration and the early part of the contribution process. Specifically, I would like to suggest that *thought process* and *design discussion* are more important than the final code produced. It