Re: Regarding including zip file as part of source code

[Sanjay Pujare]

>Other python dependencies required by user python code as now needs to be
>installed on Hadoop node.

So you are assuming Python itself is installed on each Hadoop node and
other Python packages needed by user's Python code are also installed? Can
your py4j package be installed thru "pip" - Python's native package
manager? If that's possible why does it need to be added to the Apex repo?
The user will anyway need to ensure all Python dependencies are satisfied
and your py4j package is just one of them. We can just document the
dependency, can't we?





On Fri, Jul 7, 2017 at 8:46 AM, vikram patil  wrote:

> Thanks Vlad, Thomas .
>
> Py4j acts as a bridge between Java and Python . So py4j  package is needed
> ( like jar ) for code to work properly.
> If it is installed on Hadoop node then it won't be needed but since this
> code is used as part of basic framework to establish bridge between java
> and python framework, it needs to be transported at application launch.
>
> Other python dependencies required by user python code as now needs to be
> installed on Hadoop node.
>
> Thanks & Regards,
> Vikram
>
>
>
>

Re: Regarding including zip file as part of source code

[vikram patil]

Thanks Vlad, Thomas .

Py4j acts as a bridge between Java and Python . So py4j  package is needed
( like jar ) for code to work properly.
If it is installed on Hadoop node then it won't be needed but since this
code is used as part of basic framework to establish bridge between java
and python framework, it needs to be transported at application launch.

Other python dependencies required by user python code as now needs to be
installed on Hadoop node.

Thanks & Regards,
Vikram

On Fri, Jul 7, 2017 at 7:54 PM, Thomas Weise  wrote:

> We generally don't want any archives or binary files in the repo.
>
> Why is this needed? Maybe once that is clear we can find alternative
> solution.
>
> Thanks
>
>
> On Fri, Jul 7, 2017 at 6:57 AM, Vlad Rozov 
> wrote:
>
> > You may add .zip (or any other binary file) to github repo but
> >
> > - it must be excluded from the Apache source code release
> > - it must be possible to build without the binary file as it will not be
> > included into the source release
> >
> > Thank you,
> >
> > Vlad
> >
> >
> > On 7/7/17 05:03, vikram patil wrote:
> >
> >> Hello All,
> >>
> >> I would like to include py4j-0.10.4-src.zip as part of source code.
> >> Python implementation PR I have opened, is dependent on this file. This
> >> file is manually created source zip file from py4j source code.
> >>
> >> Please let me know policy regarding this one so I can update PR with
> >> appropriate changes .
> >>
> >> Thanks & Regards,
> >> Vikram
> >>
> >
> >
>

Re: Regarding including zip file as part of source code

[Thomas Weise]

We generally don't want any archives or binary files in the repo.

Why is this needed? Maybe once that is clear we can find alternative
solution.

Thanks


On Fri, Jul 7, 2017 at 6:57 AM, Vlad Rozov  wrote:

> You may add .zip (or any other binary file) to github repo but
>
> - it must be excluded from the Apache source code release
> - it must be possible to build without the binary file as it will not be
> included into the source release
>
> Thank you,
>
> Vlad
>
>
> On 7/7/17 05:03, vikram patil wrote:
>
>> Hello All,
>>
>> I would like to include py4j-0.10.4-src.zip as part of source code.
>> Python implementation PR I have opened, is dependent on this file. This
>> file is manually created source zip file from py4j source code.
>>
>> Please let me know policy regarding this one so I can update PR with
>> appropriate changes .
>>
>> Thanks & Regards,
>> Vikram
>>
>
>

Re: Regarding including zip file as part of source code

[Vlad Rozov]

You may add .zip (or any other binary file) to github repo but

- it must be excluded from the Apache source code release
- it must be possible to build without the binary file as it will not be 
included into the source release


Thank you,

Vlad

On 7/7/17 05:03, vikram patil wrote:

Hello All,

I would like to include py4j-0.10.4-src.zip as part of source code.  
Python implementation PR I have opened, is dependent on this file. 
This file is manually created source zip file from py4j source code.


Please let me know policy regarding this one so I can update PR with 
appropriate changes .


Thanks & Regards,
Vikram