Re: [DISCUSS] Proposal: remove snowflake algorithm in the request-id plugin

2023-06-20 Thread Jinhua Luo
I prefer the remove snowflake algorithm because it does more harm than good. And compared to uuid, its only benefits are faster speed and incremental id generation, but these two benefits have little use in practice. Ling Samuel 于2023年6月14日周三 16:55写道: > > *Background* > > The snowflake algorithm

Re: [DISCUSS] Proposal: remove snowflake algorithm in the request-id plugin

2023-06-20 Thread wei liu
I agree with the removal of this plugin. The uuid algorithm is sufficient for now. The snowflake algorithm does not provide additional benefits and leads to possible business disruptions. If the user insists on using this algorithm, as it is only a plugin, it is relatively easy to upgrade up from t

Re: [DISCUSS] Proposal: remove snowflake algorithm in the request-id plugin

2023-06-20 Thread Chao Zhang
OK, I see. +1 Chao Zhang https://github.com/tokers On June 20, 2023 at 15:12:27, Ling Samuel (lingsamuelgr...@gmail.com) wrote: Hi, it is a breaking change indeed. About the plugin detail, I have explained in the main thread. > Snowflake depends on a unique worker_id, which is acquired from et

Re: [DISCUSS] Proposal: remove snowflake algorithm in the request-id plugin

2023-06-20 Thread Ling Samuel
Hi, it is a breaking change indeed. About the plugin detail, I have explained in the main thread. > Snowflake depends on a unique worker_id, which is acquired from etcd. If etcd fails, each request with request-id plugin that uses the snowflake algorithm needs to try to retrieve a unique worker_i

Re: [DISCUSS] Proposal: remove snowflake algorithm in the request-id plugin

2023-06-14 Thread LI Fabrice
Hi, First of all, that will be a breaking change. In addition, if the user is using the old version and then updates to the new version, it is necessary to verify and explain the change of request-id plugin. Finally, can you give some info of the request-id plugin when etcd is unavailable? F

Re: [DISCUSS] Proposal: remove snowflake algorithm in the request-id plugin

2023-06-14 Thread Chao Zhang
Hi, Does this feature used by users? Chao Zhang https://github.com/tokers On June 14, 2023 at 16:55:45, Ling Samuel (lingsamuelgr...@gmail.com) wrote: *Background* The snowflake algorithm in the request-id plugin introduces an unnecessary dependency on etcd. This will significantly affect APIS

[DISCUSS] Proposal: remove snowflake algorithm in the request-id plugin

2023-06-14 Thread Ling Samuel
*Background* The snowflake algorithm in the request-id plugin introduces an unnecessary dependency on etcd. This will significantly affect APISIX performance if etcd is unavailable. Snowflake depends on a unique worker_id, which is acquired from etcd. If etcd fails, each request with request-id p