Re: Proposal: update rate-limit plugin's HTTP response code to 429 for error

2023-02-23 Thread ronething
+1 But we need to mark this as a breaking change. Traky Deng 于2023年2月22日周三 17:49写道: > Hello, > > It has been noted by Nicolas (cc-ed in the email) during a doc review that > the rate-limit plugin currently defaults to 503 HTTP response code for > requests exceeding the configured rate limit. HT

Re: Proposal: update rate-limit plugin's HTTP response code to 429 for error

2023-02-23 Thread 李 奕浩
+1, it should be a BREAKING CHANGE. 发自我的 iPhone > 在 2023年2月23日,13:27,Jintao Zhang 写道: > > +1 > > But we need to mark this as a breaking change. > > Chao Zhang 于2023年2月23日周四 09:58写道: > >> Hi, >> >> +1 from me. >> >> Chao Zhang >> https://github.com/tokers >> >> On February 22, 2023 at 1

Re: Proposal: update rate-limit plugin's HTTP response code to 429 for error

2023-02-22 Thread Jintao Zhang
+1 But we need to mark this as a breaking change. Chao Zhang 于2023年2月23日周四 09:58写道: > Hi, > > +1 from me. > > Chao Zhang > https://github.com/tokers > > On February 22, 2023 at 17:49:25, Traky Deng (trakyd...@api7.ai) wrote: > > Hello, > > It has been noted by Nicolas (cc-ed in the email) durin

Re: Proposal: update rate-limit plugin's HTTP response code to 429 for error

2023-02-22 Thread Chao Zhang
Hi, +1 from me. Chao Zhang https://github.com/tokers On February 22, 2023 at 17:49:25, Traky Deng (trakyd...@api7.ai) wrote: Hello, It has been noted by Nicolas (cc-ed in the email) during a doc review that the rate-limit plugin currently defaults to 503 HTTP response code for requests exceedi

Re: Proposal: update rate-limit plugin's HTTP response code to 429 for error

2023-02-22 Thread Zexuan Luo
It's acceptable to me, but I am not sure about the impact on the user as someone will check the response status 503 in the client's code. Let's see other people's opinions. Traky Deng 于2023年2月22日周三 17:49写道: > > Hello, > > It has been noted by Nicolas (cc-ed in the email) during a doc review that

Proposal: update rate-limit plugin's HTTP response code to 429 for error

2023-02-22 Thread Traky Deng
Hello, It has been noted by Nicolas (cc-ed in the email) during a doc review that the rate-limit plugin currently defaults to 503 HTTP response code for requests exceeding the configured rate limit. HTTP 429 Too Many Requests response code might be a better fit: https://developer.mozilla.org/en-US