Re: apr_json object key doublons

2018-08-31 Thread Graham Leggett
On 31 Aug 2018, at 22:19, Yann Ylavic wrote: > Actually this updated patch, rather. > There is no more copy with an apr_table than with an apr_hash (we > still point to the given key). > I also added apr_json_object_add() for explicitely allowing doublons, > while apr_json_object_set() still

Re: apr_json object key doublons

2018-08-31 Thread Yann Ylavic
[CC dev@ this time] On Fri, Aug 31, 2018 at 3:20 PM Yann Ylavic wrote: > > On Fri, Aug 31, 2018 at 2:41 PM Graham Leggett wrote: > > > > On 31 Aug 2018, at 14:26, Yann Ylavic wrote: > > > > > I wonder if we shouldn't change the apr_hash_t (currently used to > > > handle JSON objects) to an

buildbot success in on apr-x64-macosx-trunk

2018-08-31 Thread buildbot
The Buildbot has detected a restored build on builder apr-x64-macosx-trunk while building . Full details are available at: https://ci.apache.org/builders/apr-x64-macosx-trunk/builds/161 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs Build Reason: The

buildbot success in on apr-trunk

2018-08-31 Thread buildbot
The Buildbot has detected a restored build on builder apr-trunk while building . Full details are available at: https://ci.apache.org/builders/apr-trunk/builds/282 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: orcus_ubuntu Build Reason: The AnyBranchScheduler scheduler

Re: svn commit: r1839755 - in /apr/apr/trunk: include/apr_json.h json/apr_json.c json/apr_json_decode.c

2018-08-31 Thread Eric Covener
On Fri, Aug 31, 2018 at 12:20 PM Rainer Jung wrote: > > To clarify: the CI build failures only send a summary email to the dev > list. If you want to see the output, you need to visit the CI build page > (link included in the failure mail) and there clock on the appropriate > "stdio" link. That's

Re: svn commit: r1839755 - in /apr/apr/trunk: include/apr_json.h json/apr_json.c json/apr_json_decode.c

2018-08-31 Thread William A Rowe Jr
On Fri, Aug 31, 2018 at 11:20 AM, Rainer Jung wrote: > To clarify: the CI build failures only send a summary email to the dev > list. If you want to see the output, you need to visit the CI build page > (link included in the failure mail) and there clock on the appropriate > "stdio" link. That's

Re: svn commit: r1839755 - in /apr/apr/trunk: include/apr_json.h json/apr_json.c json/apr_json_decode.c

2018-08-31 Thread Rainer Jung
To clarify: the CI build failures only send a summary email to the dev list. If you want to see the output, you need to visit the CI build page (link included in the failure mail) and there clock on the appropriate "stdio" link. That's probably from where Bill took the log snippet. Regards,

Re: svn commit: r1839755 - in /apr/apr/trunk: include/apr_json.h json/apr_json.c json/apr_json_decode.c

2018-08-31 Thread Christophe JAILLET
Le 31/08/2018 à 16:17, Eric Covener a écrit : On Fri, Aug 31, 2018 at 10:04 AM Yann Ylavic wrote: On Fri, Aug 31, 2018 at 3:29 PM William A Rowe Jr wrote: I presume you are subscribed to the commits list, which broadcasts our CI results? Hmm, I'm supposed to be subscribed to commits@ list

Re: svn commit: r1839755 - in /apr/apr/trunk: include/apr_json.h json/apr_json.c json/apr_json_decode.c

2018-08-31 Thread William A Rowe Jr
Here's what I have, it is apparently the dev@ list... Mailing-List: contact dev-h...@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To:

Re: Backports to consider for 1.6.4?

2018-08-31 Thread Nick Kew
> Pull request #5 https://github.com/apache/apr/pull/5/files > corresponds to https://bz.apache.org/bugzilla/show_bug.cgi?id=61985 > Yann and I are neutral on dodging (fd == -1), what do others think? > This would be a trivial one-line fix if we adopt it. > > Are there any committers with an

Re: 1.6 release?

2018-08-31 Thread Nick Kew
> On 30 Aug 2018, at 07:20, William A Rowe Jr wrote: > > This was my workaround for 1.6.x, more eyeballs and feedback welcome. Looks fine to me. I've dug deep in memory for that change: it was down to protecting a caller who had fed bad inputs to apr_time_exp_get. The broken change was

Re: svn commit: r1839755 - in /apr/apr/trunk: include/apr_json.h json/apr_json.c json/apr_json_decode.c

2018-08-31 Thread Eric Covener
On Fri, Aug 31, 2018 at 10:04 AM Yann Ylavic wrote: > > On Fri, Aug 31, 2018 at 3:29 PM William A Rowe Jr wrote: > > > > I presume you are subscribed to the commits list, which broadcasts our CI > > results? > > Hmm, I'm supposed to be subscribed to commits@ list but somehow I > didn't receive

Re: svn commit: r1839755 - in /apr/apr/trunk: include/apr_json.h json/apr_json.c json/apr_json_decode.c

2018-08-31 Thread Yann Ylavic
On Fri, Aug 31, 2018 at 3:29 PM William A Rowe Jr wrote: > > I presume you are subscribed to the commits list, which broadcasts our CI > results? Hmm, I'm supposed to be subscribed to commits@ list but somehow I didn't receive this one (yet?). Or is it a special list? > > testjson:

Re: svn commit: r1839755 - in /apr/apr/trunk: include/apr_json.h json/apr_json.c json/apr_json_decode.c

2018-08-31 Thread William A Rowe Jr
I presume you are subscribed to the commits list, which broadcasts our CI results? testjson: FAILED 1 of 7Line 62: expected something other than <{ "Image" : {"Width" : 800 ,"IDs" : [116, 943, 234, 38793],"Title" : "View from 15th Floor","Animated" : false,

Re: apr_json object key doublons

2018-08-31 Thread Graham Leggett
On 31 Aug 2018, at 14:26, Yann Ylavic wrote: > I wonder if we shouldn't change the apr_hash_t (currently used to > handle JSON objects) to an apr_table_t, such that key doublons are not > an issue (this isn't one in JSON specification AFAICT). > > Then we could get rid of 'klen' handling in

buildbot failure in on apr-x64-macosx-trunk

2018-08-31 Thread buildbot
The Buildbot has detected a new failure on builder apr-x64-macosx-trunk while building . Full details are available at: https://ci.apache.org/builders/apr-x64-macosx-trunk/builds/159 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: svn-x64-macosx-dgvrs Build Reason: The

buildbot failure in on apr-trunk

2018-08-31 Thread buildbot
The Buildbot has detected a new failure on builder apr-trunk while building . Full details are available at: https://ci.apache.org/builders/apr-trunk/builds/280 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: orcus_ubuntu Build Reason: The AnyBranchScheduler scheduler named

apr_json object key doublons

2018-08-31 Thread Yann Ylavic
I wonder if we shouldn't change the apr_hash_t (currently used to handle JSON objects) to an apr_table_t, such that key doublons are not an issue (this isn't one in JSON specification AFAICT). Then we could get rid of 'klen' handling in several places (NUL terminated string is fine for keys IMHO,