Re: cvs commit: apr-util/buckets apr_buckets_simple.c

2001-02-28 Thread Cliff Woolley
On 28 Feb 2001 [EMAIL PROTECTED] wrote: Fix some warnings related to the fact that you can't do arithmetic with a void *. Oops, sorry about that. Didn't get the warning on my Linux box. Thanks for the fix. --Cliff

apr_bucket_init_types?

2001-02-28 Thread Cliff Woolley
Why do we need an array of all the bucket types, and therefore apr_bucket_init_types() and apr_bucket_insert_type()? I seem to recall that this was necessary in the very early days of the bucket API. But I can't see any reason to keep them anymore. (The error bucket gets by without registering

Re: apr_bucket_init_types?

2001-02-28 Thread Cliff Woolley
On Tue, 27 Feb 2001, Cliff Woolley wrote: Nothing uses the array that gets built. Can anyone think of a reason I shouldn't delete the array and these two functions? Alright, they're going away. apr_bucket_insert_type() doesn't even work right. (The second assignment should be to *newone,

Re: apr_bucket_init_types?

2001-02-28 Thread Greg Stein
It's a bit moot now :-) .. but yah: they can/should be tossed. Good eye. Cheers, -g On Tue, Feb 27, 2001 at 10:18:56PM -0500, Cliff Woolley wrote: Why do we need an array of all the bucket types, and therefore apr_bucket_init_types() and apr_bucket_insert_type()? I seem to recall that this

[RFC] Network Abstraction Layer

2001-02-28 Thread Sander Striker
Hi, Before I start throwing stuff at you, I'll introduce myself. I'm Sander Striker, one of the Samba TNG team members. We have been looking at the APR a bit to find out if we can use it in our code. It looks all very promissing and that's why we want to contribute some ideas to (from our point

Re: cvs commit: apr-util/buckets apr_buckets_simple.c

2001-02-28 Thread jean-frederic clere
Cliff Woolley wrote: On 28 Feb 2001 [EMAIL PROTECTED] wrote: Fix some warnings related to the fact that you can't do arithmetic with a void *. Oops, sorry about that. Didn't get the warning on my Linux box. Thanks for the fix. --Cliff These warning were errors on my Solaris

Re: cvs commit: apr-util/buckets apr_buckets_simple.c

2001-02-28 Thread Greg Stein
On Wed, Feb 28, 2001 at 11:40:21AM +, Ben Laurie wrote: [EMAIL PROTECTED] wrote: trawick 01/02/27 18:19:02 Modified:buckets apr_buckets_simple.c Log: Fix some warnings related to the fact that you can't do arithmetic with a void *. Wouldn't it be better to

Re: cvs commit: apr-util/xml/expat/lib .cvsignore Makefile.in ascii.h asciitab.h expat.dsp expat.h.in iasciitab.h latin1tab.h nametab.h utf8tab.h winconfig.h xmlparse.c xmlrole.c xmlrole.h xmltok.c xmltok.h xmltok_impl.c xmltok_impl.h xmltok_ns.c

2001-02-28 Thread Greg Stein
On Wed, Feb 28, 2001 at 02:41:32PM -, [EMAIL PROTECTED] wrote: gstein 01/02/28 06:41:32 Added: xml/expat .cvsignore Makefile.in README acconfig.h buildconf.sh configure.in xml/expat/conftools .cvsignore PrintPath install-sh missing

Re: cvs commit: apr-util/buckets apr_brigade.c

2001-02-28 Thread Cliff Woolley
On 28 Feb 2001 [EMAIL PROTECTED] wrote: buf = malloc(APR_BUCKET_BUFF_SIZE); b = apr_bucket_heap_create(buf, APR_BUCKET_BUFF_SIZE, 0, NULL); APR_BRIGADE_INSERT_TAIL(bb, b); +b-length = 0; /* We are writing into the brigade, and +

Re: cvs commit: apr-util/xml apr_xml.c

2001-02-28 Thread William A. Rowe, Jr.
From: [EMAIL PROTECTED] Sent: Wednesday, February 28, 2001 9:14 AM gstein 01/02/28 07:14:50 Modified:xml apr_xml.c Log: enable building against old/new expats Revision ChangesPath 1.18 +6 -3 apr-util/xml/apr_xml.c +#include apu_config.h May

Re: cvs commit: apr-util/buckets apr_brigade.c

2001-02-28 Thread Cliff Woolley
On 28 Feb 2001 [EMAIL PROTECTED] wrote: buf = malloc(APR_BUCKET_BUFF_SIZE); b = apr_bucket_heap_create(buf, APR_BUCKET_BUFF_SIZE, 0, NULL); On a side note, we currently have two macros that do almost the same thing: APR_BUCKET_BUFF_SIZE (=9000) which determines

Re: cvs commit: apr-util/buckets apr_brigade.c

2001-02-28 Thread Cliff Woolley
On Wed, 28 Feb 2001 [EMAIL PROTECTED] wrote: I like making APR_BUCKET_BUFF_SIZE == 8192 [and using it] Okay, I'll do that. and removing the other. HUGE_STRING_LEN comes from apr_lib.h, not from within aprutil, and other parts of APR (and maybe Apache, too) are using it. It ought to be

Re: cvs commit: apr-util/xml apr_xml.c

2001-02-28 Thread William A. Rowe, Jr.
wrowe 01/02/28 08:58:35 Modified:xml apr_xml.c Log: Just trying to keep Win32 semi-buildable I'll be rid of the crufty hack this eve, and incorporate the new expat so the srclib/ copy can be nuked late tonight/early tommorow. BTW... don't we already have an

Re: cvs commit: apr-util/build apu-conf.m4

2001-02-28 Thread Jeff Trawick
[EMAIL PROTECTED] writes: gstein 01/02/28 07:18:37 Modified:.buildconf.sh buildapu-conf.m4 Log: *) buildconf.sh should invoke expat's buildconf.sh, if it exists *) expat.h.in is a more reliable test for an Expat distribution *) look for

Re: autoconf and Gnu m4... a matched set?

2001-02-28 Thread Jeff Trawick
Jim Jagielski [EMAIL PROTECTED] writes: According to the autoconf docs: Autoconf requires GNU `m4' in order to generate the scripts. It uses features that some UNIX versions of `m4' do not have. It also overflows internal limits of some versions of `m4', including GNU `m4'

Re: Bucket API cleanup issues

2001-02-28 Thread Cliff Woolley
On Tue, 27 Feb 2001, Greg Stein wrote: Euh... I don't think we want another ring. A simpler idea is to have the apr_bucket_pool structure contain a pointer to an apr_bucket_heap structure. At cleanup time, you do the following: ... So what you get here is a single allocation of a heap

Re: cvs commit: apr-util/buckets apr_buckets_mmap.c

2001-02-28 Thread Cliff Woolley
On 28 Feb 2001 [EMAIL PROTECTED] wrote: pass the right value to free() to prevent segfaults and corrupted heaps and other nasties Ugghghhh... damn me. I'm just causing all sorts of problems, aren't I? sigh --Cliff

Re: cvs commit: apr-util/xml/expat/lib .cvsignore Makefile.in ascii.h asciitab.h expat.dsp expat.h.in iasciitab.h latin1tab.h nametab.h utf8tab.h winconfig.h xmlparse.c xmlrole.c xmlrole.h xmltok.c xmltok.h xmltok_impl.c xmltok_impl.h xmltok_ns.c

2001-02-28 Thread Sam TH
On Wed, Feb 28, 2001 at 02:41:32PM -, [EMAIL PROTECTED] wrote: Local changes and modifications were applied. See README.APRUTIL And where might one find such a file? sam th [EMAIL PROTECTED] http://www.abisource.com/~sam/ GnuPG

Re: cvs commit: apr-util/xml apr_xml.c

2001-02-28 Thread Greg Stein
On Wed, Feb 28, 2001 at 11:00:00AM -0600, William A. Rowe, Jr. wrote: wrowe 01/02/28 08:58:35 Modified:xml apr_xml.c Log: Just trying to keep Win32 semi-buildable I'll be rid of the crufty hack this eve, and incorporate the new expat so the srclib/ copy can

Re: cvs commit: apr-util/xml apr_xml.c

2001-02-28 Thread Greg Stein
On Wed, Feb 28, 2001 at 09:49:09AM -0600, William A. Rowe, Jr. wrote: From: [EMAIL PROTECTED] Sent: Wednesday, February 28, 2001 9:14 AM gstein 01/02/28 07:14:50 Modified:xml apr_xml.c Log: enable building against old/new expats Revision Changes

Re: cvs commit: apr-util/build apu-conf.m4

2001-02-28 Thread Greg Stein
On Wed, Feb 28, 2001 at 02:16:20PM -0500, Jeff Trawick wrote: [EMAIL PROTECTED] writes: gstein 01/02/28 07:18:37 Modified:.buildconf.sh buildapu-conf.m4 Log: ... *) invoke expat's configuration when APRUTIL is configured ... I suspect that

Re: cvs commit: apr-util/xml/expat/lib .cvsignore Makefile.in ascii.h asciitab.h expat.dsp expat.h.in iasciitab.h latin1tab.h nametab.h utf8tab.h winconfig.h xmlparse.c xmlrole.c xmlrole.h xmltok.c xmltok.h xmltok_impl.c xmltok_impl.h xmltok_ns.c

2001-02-28 Thread Greg Stein
On Wed, Feb 28, 2001 at 02:51:13PM -0600, Sam TH wrote: On Wed, Feb 28, 2001 at 02:41:32PM -, [EMAIL PROTECTED] wrote: Local changes and modifications were applied. See README.APRUTIL And where might one find such a file? I haven't written it yet :-) I just wanted that comment in the

Re: cvs commit: apr-util/buckets apr_brigade.c

2001-02-28 Thread Greg Stein
On Wed, Feb 28, 2001 at 11:46:39AM -0500, Cliff Woolley wrote: ... HUGE_STRING_LEN comes from apr_lib.h, not from within aprutil, and other parts of APR (and maybe Apache, too) are using it. It ought to be namespace protected (APR_HUGE_STRING_LEN) (don't I remember past discussion about

Re: autoconf and Gnu m4... a matched set?

2001-02-28 Thread Greg Stein
On Wed, Feb 28, 2001 at 02:46:32PM -0500, Jeff Trawick wrote: Jim Jagielski [EMAIL PROTECTED] writes: According to the autoconf docs: Autoconf requires GNU `m4' in order to generate the scripts. It uses features that some UNIX versions of `m4' do not have. It also

Re: APR_HAVE_SOAPBOX

2001-02-28 Thread Greg Stein
Oversight on my part. We specified the symbol name in configure.in, so I slapped the APR_ prefix on there. (the HAVE_ symbols come from autoconf, so we can't do much about it) How about APR_USING_OLD_EXPAT? I'm not comfy with the APR_HAS_ approach because we aren't advertising the symbol, so we

Re: Bucket API cleanup issues

2001-02-28 Thread Greg Stein
On Wed, Feb 28, 2001 at 03:03:08PM -0500, Cliff Woolley wrote: ... Basically, instead of having the pool bucket contain a pointer to a heap bucket and having to fool with manipulating reference counts and keeping track of when to destroy the old apr_bucket_pool struct, the apr_bucket_pool

Re: [PATCH] fix cause of some of the heap corruption seen in Apache?

2001-02-28 Thread rbb
This is a definate bug. Neither of these bucket types should call free. Please commit this ASAP. I would bet this is the cause of our corruption on Apache.org. Ryan On Wed, 28 Feb 2001, Jeff Trawick wrote: For an immortal bucket, the data is typically a non-writeable string. But we do a

Re: [PATCH] fix cause of some of the heap corruption seen in Apache?

2001-02-28 Thread Greg Stein
On Wed, Feb 28, 2001 at 03:43:45PM -0800, [EMAIL PROTECTED] wrote: This is a definate bug. Neither of these bucket types should call free. Please commit this ASAP. I would bet this is the cause of our corruption on Apache.org. Only if you built apache.org's server in the last 24 hours. The