Re: inetd-type architecture?

2001-06-20 Thread Michael Tokarev
Luke Kenneth Casson Leighton wrote: > [] > srvsvcd's job is also to handle the dependencies for service startup. > > we could look at the linux kernel 'Calculating module dependencies' > code to get an algorithm to work out the startup order. Why, why, why this is needed Why not to use runt

Re: apr_strcat optimization(s)

2001-06-20 Thread Ben Laurie
Jeff Trawick wrote: > > Ben Laurie <[EMAIL PROTECTED]> writes: > > > > -*cp = '\0'; > > > +*(cp + len) = '\0'; > > > > Err, cp[len]='\0', perlease! > > Let's make a deal. You rewire yourself to "fix" the > > rettype function(parms) > { > decl; > > code; > } > > thang

[PATCH] Some named pipe hacking...

2001-06-20 Thread Bill Stoddard
This is NOT ready to be committed and in fact it may be a complete waste of time. I had a few minutes to hack around a couple of days back and came up with this. I did not even attempt to compile the unix implementation of ap_file_namedpipe_create() much less run it. The Windows implementation

Re: apr_strcat optimization(s)

2001-06-20 Thread Bill Stoddard
+1 :-) > Ben Laurie <[EMAIL PROTECTED]> writes: > > > > -*cp = '\0'; > > > +*(cp + len) = '\0'; > > > > Err, cp[len]='\0', perlease! > > Let's make a deal. You rewire yourself to "fix" the > > rettype function(parms) > { > decl; > > code; > } > > thang and I'll consi

Re: apr_strcat optimization(s)

2001-06-20 Thread Jeff Trawick
Ben Laurie <[EMAIL PROTECTED]> writes: > > -*cp = '\0'; > > +*(cp + len) = '\0'; > > Err, cp[len]='\0', perlease! Let's make a deal. You rewire yourself to "fix" the rettype function(parms) { decl; code; } thang and I'll consider using array notation in code like that

Re: apr_strcat optimization(s)

2001-06-20 Thread Ben Laurie
Doug MacEachern wrote: > > On Wed, 20 Jun 2001, Ben Laurie wrote: > > > Err, cp[len]='\0', perlease! > > ok. > > > Its probably worth a fraction of a microsecond (or more) to put this at > > the end, btw. > > at the end, like this? interested, how is it faster? Because of caching - the right

Re: apr_strcat optimization(s)

2001-06-20 Thread Doug MacEachern
On Wed, 20 Jun 2001, Ben Laurie wrote: > Err, cp[len]='\0', perlease! ok. > Its probably worth a fraction of a microsecond (or more) to put this at > the end, btw. at the end, like this? interested, how is it faster? --- srclib/apr/strings/apr_strings.c2001/06/19 20:40:22 1.14 +++ s

Re: More migration of code from httpd to apr-util

2001-06-20 Thread William A. Rowe, Jr.
From: "Luke Kenneth Casson Leighton" <[EMAIL PROTECTED]> Sent: Wednesday, June 20, 2001 8:55 AM > > You miss my point. We at _least_ need to return a "Windows Acceptable Pipe > > Name", instead > > of some /PIPE/pluming style name. > > it is *important* that NT-style conventions are followed.

Re: apr_strcat optimization(s)

2001-06-20 Thread Ben Laurie
Doug MacEachern wrote: > > On 19 Jun 2001, Jeff Trawick wrote: > > > cp doesn't point to the end of the string to be built yet. If you had > > > > *(cp + len) = '\0'; > > > > then I'd believe you. > > oh right, here is the current patch.. > > --- srclib/apr/strings/apr_strings.c2001/05/1

Re: More migration of code from httpd to apr-util

2001-06-20 Thread Luke Kenneth Casson Leighton
> You miss my point. We at _least_ need to return a "Windows Acceptable Pipe > Name", instead > of some /PIPE/pluming style name. it is *important* that NT-style conventions are followed. the 'guiding light' *must* be the NT functions. i know that most of you may find this difficult to accept

fwd: [Core-Dev] for future reference: secure cvs

2001-06-20 Thread Luke Kenneth Casson Leighton
this may be of interest to people, so i'm fowarding it here, from joe little. I saw this today and wanted to post it here for future reference. It is likely of great interest to the members here... http://www.idealx.org/en/doc/chrooted-ssh-cvs-server/chrooted-ssh-cvs-server_monobloc.html This Ho

Re: inetd-type architecture?

2001-06-20 Thread Luke Kenneth Casson Leighton
[this message, which originated from [EMAIL PROTECTED], is cross-posted from apr dev and samba tech. the relevance to apr dev is the issues / justification of creating an apr NamedPipe interface - exactly mirroring the NT NamedPipe one _not_ the unix namedpipe one. luke] On Wed, Jun 20, 2001 at

Re: APR file_io/win32/readwrite.c

2001-06-20 Thread Cliff Woolley
On Tue, 19 Jun 2001, William A. Rowe, Jr. wrote: > > I guess MSVC doesn't warn about such things?? Beats the hell out of me. > > Obviously we'd have seen it in a gcc warning if it were on the Unix > > side... > > It's a level 4 (think -wall) warning on my msvc5. I try building at > least once a

Re: APR file_io/win32/readwrite.c

2001-06-20 Thread William A. Rowe, Jr.
From: "Cliff Woolley" <[EMAIL PROTECTED]> Sent: Tuesday, June 19, 2001 7:57 PM > On Tue, 19 Jun 2001, Roy T. Fielding wrote: > > > On Tue, Jun 19, 2001 at 08:30:13PM -0400, Cliff Woolley wrote: > > > In the following lines from readwrite.c line 90, should the if() > > > conditional clause really

more mmap_setaside()

2001-06-20 Thread Cliff Woolley
Should mmap_setaside() really be copying the data into a pool? That means that, for example, that things like the content_length filter could easily end up reading in a really big file in its entirety to r->pool, AFAICT. The only thing that the apr_mmap_t seems to need the pool for is its own all

Re: [PATCH] bucket type "capabilities" flags

2001-06-20 Thread rbb
> > At this point, you are trying to second guess the bucket type. If the > > bucket doesn't implement setaside, then it doesn't need setaside. > > That's not true... it it doesn't need setaside, it will use > apr_bucket_setaside_noop() [which counts as an implementation for flag > purposes]; apr

Re: APR file_io/win32/readwrite.c

2001-06-20 Thread Cliff Woolley
On Tue, 19 Jun 2001, Roy T. Fielding wrote: > On Tue, Jun 19, 2001 at 08:30:13PM -0400, Cliff Woolley wrote: > > In the following lines from readwrite.c line 90, should the if() > > conditional clause really be an assignment, or is it a typo? It really > > seems like it should be an equality test

Re: APR file_io/win32/readwrite.c

2001-06-20 Thread Roy T. Fielding
On Tue, Jun 19, 2001 at 08:30:13PM -0400, Cliff Woolley wrote: > In the following lines from readwrite.c line 90, should the if() > conditional clause really be an assignment, or is it a typo? It really > seems like it should be an equality test to me... > > rv = apr_get_os_error(

APR file_io/win32/readwrite.c

2001-06-20 Thread Cliff Woolley
In the following lines from readwrite.c line 90, should the if() conditional clause really be an assignment, or is it a typo? It really seems like it should be an equality test to me... rv = apr_get_os_error(); if (rv = APR_FROM_OS_ERROR(ERROR_BROKEN_PIPE))

Re: [PATCH] bucket type "capabilities" flags

2001-06-20 Thread Cliff Woolley
On Tue, 19 Jun 2001 [EMAIL PROTECTED] wrote: > At this point, you are trying to second guess the bucket type. If the > bucket doesn't implement setaside, then it doesn't need setaside. That's not true... it it doesn't need setaside, it will use apr_bucket_setaside_noop() [which counts as an impl