Re: renaming apr_filetype enum entries

2004-09-19 Thread Greg Stein
On Fri, Sep 17, 2004 at 07:54:10PM -0400, Stas Bekman wrote: As discussed back in June enum names in the apr_filetype_e entry are polluting the APR_ defines namespace and it's hard to grok what APR_REG means when it's used in the code. I've finally started to work on these as I'm finishing

Bug report for APR [2004/09/19]

2004-09-19 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Re: renaming apr_file_permissions defines

2004-09-19 Thread Greg Stein
On Fri, Sep 17, 2004 at 09:21:17PM -0500, William A. Rowe, Jr. wrote: At 07:53 PM 9/17/2004, you wrote: and the rename of apr_file_permissions group: s/APR_/APR_FILEPROT_/ Veto - defer for 2.0 There is no reason to wait until 2.0. The versioning guidelines allow us to provide new symbolic

Some pending pathches for review/commit

2004-09-19 Thread Mladen Turk
Hi, Trying for a third week :). I've posted couple of patches for apr that seems to be lost somewhere. There has been some discussion on some of them, so I'm sending them all at once with brief explanation for each. 1. test_makefile_win.patch The apr/test/Makefile.win is missing a target to build

Re: Some pending pathches for review/commit

2004-09-19 Thread Graham Leggett
Mladen Turk wrote: Trying for a third week :). I've posted couple of patches for apr that seems to be lost somewhere. There has been some discussion on some of them, so I'm sending them all at once with brief explanation for each. I assume the silence represents a lack of disagreement :) I will

Re: Some pending pathches for review/commit

2004-09-19 Thread Max Khon
Hi! On Sun, Sep 19, 2004 at 05:47:48PM +0200, Mladen Turk wrote: APR_DECLARE(apr_status_t) apr_thread_join(apr_status_t *retval, apr_thread_t *thd) { -apr_status_t rv; - +apr_status_t rv = APR_SUCCESS; + +if (!thd-td) { +

Re: renaming apr_file_permissions defines

2004-09-19 Thread William A. Rowe, Jr.
At 09:15 AM 9/19/2004, Greg Stein wrote: On Fri, Sep 17, 2004 at 09:21:17PM -0500, William A. Rowe, Jr. wrote: At 07:53 PM 9/17/2004, you wrote: and the rename of apr_file_permissions group: s/APR_/APR_FILEPROT_/ Veto - defer for 2.0 There is no reason to wait until 2.0. The versioning

Re: Some pending pathches for review/commit

2004-09-19 Thread William A. Rowe, Jr.
At 10:47 AM 9/19/2004, Mladen Turk wrote: Trying for a third week :). Keep trying :) Several project releases distracted a number of users of this list... so I'm sending them all at once with brief explanation for each. Actually, it inhibits discussion to do that :( I would like to see Ben

Re: renaming apr_file_permissions defines

2004-09-19 Thread Mladen Turk
William A. Rowe, Jr. wrote: Trying for a third week :) . Keep trying :) Several project releases distracted a number of users of this list... Don't worry, someone said that Croats are pretty stubborn :) . For your 1. and 3. and 4. they are fine, simply commit them, +1 to fix in both head

Re: renaming apr_filetype enum entries

2004-09-19 Thread Stas Bekman
Greg Stein wrote: On Fri, Sep 17, 2004 at 07:54:10PM -0400, Stas Bekman wrote: As discussed back in June enum names in the apr_filetype_e entry are polluting the APR_ defines namespace and it's hard to grok what APR_REG means when it's used in the code. I've finally started to work on these as

Re: renaming apr_filetype enum entries

2004-09-19 Thread Greg Stein
On Sun, Sep 19, 2004 at 05:20:59PM -0400, Stas Bekman wrote: Greg Stein wrote: ... And the #ifndef wrappers are not needed. Just define the old names in terms of the new. yes, yes, inside apr they won't be needed. They will be needed inside projects supporting more than one apr generation.

Re: renaming apr_filetype enum entries

2004-09-19 Thread Stas Bekman
Greg Stein wrote: On Sun, Sep 19, 2004 at 05:20:59PM -0400, Stas Bekman wrote: Greg Stein wrote: ... And the #ifndef wrappers are not needed. Just define the old names in terms of the new. yes, yes, inside apr they won't be needed. They will be needed inside projects supporting more than one apr

Re: renaming apr_file_open_flags group defines

2004-09-19 Thread Stas Bekman
William A. Rowe, Jr. wrote: At 08:34 PM 9/17/2004, you wrote: This group wasn't discussed before, but it suffers from the same problem. #define APR_READ 0x1 /** Open the file for reading */ #define APR_WRITE 0x2 /** Open the file for writing */ #define APR_CREATE