Re: [PATCH] add APR_SENDFILE_AUTODETECT programming interface

2005-03-18 Thread Justin Erenkrantz
--On Friday, March 18, 2005 1:54 PM -0500 Jeff Trawick <[EMAIL PROTECTED]> wrote: Applications turn on this flag if they want to avoid any sendfile bogosity, which can be triggered based on hardware or software or configuration. Looks fine to me. Thanks! Alternate strategy: APR internally implem

Re: do we still want sendfile enabled with our default conf files?

2005-03-18 Thread Brian Akins
Justin Erenkrantz wrote: --On Friday, March 18, 2005 5:18 PM + Colm MacCarthaigh <[EMAIL PROTECTED]> wrote: One fstatfs call will allow us to detect the FS issues we've seen: either blacklist or whitelist fstypes per OS, I don't much care. And, we can check for IPv6 sockets on Linux. As

[PATCH] add APR_SENDFILE_AUTODETECT programming interface

2005-03-18 Thread Jeff Trawick
Applications turn on this flag if they want to avoid any sendfile bogosity, which can be triggered based on hardware or software or configuration. AFAIK, Solaris and z/OS are the only platforms that have no sendfile concerns which the current APR code doesn't already handle, so for non-{Solaris, z

Re: do we still want sendfile enabled with our default conf files?

2005-03-18 Thread Justin Erenkrantz
--On Friday, March 18, 2005 5:18 PM + Colm MacCarthaigh <[EMAIL PROTECTED]> wrote: I think it's just one of those cases where it would be highly non-trivial and inefficient to put all of the checks in APR, simply due to the real-world nature of the bugs, but that at the same time there is a c

Re: do we still want sendfile enabled with our default conf files?

2005-03-18 Thread Colm MacCarthaigh
On Fri, Mar 18, 2005 at 09:00:59AM -0800, Justin Erenkrantz wrote: > --On Friday, March 18, 2005 4:34 PM + Colm MacCarthaigh > <[EMAIL PROTECTED]> wrote: > > >In my experience, more users are brain-dead than OS's ;) Surely it's the > >users who don't have a hope of diagnosing the kinds of int

Re: do we still want sendfile enabled with our default conf files?

2005-03-18 Thread Ryan Bloom
I didn't dig into the problems that I was seeing on Linux, but I know that it was IPv4. I don't know the filesystem, but I can find out. I assumed it was the mutli-threaded aspect that was causing the trouble, but that was really just a guess. Ryan On Fri, 18 Mar 2005 09:00:26 -0800, Justin Er

Re: do we still want sendfile enabled with our default conf files?

2005-03-18 Thread Jim Jagielski
Justin Erenkrantz wrote: > > > I tend to prefer Jeff's solution of having APR return APR_ENOTIMPL when the > APR_SENDFILE_AUTODETECT flag is set and we'd fail. I'm ambivalent if we > decide to have apr_socket_sendfile() internally call emulate_sendfile because > apr_socket_sendfile() has alwa

Re: do we still want sendfile enabled with our default conf files?

2005-03-18 Thread Justin Erenkrantz
--On Friday, March 18, 2005 4:34 PM + Colm MacCarthaigh <[EMAIL PROTECTED]> wrote: In my experience, more users are brain-dead than OS's ;) Surely it's the users who don't have a hope of diagnosing the kinds of intermittent problems that using sendfile can trigger who should be kept in mind?

Re: do we still want sendfile enabled with our default conf files?

2005-03-18 Thread Justin Erenkrantz
--On Friday, March 18, 2005 11:27 AM -0500 Ryan Bloom <[EMAIL PROTECTED]> wrote: That's fine. Pay attention to what I suggested. Default to non-native sendfile, until we have know that it works. If you have an OS that you know for a fact does sendfile correctly, then that would be a case where w

APR_EOF on apr_read_full

2005-03-18 Thread Sebastian Morawietz
Hello, I just started using the APR for the File-IO Part of a CGI-Application that I'm working on. I'm dealing with a couple of processes performing read/write accesses on files concurrently, where the reading process locks the file by using APR_FLOCK_SHARED and the writing process uses APR_FLOCK

Re: do we still want sendfile enabled with our default conf files?

2005-03-18 Thread Greg Marr
At 11:23 AM 3/18/2005, Justin Erenkrantz wrote: I absolutely refuse to punish users who are using good OSes because some OSes are brain-dead. This is exactly the role that APR is meant to fill Feel free to advocate Linux always returning APR_ENOTIMPL for sendfile - I don't care. However, bloc

Re: do we still want sendfile enabled with our default conf files?

2005-03-18 Thread Colm MacCarthaigh
On Fri, Mar 18, 2005 at 08:23:18AM -0800, Justin Erenkrantz wrote: > I absolutely refuse to punish users who are using good OSes because some > OSes are brain-dead. In my experience, more users are brain-dead than OS's ;) Surely it's the users who don't have a hope of diagnosing the kinds of inte

Re: do we still want sendfile enabled with our default conf files?

2005-03-18 Thread Ryan Bloom
That's fine. Pay attention to what I suggested. Default to non-native sendfile, until we have know that it works. If you have an OS that you know for a fact does sendfile correctly, then that would be a case where we know that it works. Instead of #ifndef LINUX|WIN32|AIX|HPUX sendfile(

Re: do we still want sendfile enabled with our default conf files?

2005-03-18 Thread Justin Erenkrantz
--On Friday, March 18, 2005 11:12 AM -0500 Ryan Bloom <[EMAIL PROTECTED]> wrote: funny, I took the list of exceptions to be so large and hard to maintain that it made more sense to go with Jeff's original idea of just disabling sendfile by default unless a user specifically decided to enable it. I

Re: do we still want sendfile enabled with our default conf files?

2005-03-18 Thread Bill Stoddard
Cliff Woolley wrote: On Fri, 18 Mar 2005, Ryan Bloom wrote: disabling sendfile solved it immediately. Seems to me that until our sendfile support is better, we should err on the side of always sending the data correctly instead of absolutely as fast as possible. I would much rather have APR defau

Re: do we still want sendfile enabled with our default conf files?

2005-03-18 Thread Cliff Woolley
On Fri, 18 Mar 2005, Ryan Bloom wrote: > disabling sendfile solved it immediately. Seems to me that until our > sendfile support is better, we should err on the side of always > sending the data correctly instead of absolutely as fast as possible. > > I would much rather have APR default to not u

Re: do we still want sendfile enabled with our default conf files?

2005-03-18 Thread Ryan Bloom
funny, I took the list of exceptions to be so large and hard to maintain that it made more sense to go with Jeff's original idea of just disabling sendfile by default unless a user specifically decided to enable it. I just had to debug a problem for a friend with sendfile on Linux. I don't know w

Re: do we still want sendfile enabled with our default conf files?

2005-03-18 Thread Justin Erenkrantz
--On Friday, March 18, 2005 5:59 AM -0500 Jeff Trawick <[EMAIL PROTECTED]> wrote: ...snip, snip... AIX: Doesn't really fail in the normal sense of not putting the right data on the wire, but can trigger a kernel memory issue if some kernel tuning is incorrect. So always fail if the APR_SENDFILE_

Inheriting socket descriptor ...

2005-03-18 Thread Damir Dezeljin
Hi. I'm trying to write a simple inetd daemon using APR. So I need to open a socket, accept a connection and pass the connection socket to the child process that is spawned with e.g. apr_proc_create(). I know how can this be done using Linux API, however I would like to do it with APR. It seams

Re: do we still want sendfile enabled with our default conf files?

2005-03-18 Thread Jeff Trawick
On Thu, 17 Mar 2005 17:33:31 -0800, Justin Erenkrantz <[EMAIL PROTECTED]> wrote: > A solution that disables sendfile for OSes that do not have these sendfile > issues (say *BSD and Solaris) are going to get my veto. If we need to do some > platform/run-time detection to identify those platforms th

Re: Hold horses, 1.1.1 solution

2005-03-18 Thread Curt Arnold
On Mar 17, 2005, at 4:14 PM, William A. Rowe, Jr. wrote: On the surface, Curt's solution would break our compatibility rules. But I think we can deviate in this instance; the modules in iconv/*.so are compiled by the apr-iconv project itself. If we change both apr-iconv and its modules to now