Re: [VOTE] Release apr-util 1.4.0

2011-12-06 Thread Graham Leggett
On 06 Dec 2011, at 3:23 AM, Graham Leggett wrote: [ X ] Release apr-util 1.4.0 as GA +1. Build clean and all tests pass on Centos6, FC17, and MacOSX 10.6. Regards, Graham --

Re: APR hash vs httpd implementation

2011-12-06 Thread Graham Leggett
On 05 Dec 2011, at 8:52 PM, sridhar basam wrote: Anyone know why the mod_cache code has an almost identical implementation of the apr_hash* functions? Seems like the only difference is that the mod_cache implementation isn't using APR pools and has a fixed size table. Are there any

[PATCH] charclass matching and input check for fnmatch

2011-12-06 Thread Stefan Sperling
The patch below adds character class matching to fnmatch. This code was originally written for OpenBSD by Todd C. Miller. It also adds a sanity check on the input size which was suggested by Miod Vallat. fnmatch(3) is used to match path names so patterns or strings longer than PATH_MAX don't need

Re: [PATCH] charclass matching and input check for fnmatch

2011-12-06 Thread Stefan Sperling
On Tue, Dec 06, 2011 at 01:36:30PM +0100, Stefan Sperling wrote: It is likely that we'll apply some intending changes on the OpenBSD side. I meant of course *indentation* changes :)

Re: [VOTE] Release apr-util 1.4.0

2011-12-06 Thread Mladen Turk
On 12/06/2011 02:23 AM, Graham Leggett wrote: Tarballs/zipballs are at http://apr.apache.org/dev/dist/. +/-1 [+1] Release apr-util 1.4.0 as GA Signatures OK Tested on Linux and Winows Regards -- ^TM

Re: [VOTE] Release apr-util 1.4.0

2011-12-06 Thread Jim Jagielski
+1: Fed14, CentOS 56, OSX 10.7 (Xcode 4.2.1) On Dec 5, 2011, at 8:23 PM, Graham Leggett wrote: Hi all, Tarballs/zipballs are at http://apr.apache.org/dev/dist/. New in apr-util v1.4 is the apr_crypto interface, and a fix for LDAP on Solaris. Full CHANGES are here:

Re: [PATCH] charclass matching and input check for fnmatch

2011-12-06 Thread William A. Rowe Jr.
On 12/6/2011 4:50 AM, Stefan Sperling wrote: On Tue, Dec 06, 2011 at 01:36:30PM +0100, Stefan Sperling wrote: It is likely that we'll apply some intending changes on the OpenBSD side. I meant of course *indentation* changes :) The issue is that apr has its own style guide. Organization,

Re: [PATCH] charclass matching and input check for fnmatch

2011-12-06 Thread William A. Rowe Jr.
On 12/6/2011 4:36 AM, Stefan Sperling wrote: @@ -207,6 +274,10 @@ APR_DECLARE(int) apr_fnmatch(const char *pattern, const char *mismatch = NULL; int matchlen = 0; +if (strnlen(pattern, APR_PATH_MAX) == APR_PATH_MAX || +strnlen(string, APR_PATH_MAX) == APR_PATH_MAX) +

Re: [VOTE] Release apr-util 1.4.0

2011-12-06 Thread Igor Galić
- Original Message - Hi all, Tarballs/zipballs are at http://apr.apache.org/dev/dist/. New in apr-util v1.4 is the apr_crypto interface, and a fix for LDAP on Solaris. Full CHANGES are here: https://svn.apache.org/repos/asf/apr/apr-util/tags/1.4.0/CHANGES Signatures look good.

Re: [VOTE] Release apr-util 1.4.0

2011-12-06 Thread Gregg L. Smith
-0.5 non-binding of course Seems the purpose was to get apr_crypto. On Windows it's not built, even with APU_HAVE_CRYPTO set to 1 since apr_crypto.c is not included in the project for either static lib or dll. Once that is done, I'm getting this; Compiling... apr_crypto.c

Re: [VOTE] Release apr-util 1.4.0

2011-12-06 Thread Mladen Turk
On 12/06/2011 01:57 PM, Mladen Turk wrote: On 12/06/2011 02:23 AM, Graham Leggett wrote: Tarballs/zipballs are at http://apr.apache.org/dev/dist/. +/-1 [+1] Release apr-util 1.4.0 as GA Signatures OK Tested on Linux and Winows I'm changing my vote to -1 since windows crypto API is

Re: [VOTE] Release apr-util 1.4.0

2011-12-06 Thread Igor Galić
- Original Message - -0.5 non-binding of course Seems the purpose was to get apr_crypto. On Windows it's not built, even with APU_HAVE_CRYPTO set to 1 since apr_crypto.c is not included in the project for either static lib or dll. Once that is done, I'm getting this;

Re: [VOTE] Release apr-util 1.4.0

2011-12-06 Thread Mladen Turk
On 12/07/2011 12:39 AM, Igor Galić wrote: - Original Message - -0.5 non-binding of course Seems the purpose was to get apr_crypto. On Windows it's not built, even with APU_HAVE_CRYPTO set to 1 since apr_crypto.c is not included in the project for either static lib or dll. Once that