Win32 apr-util's crypto, cprypto_nss and crypto_openssl now works

2011-12-07 Thread Mladen Turk
Hi, Fixed the 1.4.x branch win32 crypto API and modules (Mostly by adding missing build files and one API bug) They can now compile using Mozilla's xulrunner SDK and any OpenSSSL SDK. We could reconsider re-tagging 1.4.0 (or just making 1.4.1) Regards -- ^TM

Re: Win32 apr-util's crypto, cprypto_nss and crypto_openssl now works

2011-12-07 Thread Graham Leggett
On 7 Dec 2011, at 08:58, Mladen Turk mt...@apache.org wrote: Fixed the 1.4.x branch win32 crypto API and modules (Mostly by adding missing build files and one API bug) They can now compile using Mozilla's xulrunner SDK and any OpenSSSL SDK. We could reconsider re-tagging 1.4.0 (or just

Re: Win32 apr-util's crypto, cprypto_nss and crypto_openssl now works

2011-12-07 Thread Jeff Trawick
On Wed, Dec 7, 2011 at 6:11 AM, Graham Leggett minf...@sharp.fm wrote: On 7 Dec 2011, at 08:58, Mladen Turk mt...@apache.org wrote: Fixed the 1.4.x branch win32 crypto API and modules (Mostly by adding missing build files and one API bug) They can now compile using Mozilla's xulrunner SDK and

Re: Win32 apr-util's crypto, cprypto_nss and crypto_openssl now works

2011-12-07 Thread Stefan Fritsch
On Wed, 7 Dec 2011, Graham Leggett wrote: On 7 Dec 2011, at 08:58, Mladen Turk mt...@apache.org wrote: Fixed the 1.4.x branch win32 crypto API and modules (Mostly by adding missing build files and one API bug) They can now compile using Mozilla's xulrunner SDK and any OpenSSSL SDK. We could

Re: [VOTE] Release apr-util 1.4.0

2011-12-07 Thread Jeff Trawick
On Mon, Dec 5, 2011 at 8:23 PM, Graham Leggett minf...@sharp.fm wrote: Hi all, Tarballs/zipballs are at http://apr.apache.org/dev/dist/. New in apr-util v1.4 is the apr_crypto interface, and a fix for LDAP on Solaris. Full CHANGES are here:

Re: [VOTE] Release apr-util 1.4.0

2011-12-07 Thread Graham Leggett
On 07 Dec 2011, at 7:10 PM, Jeff Trawick wrote: stuff to consider before 1.4.1 different autotools versions compared with 1.3.12? (not always a problem, but could lead to unintended glitches???) I've been using autoconf 2.64 and libtool 1.5.26 The autotools used are the defaults that

Re: [VOTE] Release apr-util 1.4.0

2011-12-07 Thread Jeff Trawick
On Wed, Dec 7, 2011 at 12:22 PM, Graham Leggett minf...@sharp.fm wrote: On 07 Dec 2011, at 7:10 PM, Jeff Trawick wrote: stuff to consider before 1.4.1 different autotools versions compared with 1.3.12?  (not always a problem, but could lead to unintended glitches???) I've been using

Re: [VOTE] Release apr-util 1.4.0

2011-12-07 Thread Graham Leggett
On 07 Dec 2011, at 7:32 PM, Jeff Trawick wrote: Using the same autoconf and libtool as before should cost you less than 10 minutes, it makes it trivial to review more of the proposed tarball, and it essentially guarantees no regressions in certain aspects of the release. What could be

Re: [VOTE] Release apr-util 1.4.0

2011-12-07 Thread Jeff Trawick
On Wed, Dec 7, 2011 at 12:56 PM, Graham Leggett minf...@sharp.fm wrote: On 07 Dec 2011, at 7:32 PM, Jeff Trawick wrote: Using the same autoconf and libtool as before should cost you less than 10 minutes, it makes it trivial to review more of the proposed tarball, and it essentially guarantees

Re: svn commit: r1211334 - in /apr/apr-util/branches/1.4.x/crypto: apr_crypto_nss.c apr_crypto_nss.dsp

2011-12-07 Thread Roy T. Fielding
Just to confirm, this only gets compiled if the user has added a --with option specific to nss, right? Otherwise it impacts our license. Roy On Dec 7, 2011, at 12:38 AM, mt...@apache.org wrote: Author: mturk Date: Wed Dec 7 08:38:54 2011 New Revision: 1211334 URL:

Re: Win32 apr-util's crypto, cprypto_nss and crypto_openssl now works

2011-12-07 Thread Stefan Fritsch
On Wednesday 07 December 2011, Graham Leggett wrote: On 7 Dec 2011, at 13:54, Stefan Fritsch s...@sfritsch.de wrote: I've got a report that apr-util/ldap 1.3.12 does not build on Debian unstable currently, presumably due to toolchain changes. If you wait another 6 hours or so, I could check

Re: svn commit: r1211334 - in /apr/apr-util/branches/1.4.x/crypto: apr_crypto_nss.c apr_crypto_nss.dsp

2011-12-07 Thread Graham Leggett
On 07 Dec 2011, at 8:17 PM, Roy T. Fielding wrote: Just to confirm, this only gets compiled if the user has added a --with option specific to nss, right? Otherwise it impacts our license. Can't speak for Windows, but for Unix, yes. Without --with-crypto and --with-crypto-nss, the default is

Re: svn commit: r1211334 - in /apr/apr-util/branches/1.4.x/crypto: apr_crypto_nss.c apr_crypto_nss.dsp

2011-12-07 Thread Mladen Turk
On 12/07/2011 07:17 PM, Roy T. Fielding wrote: Just to confirm, this only gets compiled if the user has added a --with option specific to nss, right? Otherwise it impacts our license. Actually it's editing apu.hw and setting APU_HAVE_CRYPTO to 1, and then nmake -f Makefile.win

Re: [VOTE] Release apr-util 1.4.0

2011-12-07 Thread Graham Leggett
On 07 Dec 2011, at 8:17 PM, Jeff Trawick wrote: The People build APR part is irrelevant. The versions of autoconf and libtool used so far are anything but arbitrary. They are known to work for APR users on a variety of platforms. You're throwing away fixes we have been shipping with for

Re: [VOTE] Release apr-util 1.4.0

2011-12-07 Thread Jeff Trawick
On Wed, Dec 7, 2011 at 2:27 PM, Graham Leggett minf...@sharp.fm wrote: On 07 Dec 2011, at 8:17 PM, Jeff Trawick wrote: The People build APR part is irrelevant.  The versions of autoconf and libtool used so far are anything but arbitrary.  They are known to work for APR users on a variety of

Re: svn commit: r1211334 - in /apr/apr-util/branches/1.4.x/crypto: apr_crypto_nss.c apr_crypto_nss.dsp

2011-12-07 Thread William A. Rowe Jr.
On 12/7/2011 10:54 AM, Mladen Turk wrote: On 12/07/2011 07:17 PM, Roy T. Fielding wrote: Just to confirm, this only gets compiled if the user has added a --with option specific to nss, right? Otherwise it impacts our license. Actually it's editing apu.hw and setting APU_HAVE_CRYPTO to 1,

Re: [VOTE] Release apr-util 1.4.0

2011-12-07 Thread William A. Rowe Jr.
On 12/7/2011 9:22 AM, Graham Leggett wrote: I am far more comfortable choosing a set of autotools shipped with and supported by a major distribution than trying to cook up my own combination - Redhat have already found an option that works, and if it isn't broken, I don't believe we

Re: [PATCH] charclass matching and input check for fnmatch

2011-12-07 Thread Stefan Sperling
On Tue, Dec 06, 2011 at 12:48:26PM -0800, William A. Rowe Jr. wrote: On 12/6/2011 4:36 AM, Stefan Sperling wrote: @@ -207,6 +274,10 @@ APR_DECLARE(int) apr_fnmatch(const char *pattern, const char *mismatch = NULL; int matchlen = 0; +if (strnlen(pattern, APR_PATH_MAX) ==

Re: [VOTE] Release apr-util 1.4.0

2011-12-07 Thread Rainer Jung
On 07.12.2011 18:10, Jeff Trawick wrote: On Mon, Dec 5, 2011 at 8:23 PM, Graham Leggettminf...@sharp.fm wrote: diff -ru apr-util-1.3.12/build/config.guess apr-util-1.4.0/build/config.guess config.guess is not an autotool. apr-util buildconf should copy the file in from the apr against

Re: [VOTE] Release apr-util 1.4.0

2011-12-07 Thread Jeff Trawick
On Wed, Dec 7, 2011 at 5:29 PM, Rainer Jung rainer.j...@kippdata.de wrote: On 07.12.2011 18:10, Jeff Trawick wrote: On Mon, Dec 5, 2011 at 8:23 PM, Graham Leggettminf...@sharp.fm  wrote: diff -ru apr-util-1.3.12/build/config.guess apr-util-1.4.0/build/config.guess config.guess is not an

Re: [VOTE] Release apr-util 1.4.0

2011-12-07 Thread Graham Leggett
On 08 Dec 2011, at 12:56 AM, Jeff Trawick wrote: There's a parameter on release.sh which gets passed to apr-util buildconf. If it is not passed to release.sh it looks like it will look in ../apr. As it is not coming from the autotools, I guess Graham would have to look for where it might

Re: [VOTE] Release apr-util 1.4.0

2011-12-07 Thread Rainer Jung
On 07.12.2011 23:56, Jeff Trawick wrote: On Wed, Dec 7, 2011 at 5:29 PM, Rainer Jungrainer.j...@kippdata.de wrote: On 07.12.2011 18:10, Jeff Trawick wrote: On Mon, Dec 5, 2011 at 8:23 PM, Graham Leggettminf...@sharp.fmwrote: diff -ru apr-util-1.3.12/build/config.guess

Re: svn commit: r1211688 - /apr/apr-util/tags/1.4.1/

2011-12-07 Thread Graham Leggett
On 08 Dec 2011, at 1:07 AM, Jeff Trawick wrote: On Wed, Dec 7, 2011 at 5:52 PM, minf...@apache.org wrote: Author: minfrin Date: Wed Dec 7 22:52:27 2011 New Revision: 1211688 URL: http://svn.apache.org/viewvc?rev=1211688view=rev Log: Tag v1.4.1. Added: apr/apr-util/tags/1.4.1/

Re: svn commit: r1211688 - /apr/apr-util/tags/1.4.1/

2011-12-07 Thread Igor Galić
Tagging was done like this: svn copy https://svn.apache.org/repos/asf/apr/apr-util/branches/1.4.x https://svn.apache.org/repos/asf/apr/apr-util/tags/1.4.1 /me does^Wwould've done svn cp ^/apr/apr-util/branches/1.4.x/ ^/apr/apr-util/tags/1.4.1 Regards, Graham -- i -- Igor Galić

Re: [VOTE] Release apr-util 1.4.0

2011-12-07 Thread Jeff Trawick
On Wed, Dec 7, 2011 at 6:08 PM, Graham Leggett minf...@sharp.fm wrote: On 08 Dec 2011, at 12:56 AM, Jeff Trawick wrote: There's a parameter on release.sh which gets passed to apr-util buildconf.  If it is not passed to release.sh it looks like it will look in ../apr. As it is not coming

Re: svn commit: r1211688 - /apr/apr-util/tags/1.4.1/

2011-12-07 Thread Jeff Trawick
2011/12/7 Igor Galić i.ga...@brainsware.org: Tagging was done like this: svn copy https://svn.apache.org/repos/asf/apr/apr-util/branches/1.4.x https://svn.apache.org/repos/asf/apr/apr-util/tags/1.4.1 /me does^Wwould've done   svn cp ^/apr/apr-util/branches/1.4.x/ ^/apr/apr-util/tags/1.4.1

[VOTE] Release apr-util 1.4.1

2011-12-07 Thread Graham Leggett
Hi all, Tarballs/zipballs are at http://apr.apache.org/dev/dist/autoconf-2.68+libtool-2.4.2/. New in apr-util v1.4 is the apr_crypto interface, and a fix for LDAP on Solaris. Full CHANGES are here: https://svn.apache.org/repos/asf/apr/apr-util/tags/1.4.1/CHANGES +/-1 [ ] Release apr-util

Re: [VOTE] Release apr-util 1.4.0

2011-12-07 Thread Igor Galić
- Original Message - On 08 Dec 2011, at 12:56 AM, Jeff Trawick wrote: There's a parameter on release.sh which gets passed to apr-util buildconf. If it is not passed to release.sh it looks like it will look in ../apr. As it is not coming from the autotools, I guess Graham

missing exported .mak/.dep files for Windows in apr-util 1.4.x?

2011-12-07 Thread Jeff Trawick
IIRC this is required so that release.sh creates a command-line-build-able apr-util, which is an expectation of a release. (I will go ahead and plead confused in advance just in case.)

Re: [PATCH] charclass matching and input check for fnmatch

2011-12-07 Thread William A. Rowe Jr.
On 12/7/2011 1:12 PM, Stefan Sperling wrote: On Tue, Dec 06, 2011 at 12:48:26PM -0800, William A. Rowe Jr. wrote: On 12/6/2011 4:36 AM, Stefan Sperling wrote: @@ -207,6 +274,10 @@ APR_DECLARE(int) apr_fnmatch(const char *pattern, const char *mismatch = NULL; int matchlen = 0; +

Re: missing exported .mak/.dep files for Windows in apr-util 1.4.x?

2011-12-07 Thread William A. Rowe Jr.
On 12/7/2011 3:28 PM, Jeff Trawick wrote: IIRC this is required so that release.sh creates a command-line-build-able apr-util, which is an expectation of a release. (I will go ahead and plead confused in advance just in case.) Yes, the 'initial' build on a given branch needs these exported

Re: svn commit: r1211334 - in /apr/apr-util/branches/1.4.x/crypto: apr_crypto_nss.c apr_crypto_nss.dsp

2011-12-07 Thread Mladen Turk
On 12/07/2011 09:32 PM, William A. Rowe Jr. wrote: On 12/7/2011 10:54 AM, Mladen Turk wrote: On 12/07/2011 07:17 PM, Roy T. Fielding wrote: Just to confirm, this only gets compiled if the user has added a --with option specific to nss, right? Otherwise it impacts our license. Actually it's