Fwd: Still #ifdef WIN64 in APR

2012-03-01 Thread Eric Covener
https://issues.apache.org/bugzilla/show_bug.cgi?id=49155 says: APR_SIZEOF_VOIDP isn't defined as 8 because of the #ifdef WIN64 statement preceding #define APR_SIZEOF_VOIDP 8 in the apr.hw file. It is supposed be #ifdef _WIN64. There is another #ifdef WIN64 in apr.hw which should also be changed

Re: Still #ifdef WIN64 in APR

2012-03-01 Thread Jeff Trawick
On Thu, Mar 1, 2012 at 7:04 AM, Eric Covener cove...@gmail.com wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=49155 says: APR_SIZEOF_VOIDP isn't defined as 8 because of the #ifdef WIN64 statement preceding #define APR_SIZEOF_VOIDP 8 in the apr.hw file. It is supposed be #ifdef

Re: Still #ifdef WIN64 in APR

2012-03-01 Thread Jeff Trawick
On Thu, Mar 1, 2012 at 6:15 AM, Steffen i...@apachelounge.com wrote: In APR 1.4.6 there is still a typo in the statements, causes crashes HTTPD in eg. setting on logging in mod_rewrite. In shm.c and apr.hw #ifdef WIN64 Sould be: #ifdef _WIN64 Steffen Does this work for you?

Re: Still #ifdef WIN64 in APR

2012-03-01 Thread Eric Covener
Does this work for you? http://svn.apache.org/viewvc?view=revisionrevision=1295535 (I'll move the fix back to 1.5 and 1.4 branches and retarget the bug to apr.) Looks right here given the report and stackoverflow post.

Re: Still #ifdef WIN64 in APR

2012-03-01 Thread Mladen Turk
On 03/01/2012 01:19 PM, Jeff Trawick wrote: Regardless of the APR_SIZEOF_VOIDP issue, it should be _WIN64 in the .c/.h code. I'll commit that. I guess the attribution to use is the e-mail address in bug 49155. _WIN64 is defined by cl.exe (same as WIN32/_WIN32) WIN64 should be defined by

Re: Still #ifdef WIN64 in APR

2012-03-01 Thread Jeff Trawick
On Thu, Mar 1, 2012 at 8:23 AM, Mladen Turk mt...@apache.org wrote: On 03/01/2012 01:19 PM, Jeff Trawick wrote: Regardless of the APR_SIZEOF_VOIDP issue, it should be _WIN64 in the .c/.h code.  I'll commit that.  I guess the attribution to use is the e-mail address in bug 49155. _WIN64 is

APR and portability issues - /usr/include gets skipped by configure when apr is external

2012-03-01 Thread Michael Felt
Call it innocence, call it naive, call it whatever - but APR is an obstacle to be overcome. There is documentation, but lacks an overview of what/how apr is used. X pages long list of variables does not help prepare one (read me if you will) for proper usage. CASE: built apr, apr-util, httpd on

Re: APR and portability issues - /usr/include gets skipped by configure when apr is external

2012-03-01 Thread William A. Rowe Jr.
On 3/1/2012 6:55 PM, Michael Felt wrote: Note: I have no idea of what is in libapr or libaprutil - but I am concerned that they are not going to be portable enough to use across different hardware/os platforms even those platforms are binary compatible. Also - maybe - the problems are

Re: APR and portability issues - /usr/include gets skipped by configure when apr is external

2012-03-01 Thread Jeff Trawick
On Thu, Mar 1, 2012 at 7:55 PM, Michael Felt mamf...@gmail.com wrote: Call it innocence, call it naive, call it whatever - but APR is an obstacle to be overcome. There is documentation, but lacks an overview of what/how apr is used. X pages long list of variables does not help prepare one