On 17/11/2021 18:50, Yann Ylavic wrote:
On Wed, Nov 17, 2021 at 5:19 PM Mladen Turk wrote:
On 17/11/2021 16:53, Yann Ylavic wrote:
apr_poll_drain_wakeup_pipe() should consume each byte sent on the pipe
corresponding to a wakeup_set flip.
Yes, its basically just one byte and one call
On Wed, Nov 17, 2021 at 5:19 PM Mladen Turk wrote:
>
> On 17/11/2021 16:53, Yann Ylavic wrote:
>
> > apr_poll_drain_wakeup_pipe() should consume each byte sent on the pipe
> > corresponding to a wakeup_set flip.
> >
>
> Yes, its basically just one byte and one call to the apr_file_getc.
> The
Hi,
On Wed, Nov 10, 2021 at 2:40 PM Yann Ylavic wrote:
>
> On Tue, Nov 9, 2021 at 11:52 PM Mihaly Szjatinya
> wrote:
> >
> > We've encountered a bug in pollset wakeup pipe. With
> > how wakeup pipe is created now, it's possible that reading loop in
> > `apr_poll_drain_wakeup_pipe()` gets
On Wed, Nov 17, 2021 at 2:28 PM Mladen Turk wrote:
>
> Attached a patch that fixes those huge writes to drain pipe
Thanks, looks good to me.
I've also reverted r1894914 because the new synchronization with
atomics requires that we always block when reading the pipe now.
Attached a patch that fixes those huge writes to drain pipe
Tested on cetos8, all test pass
On 17/11/2021 08:08, Ruediger Pluem wrote:
On 11/17/21 2:39 AM, Mladen Turk wrote:
On 16/11/2021 12:00, Yann Ylavic wrote:
On Wed, Nov 10, 2021 at 4:19 PM Yann Ylavic wrote:
Otherwise I'll
On 17/11/2021 08:08, Ruediger Pluem wrote:
On 11/17/21 2:39 AM, Mladen Turk wrote:
On 16/11/2021 12:00, Yann Ylavic wrote:
On Wed, Nov 10, 2021 at 4:19 PM Yann Ylavic wrote:
Otherwise I'll revert because I have no way to test it, but I think
that apr_poll_drain_wakeup_pipe() might
