[GitHub] [apr] uhliarik commented on pull request #44: Fix socket creation when APR_UNSPEC is used

2023-06-26 Thread via GitHub
uhliarik commented on PR #44: URL: https://github.com/apache/apr/pull/44#issuecomment-1608549840 Altered the way how conn_connect() creates a socket connection. It should go now through all addresses returned by apr_sockaddr_info_get(). -- This is an automated message from the Apache

[GitHub] [apr] uhliarik commented on pull request #44: Fix socket creation when APR_UNSPEC is used

2023-06-26 Thread via GitHub
uhliarik commented on PR #44: URL: https://github.com/apache/apr/pull/44#issuecomment-1607292016 > Ah, hmm. I think this is still incorrect. The proper way is to loop over the returned addresses until a connect() succeeds. e.g. this: > >

[GitHub] [apr] uhliarik commented on pull request #44: Fix socket creation when APR_UNSPEC is used

2023-06-23 Thread via GitHub
uhliarik commented on PR #44: URL: https://github.com/apache/apr/pull/44#issuecomment-1605050843 Reproducer: run: $ ./memcachecon 127.0.0.1 11211 $ ./memcachecon ::1 11211 ```#include #include #include int main(int argc, char **argv) {

[GitHub] [apr] uhliarik commented on pull request #44: Fix socket creation when APR_UNSPEC is used

2023-06-23 Thread via GitHub
uhliarik commented on PR #44: URL: https://github.com/apache/apr/pull/44#issuecomment-1605047355 Follow up to https://svn.apache.org/repos/asf/apr/apr/trunk@1907242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the