Re: [PATCH] APR turn off readonly/executable, add apr_file_attrs_get

2002-02-03 Thread Kevin Pilch-Bisson
On Sat, Feb 02, 2002 at 08:34:44PM +, Philip Martin wrote: +#ifdef APR_HAS_THREADS +status = apr_thread_mutex_lock(umask_mutex); +if (!APR_STATUS_IS_SUCCESS(status)) +return status; +#endif Shouldn't this be #if APR_HAS_THREADS i.e. isn't it always defined to either 0

Re: [PATCH] APR turn off readonly/executable, add apr_file_attrs_get

2002-02-03 Thread Cliff Woolley
On Sat, 2 Feb 2002, Kevin Pilch-Bisson wrote: On Sat, Feb 02, 2002 at 08:34:44PM +, Philip Martin wrote: +#ifdef APR_HAS_THREADS +status = apr_thread_mutex_lock(umask_mutex); +if (!APR_STATUS_IS_SUCCESS(status)) +return status; +#endif Shouldn't this be #if

Re: [PATCH] APR turn off readonly/executable, add apr_file_attrs_get

2002-02-03 Thread Philip Martin
Cliff Woolley [EMAIL PROTECTED] writes: On Sat, 2 Feb 2002, Kevin Pilch-Bisson wrote: On Sat, Feb 02, 2002 at 08:34:44PM +, Philip Martin wrote: +#ifdef APR_HAS_THREADS +status = apr_thread_mutex_lock(umask_mutex); +if (!APR_STATUS_IS_SUCCESS(status)) +return

[PATCH] APR turn off readonly/executable, add apr_file_attrs_get

2002-02-02 Thread Philip Martin
Greg Stein [EMAIL PROTECTED] writes: (btw, for completeness, we'd also want ways to turn off readonly and to the executable state) Here's a patch that does that, and provides a way to query the attributes. It also makes the permission setting by apr_file_attrs_set respect the umask of the