Hi,
As mailed in November 2009 [1], simple apr_filepath_merge() calls on paths
like C:/Windows fail for users that use a shell that turns their active
directory in a c:/users/bert style instead of the more common
C:/users/bert (note the lower case 'C').
The current APR code just assumes
Applied in r960665 to trunk.
Backports will be needed before future branch releases (unsure what
the schedule is for that).
Thanks,
-g
On Mon, Jul 5, 2010 at 08:43, Bert Huijben b...@qqmail.nl wrote:
Hi,
As mailed in November 2009 [1], simple apr_filepath_merge() calls on paths
like
This patch isn't valid.
Other applications will play games with comparisons. Comparisons require
users to call TRUEPATH. What seems to be needed here is for apr_pathname_cwd
to be returning a true path.
All other comparisons are intrinsically invalid, and this has the potential
to introduce
-Original Message-
From: William A. Rowe Jr. [mailto:wr...@rowe-clan.net]
Sent: maandag 5 juli 2010 22:35
To: dev@apr.apache.org
Subject: Re: [Patch] apr_filepath_merge() on c:path fails
consistently on Windows if the current directory is c:/windows
instead of C:/Windows
On 7/5/2010 3:46 PM, Bert Huijben wrote:
Too bad, that without this patch you can't call the truepath support on a
merged path and that Windows has 26 (or 27) current directories while APR
assumes that there is only one.
Hold up... are you trying to merge non-normalized paths?
I need to
William A. Rowe, Jr. wrote:
Anyways, the correct fix appears to be; FIRST evaluate that prior segment
begins with / or \, as well as begins with : or looking for characters.
Patch committed, see;
http://svn.apache.org/repos/asf/apr/apr/trunk/file_io/win32/filepath.c
commit 424915.
Thanks
Hi,
attached is a patch for an issue reported in the Subversion issue tracker as
issue 1869:
http://subversion.tigris.org/issues/show_bug.cgi?id=1869
The issue is that merging two paths and ..\..\.. with the
apr_filepath_merge functions returns a result of ..\ where it obviously
should have
Lieven Govaerts wrote:
--- file_io/win32/filepath.c(revision 422522)
+++ file_io/win32/filepath.c(working copy)
@@ -673,7 +673,7 @@
*/
}
else if (pathlen == 0 ||
- (pathlen = 3 (pathlen == 3
+ (pathlen =
Lieven Govaerts wrote:
Hi,
attached is a patch for an issue reported in the Subversion issue tracker as
issue 1869: http://subversion.tigris.org/issues/show_bug.cgi?id=1869
The issue is that merging two paths and ..\..\.. with the
apr_filepath_merge functions returns a result of ..\ where it
At 12:42 PM 8/8/2003, [EMAIL PROTECTED] wrote:
Subversion users have been noticing some annoying behavior in our use
of apr_filepath_merge() that only happens on Windows platforms. We
call this function with the APR_FILEPATH_TRUENAME flag to get the case
and segment delimiters all in shape. We
William A. Rowe, Jr. [EMAIL PROTECTED] writes:
Thanks for your patch - and your analysis! After walking through this bug
for some time - I believe we converge on the patch, which I've committed.
Thanks for your patience - I'm only now finding a few cycles to devote
again to APR.
No sweat.
William A. Rowe, Jr. [EMAIL PROTECTED] writes:
You need to be aware that APR_FILEPATH_TRUENAME must construct a
canonical path name. That is why you are having so many problems.
It seems that you are asking for ../ to be treated as a 'relative
root'. That means that only foo/bar should be
Subversion users have been noticing some annoying behavior in our use
of apr_filepath_merge() that only happens on Windows platforms. We
call this function with the APR_FILEPATH_TRUENAME flag to get the case
and segment delimiters all in shape. We always pass for the
basepath. The addpath
You need to be aware that APR_FILEPATH_TRUENAME must construct
a canonical path name. That is why you are having so many problems.
It seems that you are asking for ../ to be treated as a 'relative root'. That
means that only foo/bar should be normalized.
I'd be happy to look at your issues and
Hi,
This patch is trying to solve the following problems:
1) apr_filepath_merge(, .) returns instead of .
This is a one line fix, but needs to be reviewed in the win32
case, since a check for /. / is missed due to this patch.
2) apr_filepath_merge(., ) returns ./
Is a bit harder. I
From: Sander Striker [mailto:[EMAIL PROTECTED]
Sent: 28 July 2002 12:09
Hi,
This patch is trying to solve the following problems:
1) apr_filepath_merge(, .) returns instead of .
This is a one line fix, but needs to be reviewed in the win32
case, since a check for /. / is missed
At 05:09 AM 7/28/2002, Sander Striker wrote:
Hi,
This patch is trying to solve the following problems:
1) apr_filepath_merge(, .) returns instead of .
This is a one line fix, but needs to be reviewed in the win32
case, since a check for /. / is missed due to this patch.
Strangely enough, the
patch to optimize away a big strdup at the end of apr_filepath_merge()
--Brian
Index: srclib/apr/file_io/unix/filepath.c
===
RCS file: /home/cvspublic/apr/file_io/unix/filepath.c,v
retrieving revision 1.9
diff -u -r1.9 filepath.c
---
18 matches
Mail list logo
