Re: [PATCH] iconv tweak

2001-02-08 Thread Jeff Trawick
Sam TH [EMAIL PROTECTED] writes: The easiest way would probably be to use c++ to test this, since in c++ cast from a char ** to a const char ** is illegal, and generates and error. c++ is cool, but we can't require it so we'd have to see if it failed due to no c++, then back down to the c

Re: [PATCH] iconv tweak

2001-02-07 Thread Jeff Trawick
Doesn't AC_TRY_COMPILE() succeed if there is a warning? I think your patch only helps on rare systems where the compiler won't compile it at all if the const-ness doesn't match the iconv() prototype. Yeah, that is an improvement over the current situation but it would be nice to get rid of the

Re: [PATCH] iconv tweak

2001-02-07 Thread Mo DeJong
On 7 Feb 2001, Jeff Trawick wrote: Doesn't AC_TRY_COMPILE() succeed if there is a warning? I think your patch only helps on rare systems where the compiler won't compile it at all if the const-ness doesn't match the iconv() prototype. Yeah, that is an improvement over the current situation

Re: [PATCH] iconv tweak

2001-02-07 Thread Jeff Trawick
Mo DeJong [EMAIL PROTECTED] writes: Is it reasonable to test for a compile *warning* via autoconf? I am not sure why that matters. The point is that apr does not compile on some systems, this iconv #define code will fix that. Warnings do matter, hence my questions. I certainly agree that it

[PATCH] iconv tweak

2001-02-05 Thread Greg Stein
There was some discussion about iconv prototyes here recently, but I kind of missed it. Do we always need to live with a warning about a type mismatch, or is the cast below appropriate? IOW, do some headers have const on them, and others not? Cheers, -g Index: xlate.c

Re: [PATCH] iconv tweak

2001-02-05 Thread Sam TH
On Sun, Feb 04, 2001 at 09:26:39PM -0800, Greg Stein wrote: There was some discussion about iconv prototyes here recently, but I kind of missed it. Do we always need to live with a warning about a type mismatch, or is the cast below appropriate? IOW, do some headers have const on them,