[Patch] apr_filepath_merge() on c:path fails consistently on Windows if the current directory is c:/windows instead of C:/Windows

2010-07-05 Thread Bert Huijben
Hi, As mailed in November 2009 [1], simple apr_filepath_merge() calls on paths like C:/Windows fail for users that use a shell that turns their active directory in a c:/users/bert style instead of the more common C:/users/bert (note the lower case 'C'). The current APR code just assumes

Re: [Patch] apr_filepath_merge() on c:path fails consistently on Windows if the current directory is c:/windows instead of C:/Windows

2010-07-05 Thread Greg Stein
Applied in r960665 to trunk. Backports will be needed before future branch releases (unsure what the schedule is for that). Thanks, -g On Mon, Jul 5, 2010 at 08:43, Bert Huijben b...@qqmail.nl wrote:        Hi, As mailed in November 2009 [1], simple apr_filepath_merge() calls on paths like

Re: [Patch] apr_filepath_merge() on c:path fails consistently on Windows if the current directory is c:/windows instead of C:/Windows

2010-07-05 Thread William A. Rowe Jr.
This patch isn't valid. Other applications will play games with comparisons. Comparisons require users to call TRUEPATH. What seems to be needed here is for apr_pathname_cwd to be returning a true path. All other comparisons are intrinsically invalid, and this has the potential to introduce

RE: [Patch] apr_filepath_merge() on c:path fails consistently on Windows if the current directory is c:/windows instead of C:/Windows

2010-07-05 Thread Bert Huijben
-Original Message- From: William A. Rowe Jr. [mailto:wr...@rowe-clan.net] Sent: maandag 5 juli 2010 22:35 To: dev@apr.apache.org Subject: Re: [Patch] apr_filepath_merge() on c:path fails consistently on Windows if the current directory is c:/windows instead of C:/Windows

Re: [Patch] apr_filepath_merge() on c:path fails consistently on Windows if the current directory is c:/windows instead of C:/Windows

2010-07-05 Thread William A. Rowe Jr.
On 7/5/2010 3:46 PM, Bert Huijben wrote: Too bad, that without this patch you can't call the truepath support on a merged path and that Windows has 26 (or 27) current directories while APR assumes that there is only one. Hold up... are you trying to merge non-normalized paths? I need to