Someone pointed out that we eat \r's in apr_file_gets() ... now if we
respected the BINARY flag to open that might not be as much of
a problem - but it's deeper than that...
We also don't reassemble \r\n pairs in apr_file_puts() either, which
means any file that goes while(apr_file_gets())
William A. Rowe, Jr. wrote:
Someone pointed out that we eat \r's in apr_file_gets() ... now if we
respected the BINARY flag to open that might not be as much of
a problem - but it's deeper than that...
We also don't reassemble \r\n pairs in apr_file_puts() either, which
means any file that goes
At 02:11 PM 3/4/2003, Branko Čibej wrote:
William A. Rowe, Jr. wrote:
+1. Every other bit of apr_file_* code treats all files as pure binary
already. This shouldn't be an exception. We shouldn't eat \r's until we
have real translated streams, and even then, BINARY should be the
default ('cause if
+1. As you pointed out, NetWare has been using the Unix version which does not
eat the \r's. So far we haven't seen any problems at all with this.
Brad
Brad Nicholes
Senior Software Engineer
Novell, Inc., the leading provider of Net business solutions
http://www.novell.com
William A. Rowe,
