Re: APR_ARRAY_FOO convenience macros

2005-10-09 Thread Ben Laurie
(Reviving a very old thread) Garrett Rooney wrote: William A. Rowe, Jr. wrote: Yes, but (especially registered functions) allow you to set up an argument type/argument list by casting a function ptr, rather than the actual data object. This means that every invocation of APR_FN_type_FOO will

Re: APR_ARRAY_FOO convenience macros

2005-08-17 Thread Joe Orton
On Mon, Aug 15, 2005 at 07:24:29PM -0700, Garrett Rooney wrote: So back in Dec 2003 Sander Striker suggested [1] adding Subversion's macros for manipulating apr arrays (APR_ARRAY_IDX, which automates the casting needed to access entries in the array, and APR_ARRAY_PUSH, which automates the

Re: APR_ARRAY_FOO convenience macros

2005-08-17 Thread Cliff Woolley
On Wed, 17 Aug 2005, Joe Orton wrote: On Tue, Aug 16, 2005 at 01:49:55AM -0500, William Rowe wrote: At 09:24 PM 8/15/2005, Garrett Rooney wrote: So back in Dec 2003 Sander Striker suggested [1] adding Subversion's macros for manipulating apr arrays (APR_ARRAY_IDX, which automates the

Re: APR_ARRAY_FOO convenience macros

2005-08-17 Thread Branko Čibej
Cliff Woolley wrote: On Wed, 17 Aug 2005, Joe Orton wrote: On Tue, Aug 16, 2005 at 01:49:55AM -0500, William Rowe wrote: At 09:24 PM 8/15/2005, Garrett Rooney wrote: So back in Dec 2003 Sander Striker suggested [1] adding Subversion's macros for manipulating apr arrays

Re: APR_ARRAY_FOO convenience macros

2005-08-17 Thread Brian W. Fitzpatrick
On Aug 17, 2005, at 10:47 PM, Branko Čibej wrote: Cliff Woolley wrote: On Wed, 17 Aug 2005, Joe Orton wrote: On Tue, Aug 16, 2005 at 01:49:55AM -0500, William Rowe wrote: At 09:24 PM 8/15/2005, Garrett Rooney wrote: So back in Dec 2003 Sander Striker suggested [1] adding

Re: APR_ARRAY_FOO convenience macros

2005-08-17 Thread Garrett Rooney
Brian W. Fitzpatrick wrote: On Aug 17, 2005, at 10:47 PM, Branko Čibej wrote: Cliff Woolley wrote: I'm fine with adding these. +1 +1, in case we need another vote. I know we'd go barmy in SVN without these macros. +1 indeed. Since the overwhelming majority appears to be in favor

Re: APR_ARRAY_FOO convenience macros

2005-08-16 Thread William A. Rowe, Jr.
At 09:24 PM 8/15/2005, Garrett Rooney wrote: So back in Dec 2003 Sander Striker suggested [1] adding Subversion's macros for manipulating apr arrays (APR_ARRAY_IDX, which automates the casting needed to access entries in the array, and APR_ARRAY_PUSH, which automates the casting needed to add

Re: APR_ARRAY_FOO convenience macros

2005-08-16 Thread Garrett Rooney
William A. Rowe, Jr. wrote: At 09:24 PM 8/15/2005, Garrett Rooney wrote: So back in Dec 2003 Sander Striker suggested [1] adding Subversion's macros for manipulating apr arrays (APR_ARRAY_IDX, which automates the casting needed to access entries in the array, and APR_ARRAY_PUSH, which

Re: APR_ARRAY_FOO convenience macros

2005-08-16 Thread Greg Marr
At 12:08 PM 8/16/2005, Garrett Rooney wrote: William A. Rowe, Jr. wrote: At 09:24 PM 8/15/2005, Garrett Rooney wrote: So back in Dec 2003 Sander Striker suggested [1] adding Subversion's macros for manipulating apr arrays (APR_ARRAY_IDX, which automates the casting needed to access entries

Re: APR_ARRAY_FOO convenience macros

2005-08-16 Thread William A. Rowe, Jr.
At 11:08 AM 8/16/2005, Garrett Rooney wrote: William A. Rowe, Jr. wrote: IIUC, these are not typesafe? See the apr optional function and hook apis for true typesafe casts. I must be missing something, but I don't see how these macros could be implemented in a more typesafe way. Could you

APR_ARRAY_FOO convenience macros

2005-08-15 Thread Garrett Rooney
So back in Dec 2003 Sander Striker suggested [1] adding Subversion's macros for manipulating apr arrays (APR_ARRAY_IDX, which automates the casting needed to access entries in the array, and APR_ARRAY_PUSH, which automates the casting needed to add entries to the array) to apr_tables.h. Roy