Re: [PATCH] fix cleanups in cleanups

2001-09-21 Thread William A. Rowe, Jr.
From: "Sander Striker" <[EMAIL PROTECTED]> Sent: Friday, September 21, 2001 2:51 AM > > From: Greg Stein [mailto:[EMAIL PROTECTED] > > Sent: 21 September 2001 09:35 > > On Thu, Sep 20, 2001 at 07:54:22PM -0700, Ryan Bloom wrote: > > > On Thursday 20 September 2001 05:48 pm, Greg Stein wrote: > >

RE: [PATCH] fix cleanups in cleanups

2001-09-21 Thread Sander Striker
> From: Greg Stein [mailto:[EMAIL PROTECTED] > Sent: 21 September 2001 09:35 > On Thu, Sep 20, 2001 at 07:54:22PM -0700, Ryan Bloom wrote: > > On Thursday 20 September 2001 05:48 pm, Greg Stein wrote: > > > > Calling pop_cleanup() on every iteration is a bit much. Consider the > > > following

Re: [PATCH] fix cleanups in cleanups

2001-09-21 Thread Greg Stein
On Thu, Sep 20, 2001 at 07:54:22PM -0700, Ryan Bloom wrote: > On Thursday 20 September 2001 05:48 pm, Greg Stein wrote: ... > > Calling pop_cleanup() on every iteration is a bit much. Consider the > > following patch: > > Why is it a bit much? I just took a quick look at it, it is an if, and thre

Re: [PATCH] fix cleanups in cleanups

2001-09-21 Thread Ryan Bloom
On Thursday 20 September 2001 08:12 pm, Aaron Bannert wrote: > On Thu, Sep 20, 2001 at 05:48:45PM -0700, Greg Stein wrote: > > On Thu, Sep 20, 2001 at 11:18:55AM -0700, Aaron Bannert wrote: > > Basically, the above code processes the cleanups in batches. Everything > > that was initially registered

Re: [PATCH] fix cleanups in cleanups

2001-09-21 Thread William A. Rowe, Jr.
From: "Aaron Bannert" <[EMAIL PROTECTED]> Sent: Thursday, September 20, 2001 10:12 PM > On Thu, Sep 20, 2001 at 05:48:45PM -0700, Greg Stein wrote: > > On Thu, Sep 20, 2001 at 11:18:55AM -0700, Aaron Bannert wrote: > > >... > > > Does this fix it for you? All testmem tests passed for me and your

Re: [PATCH] fix cleanups in cleanups

2001-09-21 Thread Aaron Bannert
On Thu, Sep 20, 2001 at 05:48:45PM -0700, Greg Stein wrote: > On Thu, Sep 20, 2001 at 11:18:55AM -0700, Aaron Bannert wrote: > >... > > Does this fix it for you? All testmem tests passed for me and your code > > above properly flushes "Cleanup" to the file. > > > > (Someone needs to check my work

Re: [PATCH] fix cleanups in cleanups

2001-09-21 Thread Ryan Bloom
On Thursday 20 September 2001 05:48 pm, Greg Stein wrote: > On Thu, Sep 20, 2001 at 11:18:55AM -0700, Aaron Bannert wrote: > >... > > Does this fix it for you? All testmem tests passed for me and your code > > above properly flushes "Cleanup" to the file. > > > > (Someone needs to check my work on

Re: [PATCH] fix cleanups in cleanups

2001-09-21 Thread Ryan Bloom
On Thursday 20 September 2001 05:48 pm, Greg Stein wrote: > On Thu, Sep 20, 2001 at 11:18:55AM -0700, Aaron Bannert wrote: > >... > > Does this fix it for you? All testmem tests passed for me and your code > > above properly flushes "Cleanup" to the file. > > > > (Someone needs to check my work on

Re: [PATCH] fix cleanups in cleanups

2001-09-21 Thread Greg Stein
On Thu, Sep 20, 2001 at 11:18:55AM -0700, Aaron Bannert wrote: >... > Does this fix it for you? All testmem tests passed for me and your code > above properly flushes "Cleanup" to the file. > > (Someone needs to check my work on run_child_cleanups() and make sure > that the popping is necessary. I