Re: conditional in apr_thread_proc.h

2010-09-02 Thread Ruediger Pluem
On 09/01/2010 08:11 PM, Guenter Knauf wrote: while checking for missing prototypes I just came over this in apr_thread_proc.h: #if APR_HAVE_STRUCT_RLIMIT /** * Set the Resource Utilization limits when starting a new process. * @param attr The procattr we care about. * @param what Which

Re: conditional in apr_thread_proc.h

2010-09-02 Thread Guenter Knauf
Hi Rüdiger, Am 02.09.2010 08:27, schrieb Ruediger Pluem: I agree that we should fix this. But as I understand the versioning rules, this could be only done in trunk and 1.5 (not released), as otherwise we would change the API/ABI on platforms with APR_HAVE_STRUCT_RLIMIT undefined, correct?

Re: conditional in apr_thread_proc.h

2010-09-02 Thread Bojan Smojver
On Thu, 2010-09-02 at 09:15 +0200, Guenter Knauf wrote: hmm, I thought adding a function is not a problem - only changing/removing - or? Adding is a problem too. If someone links against newer minor version, this program should work against older minor version too. However, older minor

Re: conditional in apr_thread_proc.h

2010-09-02 Thread Branko Čibej
On 02.09.2010 09:20, Bojan Smojver wrote: On Thu, 2010-09-02 at 09:15 +0200, Guenter Knauf wrote: hmm, I thought adding a function is not a problem - only changing/removing - or? Adding is a problem too. If someone links against newer minor version, this program should work against older

Re: conditional in apr_thread_proc.h

2010-09-02 Thread Rainer Jung
On 02.09.2010 10:57, Branko Čibej wrote: On 02.09.2010 09:20, Bojan Smojver wrote: On Thu, 2010-09-02 at 09:15 +0200, Guenter Knauf wrote: hmm, I thought adding a function is not a problem - only changing/removing - or? Adding is a problem too. If someone links against newer minor version,

Re: conditional in apr_thread_proc.h

2010-09-02 Thread Bojan Smojver
On Thu, 2010-09-02 at 10:57 +0200, Branko Čibej wrote: However, you certainly cannot retroactively add a function to 1.4.x that was not already present in 1.5.0. So I expect you meant micro version above, rather than minor version. I meant that 1.4.x and 1.4.y have to have the same set of

Re: conditional in apr_thread_proc.h

2010-09-02 Thread William A. Rowe Jr.
On 9/1/2010 1:11 PM, Guenter Knauf wrote: so the public API changes depending on APR_HAVE_STRUCT_RLIMIT which I think is wrong; we need to remove the ifdef and all platforms which have APR_HAVE_STRUCT_RLIMIT=0 need to provide a stub like in beos/proc.c: APR_DECLARE(apr_status_t)