Fwd: Still #ifdef WIN64 in APR

2012-03-01 Thread Eric Covener
to #ifdef _WIN64. -- Forwarded message -- From: Steffen i...@apachelounge.com Date: Thu, Mar 1, 2012 at 6:15 AM Subject: Still #ifdef WIN64 in APR To: d...@httpd.apache.org In APR 1.4.6 there is still a typo in the statements, causes crashes HTTPD in eg. setting on logging

Re: Still #ifdef WIN64 in APR

2012-03-01 Thread Jeff Trawick
be _WIN64 in the .c/.h code. I'll commit that. I guess the attribution to use is the e-mail address in bug 49155. -- Forwarded message -- From: Steffen i...@apachelounge.com Date: Thu, Mar 1, 2012 at 6:15 AM Subject: Still #ifdef WIN64 in APR To: d...@httpd.apache.org

Re: Still #ifdef WIN64 in APR

2012-03-01 Thread Jeff Trawick
On Thu, Mar 1, 2012 at 6:15 AM, Steffen i...@apachelounge.com wrote: In APR 1.4.6 there is still a typo in the statements, causes crashes HTTPD in eg. setting on logging in mod_rewrite. In shm.c and apr.hw #ifdef WIN64 Sould be: #ifdef _WIN64 Steffen Does this work for you?

Re: Still #ifdef WIN64 in APR

2012-03-01 Thread Eric Covener
Does this work for you? http://svn.apache.org/viewvc?view=revisionrevision=1295535 (I'll move the fix back to 1.5 and 1.4 branches and retarget the bug to apr.) Looks right here given the report and stackoverflow post.

Re: Still #ifdef WIN64 in APR

2012-03-01 Thread Mladen Turk
On 03/01/2012 01:19 PM, Jeff Trawick wrote: Regardless of the APR_SIZEOF_VOIDP issue, it should be _WIN64 in the .c/.h code. I'll commit that. I guess the attribution to use is the e-mail address in bug 49155. _WIN64 is defined by cl.exe (same as WIN32/_WIN32) WIN64 should be defined by

Re: Still #ifdef WIN64 in APR

2012-03-01 Thread Jeff Trawick
On Thu, Mar 1, 2012 at 8:23 AM, Mladen Turk mt...@apache.org wrote: On 03/01/2012 01:19 PM, Jeff Trawick wrote: Regardless of the APR_SIZEOF_VOIDP issue, it should be _WIN64 in the .c/.h code.  I'll commit that.  I guess the attribution to use is the e-mail address in bug 49155. _WIN64 is