Re: cvs commit: apr/memory/unix apr_sms.c apr_sms_trivial.c sms_private.h

2001-07-08 Thread rbb
On Sun, 8 Jul 2001, Aaron Bannert wrote: > On Sat, Jul 07, 2001 at 05:14:47PM -0700, Justin Erenkrantz wrote: > [...] > > Error-checking > > is something that we pointedly avoid doing in APR. > [...] > > Please tell me this is not a general policy, and that APR has a small > amount of error checki

Re: cvs commit: apr/memory/unix apr_sms.c apr_sms_trivial.c sms_private.h

2001-07-08 Thread Aaron Bannert
On Sat, Jul 07, 2001 at 05:14:47PM -0700, Justin Erenkrantz wrote: [...] > Error-checking > is something that we pointedly avoid doing in APR. [...] Please tell me this is not a general policy, and that APR has a small amount of error checking. Pretty please? I don't advocate pedantic error checki

Re: cvs commit: apr/memory/unix apr_sms.c apr_sms_trivial.c sms_private.h

2001-07-08 Thread rbb
On Sat, 7 Jul 2001, Justin Erenkrantz wrote: > On Sat, Jul 07, 2001 at 04:01:35PM -0700, dean gaudet wrote: > > what's it really matter? trying to clean up from OOM is near impossible. It doesn't matter if it's impossible or not. The problem is that we are in a library, so we can't just write t

Re: cvs commit: apr/memory/unix apr_sms.c apr_sms_trivial.c sms_private.h

2001-07-08 Thread Justin Erenkrantz
On Sat, Jul 07, 2001 at 04:01:35PM -0700, dean gaudet wrote: > what's it really matter? trying to clean up from OOM is near impossible. Which brings me back to my original question: "Why do we have an abort function?" As you said (I was originally thinking this, but admittedly, I didn't bring t

Re: cvs commit: apr/memory/unix apr_sms.c apr_sms_trivial.c sms_private.h

2001-07-07 Thread dean gaudet
On Sat, 7 Jul 2001 [EMAIL PROTECTED] wrote: > On Sat, 7 Jul 2001, Justin Erenkrantz wrote: > > > On Sat, Jul 07, 2001 at 12:26:32PM -, [EMAIL PROTECTED] wrote: > > > dreid 01/07/07 05:26:32 > > > > > > Modified:include apr_sms.h > > >memory/unix apr_sms.c apr_sms_t

Re: cvs commit: apr/memory/unix apr_sms.c apr_sms_trivial.c sms_private.h

2001-07-07 Thread rbb
On Sat, 7 Jul 2001, Justin Erenkrantz wrote: > On Sat, Jul 07, 2001 at 12:26:32PM -, [EMAIL PROTECTED] wrote: > > dreid 01/07/07 05:26:32 > > > > Modified:include apr_sms.h > >memory/unix apr_sms.c apr_sms_trivial.c sms_private.h > > Log: > > Add the abort func

Re: cvs commit: apr/memory/unix apr_sms.c apr_sms_trivial.c sms_private.h

2001-07-07 Thread dean gaudet
On Sat, 7 Jul 2001, Aaron Bannert wrote: > > > I don't think there is any benefit to this. But, someone else might > > > be able to chime in and say why we need this functionality. -- justin > > > > how do you handle out of memory? > > > > palloc is not permitted to return NULL for performance r

Re: cvs commit: apr/memory/unix apr_sms.c apr_sms_trivial.c sms_private.h

2001-07-07 Thread Aaron Bannert
> > I don't think there is any benefit to this. But, someone else might > > be able to chime in and say why we need this functionality. -- justin > > how do you handle out of memory? > > palloc is not permitted to return NULL for performance reasons. (well > that plus the massive amounts of le

Re: cvs commit: apr/memory/unix apr_sms.c apr_sms_trivial.c sms_private.h

2001-07-07 Thread dean gaudet
On Sat, 7 Jul 2001, Justin Erenkrantz wrote: > On Sat, Jul 07, 2001 at 12:26:32PM -, [EMAIL PROTECTED] wrote: > > dreid 01/07/07 05:26:32 > > > > Modified:include apr_sms.h > >memory/unix apr_sms.c apr_sms_trivial.c sms_private.h > > Log: > > Add the abort func

Re: cvs commit: apr/memory/unix apr_sms.c apr_sms_trivial.c sms_private.h

2001-07-07 Thread Justin Erenkrantz
On Sat, Jul 07, 2001 at 12:26:32PM -, [EMAIL PROTECTED] wrote: > dreid 01/07/07 05:26:32 > > Modified:include apr_sms.h >memory/unix apr_sms.c apr_sms_trivial.c sms_private.h > Log: > Add the abort function into sms. This is largely to keep compatability > w