Re: cvs commit: apr-util/xlate xlate.c

2004-06-23 Thread William A. Rowe, Jr.
Do we know what broke here from history? Was the pool arg added (breaking binary compat) in the 0.9 tree, or was this backing out a bugged change? At 01:00 PM 6/23/2004, [EMAIL PROTECTED] wrote: stoddard2004/06/23 11:00:02 Modified:xlateTag: APU_0_9_BRANCH xlate.c Log: Fix

Re: cvs commit: apr-util/xlate xlate.c

2004-06-23 Thread Bill Stoddard
This patch broke the build: http://cvs.apache.org/viewcvs.cgi/apr-util/xlate/xlate.c?r1=1.17.2.1r2=1.17.2.2 API to apr_iconv_open/close was changed about three years ago by this patch: http://cvs.apache.org/viewcvs.cgi/apr-iconv/lib/iconv.h?r1=1.7r2=1.8 I have no idea why Joe's patch was using an

Re: cvs commit: apr-util/xlate xlate.c

2004-06-23 Thread Joe Orton
On Wed, Jun 23, 2004 at 03:33:27PM -0400, Bill Stoddard wrote: This patch broke the build: http://cvs.apache.org/viewcvs.cgi/apr-util/xlate/xlate.c?r1=1.17.2.1r2=1.17.2.2 API to apr_iconv_open/close was changed about three years ago by this patch:

Re: cvs commit: apr-util/xlate xlate.c

2004-06-23 Thread William A. Rowe, Jr.
At 02:33 PM 6/23/2004, Bill Stoddard wrote: This patch broke the build: http://cvs.apache.org/viewcvs.cgi/apr-util/xlate/xlate.c?r1=1.17.2.1r2=1.17.2.2 API to apr_iconv_open/close was changed about three years ago by this patch: http://cvs.apache.org/viewcvs.cgi/apr-iconv/lib/iconv.h?r1=1.7r2=1.8

Re: cvs commit: apr-util/xlate xlate.c

2004-03-30 Thread Jeff Trawick
[EMAIL PROTECTED] wrote: jorton 2004/03/30 01:58:22 Modified:xlatexlate.c Log: * xlate/xlate.c (check_sbcs): Remove function which made unsafe assumptions (a theoretical issue), and was buggy in not resetting the iconv handle on failure (the cause of at least one real

Re: cvs commit: apr-util/xlate xlate.c

2004-03-30 Thread Joe Orton
On Tue, Mar 30, 2004 at 07:05:22AM -0500, Jeff Trawick wrote: [EMAIL PROTECTED] wrote: jorton 2004/03/30 01:58:22 Modified:xlatexlate.c Log: * xlate/xlate.c (check_sbcs): Remove function which made unsafe assumptions (a theoretical issue), and was buggy in not

Re: cvs commit: apr-util/xlate xlate.c

2004-03-30 Thread Jeff Trawick
Joe Orton wrote: On Tue, Mar 30, 2004 at 07:05:22AM -0500, Jeff Trawick wrote: [EMAIL PROTECTED] wrote: jorton 2004/03/30 01:58:22 Modified:xlatexlate.c Log: * xlate/xlate.c (check_sbcs): Remove function which made unsafe assumptions (a theoretical issue), and was buggy in not

RE: cvs commit: apr-util/xlate xlate.c

2002-07-19 Thread Sander Striker
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: 19 July 2002 19:09 striker 2002/07/19 10:08:40 Modified:buildapu-iconv.m4 xlatexlate.c Log: More fun with xlate... Make sure the macros actually work. Suck in apu_config, so that we

Re: cvs commit: apr-util/xlate xlate.c

2002-07-18 Thread Jeff Trawick
[EMAIL PROTECTED] writes: gstein 2002/07/17 17:12:14 Modified:xlatexlate.c Log: Fix some error handling for platforms with a broken iconv(). In certain cases, iconv will return -1 to indicate an error, but it won't set the errno variable. Return EINVAL in these

Re: cvs commit: apr-util/xlate xlate.c

2002-07-17 Thread David Shane Holden
Missed one. Shane [EMAIL PROTECTED] wrote: wrowe 2002/07/16 22:24:04 Modified:include apr_xlate.h xlatexlate.c Log: APU declares now Index: xlate/xlate.c === RCS file: