Re: cvs commit: apr-util CHANGES

2002-09-26 Thread Brian Pane
On Mon, 2002-09-23 at 03:30, Greg Stein wrote: > On Sun, Sep 22, 2002 at 07:00:42PM -0700, Brian Pane wrote: > > On Sun, 2002-09-22 at 16:34, Greg Stein wrote: > >... > > All the copying doesn't bother me as much, because it's the same > > thing that would happen if you did a dozen calls to apr_bri

Re: cvs commit: apr-util CHANGES

2002-09-23 Thread Cliff Woolley
On Mon, 23 Sep 2002, Greg Stein wrote: > The setaside is not your problem. You cannot and should not guess what is > going to or *might* happen. The brigades are supposed to be about *avoiding* > copies. If/when a copy *must* be made, then fine. But don't make judgements > in advance because you *

Re: cvs commit: apr-util CHANGES

2002-09-23 Thread Greg Stein
On Sun, Sep 22, 2002 at 07:00:42PM -0700, Brian Pane wrote: > On Sun, 2002-09-22 at 16:34, Greg Stein wrote: >... > All the copying doesn't bother me as much, because it's the same > thing that would happen if you did a dozen calls to apr_brigade_write() > for slightly less than APR_BUCKET_BUFF_SIZ

Re: cvs commit: apr-util CHANGES

2002-09-23 Thread Brian Pane
On Sun, 2002-09-22 at 16:34, Greg Stein wrote: > Ewww... icky implementation... If you have a dozen iovec's where each > iov_len is slightly less than APR_BUCKET_BUFF_SIZE, then you're going to > copy the entire thing onto the heap. > > > +/* Step 3: if necessary, output the brigade content

Re: cvs commit: apr-util CHANGES

2002-09-22 Thread Greg Stein
On Sat, Sep 21, 2002 at 11:40:41PM -, [EMAIL PROTECTED] wrote: >... > +{ > +apr_bucket *e = APR_BRIGADE_LAST(b); > +apr_size_t remaining; > +char *buf; > +apr_size_t bytes_written = 0; > +apr_size_t i; > + > +/* Step 1: check if there is a heap bucket at

Re: dependencies (was: cvs commit: apr-util CHANGES apu-config.in)

2002-09-19 Thread Aaron Bannert
On Thu, Sep 19, 2002 at 03:33:37PM -0700, Greg Stein wrote: > On Thu, Sep 19, 2002 at 11:50:04AM -0700, Justin Erenkrantz wrote: > > On Thu, Sep 19, 2002 at 11:09:01AM -0700, Aaron Bannert wrote: > > > As I said when apr-config and apu-config were created, it should ONLY > > > be used from an indep

dependencies (was: cvs commit: apr-util CHANGES apu-config.in)

2002-09-19 Thread Greg Stein
On Thu, Sep 19, 2002 at 11:50:04AM -0700, Justin Erenkrantz wrote: > On Thu, Sep 19, 2002 at 11:09:01AM -0700, Aaron Bannert wrote: > > As I said when apr-config and apu-config were created, it should ONLY > > be used from an independently installed APR or APR-UTIL. >... > I believe we must continu

Re: cvs commit: apr-util CHANGES apu-config.in

2002-09-19 Thread Greg Stein
I have nothing to add to this conversation other than Justin has my "proxy" for this stuff. His commentary on this thread perfectly matches what I would say myself. I believe our ap*-config design is proper, standard, flexible, and matches our desires and constraints well. Justin has done a great j

Re: cvs commit: apr-util CHANGES apu-config.in

2002-09-19 Thread Justin Erenkrantz
On Thu, Sep 19, 2002 at 01:02:15PM -0700, Aaron Bannert wrote: > On Thu, Sep 19, 2002 at 12:39:30PM -0700, Justin Erenkrantz wrote: > > They have all been converted to use apr-config and apu-config. > > I can't remember what the problem was that needed to be solved by doing > this, can you please

Re: cvs commit: apr-util CHANGES apu-config.in

2002-09-19 Thread Aaron Bannert
On Thu, Sep 19, 2002 at 12:39:30PM -0700, Justin Erenkrantz wrote: > They have all been converted to use apr-config and apu-config. I can't remember what the problem was that needed to be solved by doing this, can you please elaborate? (I'm probably forgetting something..) > The APR_FIND_APR/APR

Re: cvs commit: apr-util CHANGES apu-config.in

2002-09-19 Thread Justin Erenkrantz
On Thu, Sep 19, 2002 at 12:28:19PM -0700, Aaron Bannert wrote: > That is simply not true, because projects like httpd and flood have > been bundling APR and APR-UTIL since way before apr-config and > apu-config existed. They should keep doing what they did before, or > more to the new system. They

Re: cvs commit: apr-util CHANGES apu-config.in

2002-09-19 Thread Aaron Bannert
On Thu, Sep 19, 2002 at 12:22:57PM -0700, Justin Erenkrantz wrote: > On Thu, Sep 19, 2002 at 12:13:56PM -0700, Aaron Bannert wrote: > > Woah there. I'm just talking about apr-config and apu-config. Those > > scripts are there to help projects find and use and installed version > > of APR and APR-UT

Re: cvs commit: apr-util CHANGES apu-config.in

2002-09-19 Thread Justin Erenkrantz
On Thu, Sep 19, 2002 at 12:13:56PM -0700, Aaron Bannert wrote: > Woah there. I'm just talking about apr-config and apu-config. Those > scripts are there to help projects find and use and installed version > of APR and APR-UTIL. I don't have any problem with projects that still > wish to bundle it i

Re: cvs commit: apr-util CHANGES apu-config.in

2002-09-19 Thread Aaron Bannert
On Thu, Sep 19, 2002 at 11:50:04AM -0700, Justin Erenkrantz wrote: > On Thu, Sep 19, 2002 at 11:09:01AM -0700, Aaron Bannert wrote: > > As I said when apr-config and apu-config were created, it should ONLY > > be used from an independently installed APR or APR-UTIL. > > For those not on the flood

Re: cvs commit: apr-util CHANGES apu-config.in

2002-09-19 Thread Justin Erenkrantz
On Thu, Sep 19, 2002 at 11:09:01AM -0700, Aaron Bannert wrote: > As I said when apr-config and apu-config were created, it should ONLY > be used from an independently installed APR or APR-UTIL. For those not on the flood dev list, we've had this discussion there before. Basically, I disagree with

Re: cvs commit: apr-util CHANGES apu-config.in

2002-09-19 Thread David Reid
I find myself agreeing with Aaron here. We need to revisit this and fix it correctly... (Damn - agreeing with Aaron again...) david - Original Message - From: "Aaron Bannert" <[EMAIL PROTECTED]> To: Sent: Thursday, September 19, 2002 7:09 PM Subject: Re: cvs commit:

Re: cvs commit: apr-util CHANGES apu-config.in

2002-09-19 Thread Aaron Bannert
On Wed, Sep 18, 2002 at 11:31:46PM -0700, Justin Erenkrantz wrote: > On Wed, Sep 18, 2002 at 11:23:48PM -0700, Aaron Bannert wrote: > > On Thu, Sep 19, 2002 at 05:33:18AM -, Justin Erenkrantz wrote: > > > jerenkrantz2002/09/18 22:33:18 > > > > > > Modified:.CHANGES apu-config

Re: cvs commit: apr-util CHANGES apu-config.in

2002-09-19 Thread Justin Erenkrantz
On Wed, Sep 18, 2002 at 11:23:48PM -0700, Aaron Bannert wrote: > On Thu, Sep 19, 2002 at 05:33:18AM -, Justin Erenkrantz wrote: > > jerenkrantz2002/09/18 22:33:18 > > > > Modified:.CHANGES apu-config.in > > Log: > > Add --bindir option to apu-config so that users of APR-u

Re: cvs commit: apr-util CHANGES apu-config.in

2002-09-19 Thread Aaron Bannert
On Thu, Sep 19, 2002 at 05:33:18AM -, Justin Erenkrantz wrote: > jerenkrantz2002/09/18 22:33:18 > > Modified:.CHANGES apu-config.in > Log: > Add --bindir option to apu-config so that users of APR-util have an idea > where apu-config will end up so that they can do later