Re: svn commit: r574113 - /apr/apr/trunk/test/Makefile.in

2007-09-09 Thread Sander Temme
On Sep 9, 2007, at 6:17 PM, [EMAIL PROTECTED] wrote: Author: bojan Date: Sun Sep 9 18:17:48 2007 New Revision: 574113 URL: http://svn.apache.org/viewvc?rev=574113view=rev Log: Any test returning non-zero should stop make Aaaah! What about the other tests later in the sequence? Usually

Re: svn commit: r574113 - /apr/apr/trunk/test/Makefile.in

2007-09-09 Thread Bojan Smojver
On Sun, 2007-09-09 at 21:35 -0700, Sander Temme wrote: Aaaah! What about the other tests later in the sequence? Usually test targets complete every test, regardless of failures. The problem was that nobody ever knew that any of the tests actually failed, because make wouldn't stop. The

Re: svn commit: r574113 - /apr/apr/trunk/test/Makefile.in

2007-09-09 Thread William A. Rowe, Jr.
Bojan Smojver wrote: The idea, as understand it, is that if you run make, things should run from beginning to end, unattended. If tests fail midway through the run, then obviously things aren't working and they need attention. Each tester can then get into test directory and run other tests

Re: svn commit: r574113 - /apr/apr/trunk/test/Makefile.in

2007-09-09 Thread Bojan Smojver
On Mon, 2007-09-10 at 14:53 +1000, Bojan Smojver wrote: The problem was that nobody ever knew that any of the tests actually failed, because make wouldn't stop. http://issues.apache.org/bugzilla/show_bug.cgi?id=42725 -- Bojan

Re: svn commit: r574113 - /apr/apr/trunk/test/Makefile.in

2007-09-09 Thread Bojan Smojver
On Mon, 2007-09-10 at 00:03 -0500, William A. Rowe, Jr. wrote: The full list of failures should be reported, otherwise you only discover the first flaw and have no clue of the scope of the issue. OK, we can do that too, it's not difficult. -- Bojan

Re: svn commit: r574113 - /apr/apr/trunk/test/Makefile.in

2007-09-09 Thread Sander Temme
On Sep 9, 2007, at 9:53 PM, Bojan Smojver wrote: On Sun, 2007-09-09 at 21:35 -0700, Sander Temme wrote: Aaaah! What about the other tests later in the sequence? Usually test targets complete every test, regardless of failures. The problem was that nobody ever knew that any of the tests

Re: svn commit: r574113 - /apr/apr/trunk/test/Makefile.in

2007-09-09 Thread Bojan Smojver
On Sun, 2007-09-09 at 22:15 -0700, Sander Temme wrote: Make shouldn't stop, but run all the tests, quietly, and, if there are failures, emit a list of those failures and fail the target. At the end, not at the first failure. Hopefully r574134/5 should be better. Any dramas, let me know.