Re: MD4/MD5 implementation is non-free

2007-01-02 Thread Garrett Rooney
On 10/17/06, Cliff Schmidt [EMAIL PROTECTED] wrote: Joe, Not seeing the word distribute in the license, I would agree this needs to be clarified. There's an interesting mix of copyright terms (copy, derivative works), patent terms (use, make), and even an attribution requirement that is

[PATCH] Optimized MD5 implementation from OpenSSL

2007-01-02 Thread Justin Erenkrantz
One of the bottlenecks that keeps popping up in Subversion is the speed of the MD5 checksums. OpenSSL has put in some work to have optimized MD5 implementations and with David's recent work to detect OpenSSL. we can just defer to their implementations. For AMD64/EMT64 CPUs, we can leverage their

Re: apr_queue_t enhancement - please review for inclusion

2007-01-02 Thread Ryan Phillips
Yossi Neiman [EMAIL PROTECTED] said: Hi everybody, I worked up some enhancements to the apr_queue.c/h files, basically allowing manually blocking of push and/or pop, and also providing a function that will block until the queue is empty. I've already used this in some code that I have

Re: [PATCH] Optimized MD5 implementation from OpenSSL

2007-01-02 Thread Ruediger Pluem
On 01/02/2007 11:01 PM, Justin Erenkrantz wrote: However, the big annoying thing is that we declared apr_md5_ctx_t in apr_md5.h so it's not an opaque value. Luckily for us though, OpenSSL's MD5 context is smaller than APR's - so an ugly hack works. OpenSSL's ctx: #define

Re: apr_anylock.h location

2007-01-02 Thread Paul Querna
Mladen Turk wrote: Hi, Looking at the apr_anylock.h, and the fact that its totally independent of apr-util, can it be moved to apr? From the end user perspective nothing would change, because there can be no apr-util without apr, and apr users would have those macros without apr-util

Re: [PATCH] Optimized MD5 implementation from OpenSSL

2007-01-02 Thread Justin Erenkrantz
On 1/2/07, Ruediger Pluem [EMAIL PROTECTED] wrote: Can we be sure that M5_LONG is always 32bit on all platforms that are supported by apr-util? Well, probably. Ideally, the 'right' solution would be to use their structure rather than shoe-horning it into our slightly different structure. For

Re: [PATCH] Optimized MD5 implementation from OpenSSL

2007-01-02 Thread Issac Goldstand
If you do this, it might be a smart idea to write in the README and/or INSTALL and/or configure hints that it's worthwhile to link against OpenSSL even if you're not planning on using any crypto features, in order to benefit from this. Justin Erenkrantz wrote: But, again, really, the 'right'

Re: [PATCH] Optimized MD5 implementation from OpenSSL

2007-01-02 Thread Justin Erenkrantz
On 1/2/07, Issac Goldstand [EMAIL PROTECTED] wrote: If you do this, it might be a smart idea to write in the README and/or INSTALL and/or configure hints that it's worthwhile to link against OpenSSL even if you're not planning on using any crypto features, in order to benefit from this. Well,