Re: [RFC] apr_sockaddr_zone_set/get() etc v2

2017-11-27 Thread Joe Orton
Version #2. Adds both apr_sockaddr_zone_set() and apr_sockaddr_zone_get() to set and retrieve the zone id/name. Also now changes apr_sockaddr_equal() to compare different scopes as not equal, which I think is the only sensible way to do it, although that function is a bit odd in ignoring port

Re: [RFC] apr_sockaddr_zone_set()

2017-11-27 Thread Joe Orton
On Wed, Nov 22, 2017 at 09:01:55AM -0500, Philip M. Gollucci wrote: > Does it make sense to pull magic number 10 out into a #define ? Sorry, I missed this. Could do, but sure why really, it's pretty common to call strtol-like functions with hard-coded base? Regards, Joe

Re: [RFC] apr_sockaddr_zone_set/get() etc v2

2017-11-27 Thread Yann Ylavic
On Mon, Nov 27, 2017 at 5:54 PM, Joe Orton wrote: > Version #2. > > Adds both apr_sockaddr_zone_set() and apr_sockaddr_zone_get() to set and > retrieve the zone id/name. Looks good to me. > > Also now changes apr_sockaddr_equal() to compare different scopes as not > equal, which I think is the o