Re: svn commit: r1862071 - in /apr/apr/trunk: file_io/os2/dir.c file_io/unix/dir.c file_io/win32/dir.c include/apr_file_info.h test/testdir.c

2019-07-02 Thread Branko Čibej
On 02.07.2019 08:49, Joe Orton wrote: > On Thu, Jun 27, 2019 at 05:01:56PM +0300, Ivan Zhakov wrote: >> On Tue, 25 Jun 2019 at 17:21, wrote: >> >>> Author: jorton >>> Date: Tue Jun 25 14:21:56 2019 >>> New Revision: 1862071 >>> >>> URL: http://svn.apache.org/viewvc?rev=1862071&view=rev >>> Log: >>

Re: svn commit: r1862071 - in /apr/apr/trunk: file_io/os2/dir.c file_io/unix/dir.c file_io/win32/dir.c include/apr_file_info.h test/testdir.c

2019-07-02 Thread Joe Orton
On Tue, Jul 02, 2019 at 09:59:20AM +0200, Branko Čibej wrote: > On 02.07.2019 08:49, Joe Orton wrote: > > On Thu, Jun 27, 2019 at 05:01:56PM +0300, Ivan Zhakov wrote: > >> On Tue, 25 Jun 2019 at 17:21, wrote: > >> > >>> Author: jorton > >>> Date: Tue Jun 25 14:21:56 2019 > >>> New Revision: 186207

Re: svn commit: r1862071 - in /apr/apr/trunk: file_io/os2/dir.c file_io/unix/dir.c file_io/win32/dir.c include/apr_file_info.h test/testdir.c

2019-07-02 Thread Joe Orton
On Tue, Jul 02, 2019 at 11:18:31AM +0100, Joe Orton wrote: > Reading the win32 code a bit more, it is not constant-memory even with > the buffer in apr_dir_t, because it can allocate from dir->pool (and > even create cleanups!) in the more_finfo() call, so I think the current > behaviour is not

Re: svn commit: r1862071 - in /apr/apr/trunk: file_io/os2/dir.c file_io/unix/dir.c file_io/win32/dir.c include/apr_file_info.h test/testdir.c

2019-07-02 Thread Branko Čibej
On 02.07.2019 14:04, Joe Orton wrote: > On Tue, Jul 02, 2019 at 11:18:31AM +0100, Joe Orton wrote: >> Reading the win32 code a bit more, it is not constant-memory even with >> the buffer in apr_dir_t, because it can allocate from dir->pool (and >> even create cleanups!) in the more_finfo() call,

Re: svn commit: r1862071 - in /apr/apr/trunk: file_io/os2/dir.c file_io/unix/dir.c file_io/win32/dir.c include/apr_file_info.h test/testdir.c

2019-07-02 Thread Greg Stein
On Tue, Jul 2, 2019 at 8:04 AM Branko Čibej wrote: >... > Perhaps this is the right time to note (again) that over in Subversion > land, we found that functions should take _two_ pool parameters: one for > allocating the returned values and one for temporary allocations. This > is better than fun

Re: svn commit: r1862071 - in /apr/apr/trunk: file_io/os2/dir.c file_io/unix/dir.c file_io/win32/dir.c include/apr_file_info.h test/testdir.c

2019-07-02 Thread Joe Orton
On Tue, Jul 02, 2019 at 08:22:47AM -0500, Greg Stein wrote: > On Tue, Jul 2, 2019 at 8:04 AM Branko Čibej wrote: > > Perhaps this is the right time to note (again) that over in Subversion > > land, we found that functions should take _two_ pool parameters: one for > > allocating the returned value

buildbot exception in on apr-trunk

2019-07-02 Thread buildbot
The Buildbot has detected a build exception on builder apr-trunk while building . Full details are available at: https://ci.apache.org/builders/apr-trunk/builds/434 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: orcus_ubuntu Build Reason: The AnyBranchScheduler scheduler na