[ bringing this conversation just to [EMAIL PROTECTED] at this point ]
On Mon, Feb 05, 2001 at 06:09:45PM -0500, Greg Hudson wrote:
I spent a good amount of time trying to figure out the right
combination to allow us to include string.h and strings.h (which
is done by apr_want.h) without
+1 ... we need these changes, only we have attacked this as time has permitted.
My only comment, take this group:
apr_get_shm_nameapr_shm_name_get
apr_set_shm_nameapr_shm_name_set
apr_open_shmem apr_shm_open
I'd personally like to see apr_shm_get/set_name
On Mon, Feb 05, 2001 at 09:21:55PM -0800, Doug MacEachern wrote:
there's a number of places where apr (and httpd) is not consistent with
prefixes or doesn't use one at all (beyond apr_ or ap_).
personally, i like to see functions named with the prefix of the base type
(struct) they operate on
Modified:modules/generators mod_cgi.c mod_cgid.c
buckets apr_buckets_heap.c
Damn, I committed from too high in my tree. :-(
The bucket change was supposed to happen in the next commit. Basically,
we try to overallocate in the heap bucket itself, which is
incorrect.
