[PATCH] APR hash documentation

2015-12-10 Thread Stefan Fuhrmann
Hi there, since 1.4.6, the hash implementation allows for mismatching and custom hash functions when merging hashes. But the docstrings have not been updated. -- Stefan^2. [[[ Since 1.4.6, apr_hash_overlay and apr_hash_merge work with any combination of hash functions. Reflect that change in

Re: apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread Julian Foad
Ivan Zhakov wrote: > On 10 December 2015 at 19:14, Julian Foad wrote: >> APR devs, Subversion devs: >> >> On Subversion's Mac OS buildbots it appears that apr_hash_overlay() >> sometimes returns a hash containing duplicate keys, which (as I >> understand it) should be

Re: apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread Ivan Zhakov
On 10 December 2015 at 20:20, Julian Foad wrote: > Ivan Zhakov wrote: >> On 10 December 2015 at 19:14, Julian Foad wrote: >>> APR devs, Subversion devs: >>> >>> On Subversion's Mac OS buildbots it appears that apr_hash_overlay() >>> sometimes

RE: apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread Bert Huijben
Are both hash tables created with the same hash function? (I think stefan2 introduced some variants). Otherwise I would expect some key values to be changed somewhere after adding to the first hashtable… But I don’t think this is really a likely scenario. Bert Sent from Outlook Mail for

Re: apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread William A Rowe Jr
Which public API, APR's or svn's? On Dec 10, 2015 11:24 AM, "Ivan Zhakov" wrote: > On 10 December 2015 at 20:20, Julian Foad wrote: > > Ivan Zhakov wrote: > >> On 10 December 2015 at 19:14, Julian Foad > wrote: > >>> APR devs,

Re: apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread Ivan Zhakov
On 11 December 2015 at 06:18, William A Rowe Jr wrote: > Which public API, APR's or svn's? > Subversion's. Sorry I forgot that dev@a.a.o list is in cc. -- Ivan Zhakov

apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread Julian Foad
APR devs, Subversion devs: On Subversion's Mac OS buildbots it appears that apr_hash_overlay() sometimes returns a hash containing duplicate keys, which (as I understand it) should be impossible. We had an issue where some 'svnmover' tests were failing only on Mac OS buildbots. I added some

Re: apr_hash_overlay returns hash with duplicate keys

2015-12-10 Thread Ivan Zhakov
On 10 December 2015 at 19:14, Julian Foad wrote: > APR devs, Subversion devs: > > On Subversion's Mac OS buildbots it appears that apr_hash_overlay() > sometimes returns a hash containing duplicate keys, which (as I > understand it) should be impossible. > > We had an issue