Re: [poll] Resolving readdir_r warning (Re: Showstoppers to 1.7.0?)

2019-03-28 Thread William A Rowe Jr
Yes, that patch is option 2... and I would be alright with that choice. Looking for consensus on which way we resolve this. Opinions? On Thu, Mar 28, 2019, 10:55 Yann Ylavic wrote: > On Thu, Mar 28, 2019 at 4:19 PM William A Rowe Jr > wrote: > > > > So... What is our preferred solution as of

Re: [poll] Resolving readdir_r warning (Re: Showstoppers to 1.7.0?)

2019-03-28 Thread Yann Ylavic
On Thu, Mar 28, 2019 at 4:55 PM Yann Ylavic wrote: > > On Thu, Mar 28, 2019 at 4:19 PM William A Rowe Jr wrote: > > > > So... What is our preferred solution as of 1.7.0? > > > > 1. Drop readdir[64]_r for readdir[64] always. > > 2. Allow readdir[64]_r with an autoconf toggle, skip detection. > >

[poll] Resolving readdir_r warning (Re: Showstoppers to 1.7.0?)

2019-03-28 Thread William A Rowe Jr
So to this question, glibc 2.24 is the first release to loudly deprecate readdir_r. https://www.sourceware.org/ml/libc-alpha/2016-08/msg00212.html However, the docs summary mentioned below calls out reasons why readdir_r was never a good thing. So... What is our preferred solution as of 1.7.0?